Title: [253529] trunk
Revision
253529
Author
pvol...@apple.com
Date
2019-12-14 15:20:45 -0800 (Sat, 14 Dec 2019)

Log Message

[iOS] Deny mach lookup access to "*.viewservice" in the WebContent process
https://bugs.webkit.org/show_bug.cgi?id=205240

Reviewed by Brent Fulgham.

Source/WebKit:

As part of sandbox hardening in the WebContent process, mach lookup access to “*.viewservice” should be removed.

Test: fast/sandbox/ios/sandbox-mach-lookup.html

* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

LayoutTests:

* fast/sandbox/ios/sandbox-mach-lookup-expected.txt:
* fast/sandbox/ios/sandbox-mach-lookup.html:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (253528 => 253529)


--- trunk/LayoutTests/ChangeLog	2019-12-14 21:49:11 UTC (rev 253528)
+++ trunk/LayoutTests/ChangeLog	2019-12-14 23:20:45 UTC (rev 253529)
@@ -1,3 +1,13 @@
+2019-12-14  Per Arne Vollan  <pvol...@apple.com>
+
+        [iOS] Deny mach lookup access to "*.viewservice" in the WebContent process
+        https://bugs.webkit.org/show_bug.cgi?id=205240
+
+        Reviewed by Brent Fulgham.
+
+        * fast/sandbox/ios/sandbox-mach-lookup-expected.txt:
+        * fast/sandbox/ios/sandbox-mach-lookup.html:
+
 2019-12-13  Myles C. Maxfield  <mmaxfi...@apple.com>
 
         [watchOS] Apple.com is rendered in Times New Roman

Modified: trunk/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup-expected.txt (253528 => 253529)


--- trunk/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup-expected.txt	2019-12-14 21:49:11 UTC (rev 253528)
+++ trunk/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup-expected.txt	2019-12-14 23:20:45 UTC (rev 253529)
@@ -4,4 +4,5 @@
 
 
 PASS internals.hasSandboxMachLookupAccessToXPCServiceName("com.apple.WebKit.WebContent", "com.apple.apple-extension-service") is false
+PASS internals.hasSandboxMachLookupAccessToXPCServiceName("com.apple.WebKit.WebContent", "com.apple.viewservice") is false
 

Modified: trunk/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup.html (253528 => 253529)


--- trunk/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup.html	2019-12-14 21:49:11 UTC (rev 253528)
+++ trunk/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup.html	2019-12-14 23:20:45 UTC (rev 253529)
@@ -7,6 +7,7 @@
 
 if (window.internals) {
     shouldBeFalse("internals.hasSandboxMachLookupAccessToXPCServiceName(\"com.apple.WebKit.WebContent\", \"com.apple.apple-extension-service\")");
+    shouldBeFalse("internals.hasSandboxMachLookupAccessToXPCServiceName(\"com.apple.WebKit.WebContent\", \"com.apple.viewservice\")");
 }
 </script>
 </head>

Modified: trunk/Source/WebKit/ChangeLog (253528 => 253529)


--- trunk/Source/WebKit/ChangeLog	2019-12-14 21:49:11 UTC (rev 253528)
+++ trunk/Source/WebKit/ChangeLog	2019-12-14 23:20:45 UTC (rev 253529)
@@ -1,3 +1,16 @@
+2019-12-14  Per Arne Vollan  <pvol...@apple.com>
+
+        [iOS] Deny mach lookup access to "*.viewservice" in the WebContent process
+        https://bugs.webkit.org/show_bug.cgi?id=205240
+
+        Reviewed by Brent Fulgham.
+
+        As part of sandbox hardening in the WebContent process, mach lookup access to “*.viewservice” should be removed.
+
+        Test: fast/sandbox/ios/sandbox-mach-lookup.html
+
+        * Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
+
 2019-12-14  Chris Dumez  <cdu...@apple.com>
 
         WebSWServerConnection::startFetch() should never fail synchronously

Modified: trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb (253528 => 253529)


--- trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb	2019-12-14 21:49:11 UTC (rev 253528)
+++ trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb	2019-12-14 23:20:45 UTC (rev 253529)
@@ -443,7 +443,6 @@
 
     (allow mach-lookup (with report) (with telemetry)
         (global-name-regex #"^com\.apple\.uikit\.viewservice\..+")
-        (xpc-service-name-regex #"\.viewservice$") ;; <rdar://problem/31252371>
     )
 
     ; UIKit-required IOKit nodes.
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to