Diff
Modified: trunk/Source/WebCore/ChangeLog (103454 => 103455)
--- trunk/Source/WebCore/ChangeLog 2011-12-21 22:38:33 UTC (rev 103454)
+++ trunk/Source/WebCore/ChangeLog 2011-12-21 22:43:58 UTC (rev 103455)
@@ -1,3 +1,21 @@
+2011-12-21 Michał Pakuła vel Rutka <[email protected]>
+
+ [EFL] Add 'Select All' option to context menus in WebKit-EFL.
+ https://bugs.webkit.org/show_bug.cgi?id=74920
+
+ Reviewed by Eric Seidel.
+
+ Enable 'Select All' option to context menus called on input fields in WebKit-EFL
+ as it is enabled in GTK and QT ports.
+
+ * page/ContextMenuController.cpp:
+ (WebCore::ContextMenuController::contextMenuItemSelected): Add 'Select All' option.
+ (WebCore::ContextMenuController::populate): Append 'Select All' item.
+ (WebCore::ContextMenuController::checkOrEnableIfNeeded): Enable 'Select All' option.
+ * platform/ContextMenuItem.h: Add 'Select All' option.
+ * platform/LocalizationStrategy.h: Add constructor for 'Select All' option.
+ * platform/LocalizedStrings.h: Add constructor for 'Select All' option.
+
2011-12-20 Adam Klein <[email protected]>
Make calls to willModifyAttribute and attributeChanged symmetrical
Modified: trunk/Source/WebCore/page/ContextMenuController.cpp (103454 => 103455)
--- trunk/Source/WebCore/page/ContextMenuController.cpp 2011-12-21 22:38:33 UTC (rev 103454)
+++ trunk/Source/WebCore/page/ContextMenuController.cpp 2011-12-21 22:43:58 UTC (rev 103455)
@@ -284,7 +284,7 @@
frame->editor()->performDelete();
break;
#endif
-#if PLATFORM(GTK) || PLATFORM(QT)
+#if PLATFORM(GTK) || PLATFORM(QT) || PLATFORM(EFL)
case ContextMenuItemTagSelectAll:
frame->editor()->command("SelectAll").execute();
break;
@@ -685,7 +685,7 @@
#if PLATFORM(GTK)
ContextMenuItem DeleteItem(ActionType, ContextMenuItemTagDelete, contextMenuItemTagDelete());
#endif
-#if PLATFORM(GTK) || PLATFORM(QT)
+#if PLATFORM(GTK) || PLATFORM(QT) || PLATFORM(EFL)
ContextMenuItem SelectAllItem(ActionType, ContextMenuItemTagSelectAll, contextMenuItemTagSelectAll());
#endif
@@ -904,7 +904,7 @@
appendItem(DeleteItem, m_contextMenu.get());
appendItem(*separatorItem(), m_contextMenu.get());
#endif
-#if PLATFORM(GTK) || PLATFORM(QT)
+#if PLATFORM(GTK) || PLATFORM(QT) || PLATFORM(EFL)
appendItem(SelectAllItem, m_contextMenu.get());
#endif
@@ -1054,12 +1054,16 @@
case ContextMenuItemTagDelete:
shouldEnable = frame->editor()->canDelete();
break;
- case ContextMenuItemTagSelectAll:
case ContextMenuItemTagInputMethods:
case ContextMenuItemTagUnicode:
shouldEnable = true;
break;
#endif
+#if PLATFORM(GTK) || PLATFORM(EFL)
+ case ContextMenuItemTagSelectAll:
+ shouldEnable = true;
+ break;
+#endif
case ContextMenuItemTagUnderline: {
shouldCheck = frame->editor()->selectionHasStyle(CSSPropertyWebkitTextDecorationsInEffect, "underline") != FalseTriState;
shouldEnable = frame->editor()->canEditRichly();
Modified: trunk/Source/WebCore/platform/ContextMenuItem.h (103454 => 103455)
--- trunk/Source/WebCore/platform/ContextMenuItem.h 2011-12-21 22:38:33 UTC (rev 103454)
+++ trunk/Source/WebCore/platform/ContextMenuItem.h 2011-12-21 22:43:58 UTC (rev 103455)
@@ -78,7 +78,7 @@
#if PLATFORM(GTK)
ContextMenuItemTagDelete,
#endif
-#if PLATFORM(GTK) || PLATFORM(QT)
+#if PLATFORM(GTK) || PLATFORM(QT) || PLATFORM (EFL)
ContextMenuItemTagSelectAll,
#endif
#if PLATFORM(GTK)
Modified: trunk/Source/WebCore/platform/LocalizationStrategy.h (103454 => 103455)
--- trunk/Source/WebCore/platform/LocalizationStrategy.h 2011-12-21 22:38:33 UTC (rev 103454)
+++ trunk/Source/WebCore/platform/LocalizationStrategy.h 2011-12-21 22:43:58 UTC (rev 103455)
@@ -74,7 +74,7 @@
virtual String contextMenuItemTagInputMethods() = 0;
virtual String contextMenuItemTagUnicode() = 0;
#endif
-#if PLATFORM(GTK) || PLATFORM(QT)
+#if PLATFORM(GTK) || PLATFORM(QT) || PLATFORM(EFL)
virtual String contextMenuItemTagSelectAll() = 0;
#endif
virtual String contextMenuItemTagNoGuessesFound() = 0;
Modified: trunk/Source/WebCore/platform/LocalizedStrings.h (103454 => 103455)
--- trunk/Source/WebCore/platform/LocalizedStrings.h 2011-12-21 22:38:33 UTC (rev 103454)
+++ trunk/Source/WebCore/platform/LocalizedStrings.h 2011-12-21 22:43:58 UTC (rev 103455)
@@ -70,7 +70,7 @@
String contextMenuItemTagInputMethods();
String contextMenuItemTagUnicode();
#endif
-#if PLATFORM(GTK) || PLATFORM(QT)
+#if PLATFORM(GTK) || PLATFORM(QT) || PLATFORM(EFL)
String contextMenuItemTagSelectAll();
#endif
String contextMenuItemTagNoGuessesFound();
Modified: trunk/Source/WebKit/efl/ChangeLog (103454 => 103455)
--- trunk/Source/WebKit/efl/ChangeLog 2011-12-21 22:38:33 UTC (rev 103454)
+++ trunk/Source/WebKit/efl/ChangeLog 2011-12-21 22:43:58 UTC (rev 103455)
@@ -1,3 +1,15 @@
+2011-12-21 Michał Pakuła vel Rutka <[email protected]>
+
+ [EFL] Add 'Select All' option to context menus in WebKit-EFL.
+ https://bugs.webkit.org/show_bug.cgi?id=74920
+
+ Reviewed by Eric Seidel.
+
+ Enable 'Select All' option to context menus called on input fields in WebKit-EFL
+ as it is enabled in GTK and QT ports.
+
+ * ewk/ewk_contextmenu.h: Add new context menu option 'Select All'.
+
2011-12-19 Ryuan Choi <[email protected]>
[EFL] Change the behavior of ewk_view_scale_set.
Modified: trunk/Source/WebKit/efl/ewk/ewk_contextmenu.h (103454 => 103455)
--- trunk/Source/WebKit/efl/ewk/ewk_contextmenu.h 2011-12-21 22:38:33 UTC (rev 103454)
+++ trunk/Source/WebKit/efl/ewk/ewk_contextmenu.h 2011-12-21 22:43:58 UTC (rev 103455)
@@ -65,6 +65,7 @@
EWK_CONTEXT_MENU_ITEM_TAG_RELOAD,
EWK_CONTEXT_MENU_ITEM_TAG_CUT,
EWK_CONTEXT_MENU_ITEM_TAG_PASTE,
+ EWK_CONTEXT_MENU_ITEM_TAG_SELECT_ALL,
EWK_CONTEXT_MENU_ITEM_TAG_SPELLING_GUESS,
EWK_CONTEXT_MENU_ITEM_TAG_NO_GUESSES_FOUND,
EWK_CONTEXT_MENU_ITEM_TAG_IGNORE_SPELLING,
