Title: [253908] trunk/Tools
- Revision
- 253908
- Author
- [email protected]
- Date
- 2019-12-25 05:09:04 -0800 (Wed, 25 Dec 2019)
Log Message
REGRESSION (r253282): Tests that use applyAutocorrection assert in UIScriptContext::requestUIScriptCompletion
https://bugs.webkit.org/show_bug.cgi?id=205588
<rdar://problem/58109942>
Reviewed by Tim Horton.
The change made in r253282 intended to defer completing the async task prepared in
UIScriptController::applyAutocorrection until after the current runloop; however, it ended up keeping the
synchronous call to asyncTaskComplete. Fix this by removing this code, so that we instead wait for the
dispatch_async block to invoke asyncTaskComplete.
* WebKitTestRunner/ios/UIScriptControllerIOS.mm:
(WTR::UIScriptControllerIOS::applyAutocorrection):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (253907 => 253908)
--- trunk/Tools/ChangeLog 2019-12-25 12:38:19 UTC (rev 253907)
+++ trunk/Tools/ChangeLog 2019-12-25 13:09:04 UTC (rev 253908)
@@ -1,3 +1,19 @@
+2019-12-25 Wenson Hsieh <[email protected]>
+
+ REGRESSION (r253282): Tests that use applyAutocorrection assert in UIScriptContext::requestUIScriptCompletion
+ https://bugs.webkit.org/show_bug.cgi?id=205588
+ <rdar://problem/58109942>
+
+ Reviewed by Tim Horton.
+
+ The change made in r253282 intended to defer completing the async task prepared in
+ UIScriptController::applyAutocorrection until after the current runloop; however, it ended up keeping the
+ synchronous call to asyncTaskComplete. Fix this by removing this code, so that we instead wait for the
+ dispatch_async block to invoke asyncTaskComplete.
+
+ * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
+ (WTR::UIScriptControllerIOS::applyAutocorrection):
+
2019-12-24 Youenn Fablet <[email protected]>
Deny Notification API access for non secure contexts
Modified: trunk/Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm (253907 => 253908)
--- trunk/Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm 2019-12-25 12:38:19 UTC (rev 253907)
+++ trunk/Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm 2019-12-25 13:09:04 UTC (rev 253908)
@@ -665,9 +665,6 @@
return;
m_context->asyncTaskComplete(callbackID);
}).get());
- if (!m_context)
- return;
- m_context->asyncTaskComplete(callbackID);
}).get()];
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
