Title: [253913] trunk/LayoutTests
- Revision
- 253913
- Author
- [email protected]
- Date
- 2019-12-26 02:11:15 -0800 (Thu, 26 Dec 2019)
Log Message
REGRESSION: [ Mojave+ Debug ] fast/mediastream/captureStream/canvas2d-heavy-drawing.html is a flakey failure
https://bugs.webkit.org/show_bug.cgi?id=205365
<rdar://problem/58026430>
Reviewed by Eric Carlson.
* fast/mediastream/captureStream/canvas2d-heavy-drawing.html:
Unflake test by comparing the number of frames with the number of printLine calls.
They should never diverge too much one from the other.
* platform/mac-wk2/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (253912 => 253913)
--- trunk/LayoutTests/ChangeLog 2019-12-26 02:06:13 UTC (rev 253912)
+++ trunk/LayoutTests/ChangeLog 2019-12-26 10:11:15 UTC (rev 253913)
@@ -1,3 +1,16 @@
+2019-12-26 youenn fablet <[email protected]>
+
+ REGRESSION: [ Mojave+ Debug ] fast/mediastream/captureStream/canvas2d-heavy-drawing.html is a flakey failure
+ https://bugs.webkit.org/show_bug.cgi?id=205365
+ <rdar://problem/58026430>
+
+ Reviewed by Eric Carlson.
+
+ * fast/mediastream/captureStream/canvas2d-heavy-drawing.html:
+ Unflake test by comparing the number of frames with the number of printLine calls.
+ They should never diverge too much one from the other.
+ * platform/mac-wk2/TestExpectations:
+
2019-12-25 Zalan Bujtas <[email protected]>
Run with offset from the content box's logical left paint its tab stop at wrong position.
Modified: trunk/LayoutTests/fast/mediastream/captureStream/canvas2d-heavy-drawing.html (253912 => 253913)
--- trunk/LayoutTests/fast/mediastream/captureStream/canvas2d-heavy-drawing.html 2019-12-26 02:06:13 UTC (rev 253912)
+++ trunk/LayoutTests/fast/mediastream/captureStream/canvas2d-heavy-drawing.html 2019-12-26 10:11:15 UTC (rev 253913)
@@ -12,14 +12,11 @@
var canvas2 = document.getElementById("canvas2");
var video = document.getElementById("video");
-var previousTrackSampleCount = 0
function validateCanvas(resolve, reject)
{
try {
- if (window.internals) {
- assert_true((internals.trackVideoSampleCount - previousTrackSampleCount) <= 1, "got too much internals.trackVideoSampleCount");
- previousTrackSampleCount = internals.trackVideoSampleCount;
- }
+ if (window.internals)
+ assert_greater_than_equal(numberPrintLines + 1, internals.trackVideoSampleCount);
canvas2.getContext("2d").drawImage(video, 0 ,0);
assert_array_equals(canvas2.getContext("2d").getImageData(0 ,0, 100, 100).data, canvas2.getContext("2d").getImageData(0, 0, 100, 100).data);
} catch(e) {
@@ -34,8 +31,6 @@
return new Promise((resolve, reject) => {
video.srcObject = stream;
video._onplay_ = () => {
- if (window.internals)
- previousTrackSampleCount = internals.trackVideoSampleCount;
validateCanvas(resolve, reject);
setTimeout(resolve, 500);
}
@@ -42,9 +37,11 @@
});
}
+var numberPrintLines = 0;
var cptr = 0;
function printLine()
{
+ numberPrintLines++;
var context = canvas1.getContext("2d");
context.fillStyle = "red";
for (var i = 0 ; i < 100; ++i)
Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (253912 => 253913)
--- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2019-12-26 02:06:13 UTC (rev 253912)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2019-12-26 10:11:15 UTC (rev 253913)
@@ -926,6 +926,4 @@
webkit.org/b/205301 [ Mojave+ ] inspector/canvas/requestShaderSource-webgpu.html [ Pass Failure ]
-wbekit.org/b/205365 [ Mojave+ Debug ] fast/mediastream/captureStream/canvas2d-heavy-drawing.html [ Pass Failure ]
-
-webkit.org/b/171784 fast/shadow-dom/link-element-in-shadow-tree.html [ Pass Failure ]
\ No newline at end of file
+webkit.org/b/171784 fast/shadow-dom/link-element-in-shadow-tree.html [ Pass Failure ]
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
