[webkit-changes] [253940] trunk/Source

Sun, 29 Dec 2019 13:57:05 -0800

Title: [253940] trunk/Source
Revision
253940
Author
[email protected]
Date
2019-12-29 13:55:51 -0800 (Sun, 29 Dec 2019)

Log Message

Cleanup media IPC encoders
https://bugs.webkit.org/show_bug.cgi?id=205630
<rdar://problem/58232173>

Reviewed by Anders Carlsson.

Source/WebCore:

No new tests, no functional change.

* platform/graphics/MediaPlayer.h:
(WebCore::MediaEngineSupportParameters::decode):

Source/WebKit:

* GPUProcess/media/RemoteMediaPlayerProxyConfiguration.h:
(WebKit::RemoteMediaPlayerProxyConfiguration::decode):
* WebProcess/GPU/media/RemoteMediaPlayerConfiguration.h:
(WebKit::RemoteMediaPlayerConfiguration::decode):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (253939 => 253940)


--- trunk/Source/WebCore/ChangeLog	2019-12-29 21:43:12 UTC (rev 253939)
+++ trunk/Source/WebCore/ChangeLog	2019-12-29 21:55:51 UTC (rev 253940)
@@ -1,3 +1,16 @@
+2019-12-29  Eric Carlson  <[email protected]>
+
+        Cleanup media IPC encoders
+        https://bugs.webkit.org/show_bug.cgi?id=205630
+        <rdar://problem/58232173>
+
+        Reviewed by Anders Carlsson.
+
+        No new tests, no functional change.
+
+        * platform/graphics/MediaPlayer.h:
+        (WebCore::MediaEngineSupportParameters::decode):
+
 2019-12-27  Dean Jackson  <[email protected]>
 
         [WebGL] Add a pure virtual base class for GraphicsContext3D

Modified: trunk/Source/WebCore/platform/graphics/MediaPlayer.h (253939 => 253940)


--- trunk/Source/WebCore/platform/graphics/MediaPlayer.h	2019-12-29 21:43:12 UTC (rev 253939)
+++ trunk/Source/WebCore/platform/graphics/MediaPlayer.h	2019-12-29 21:55:51 UTC (rev 253940)
@@ -122,7 +122,7 @@
         if (!typesRequiringHardware)
             return WTF::nullopt;
 
-        return {{ WTFMove(*type), WTFMove(*url), WTFMove(*isMediaSource), WTFMove(*isMediaStream), WTFMove(*typesRequiringHardware) }};
+        return {{ WTFMove(*type), WTFMove(*url), *isMediaSource, *isMediaStream, *typesRequiringHardware }};
     }
 };

Modified: trunk/Source/WebKit/ChangeLog (253939 => 253940)


--- trunk/Source/WebKit/ChangeLog	2019-12-29 21:43:12 UTC (rev 253939)
+++ trunk/Source/WebKit/ChangeLog	2019-12-29 21:55:51 UTC (rev 253940)
@@ -1,3 +1,16 @@
+2019-12-29  Eric Carlson  <[email protected]>
+
+        Cleanup media IPC encoders
+        https://bugs.webkit.org/show_bug.cgi?id=205630
+        <rdar://problem/58232173>
+
+        Reviewed by Anders Carlsson.
+
+        * GPUProcess/media/RemoteMediaPlayerProxyConfiguration.h:
+        (WebKit::RemoteMediaPlayerProxyConfiguration::decode):
+        * WebProcess/GPU/media/RemoteMediaPlayerConfiguration.h:
+        (WebKit::RemoteMediaPlayerConfiguration::decode):
+
 2019-12-28  Antti Koivisto  <[email protected]>
 
         Make simple line layout an internal feature

Modified: trunk/Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxyConfiguration.h (253939 => 253940)


--- trunk/Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxyConfiguration.h	2019-12-29 21:43:12 UTC (rev 253939)
+++ trunk/Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxyConfiguration.h	2019-12-29 21:55:51 UTC (rev 253940)
@@ -128,9 +128,9 @@
             WTFMove(*mediaCacheDirectory),
             WTFMove(*mediaContentTypesRequiringHardwareSupport),
             WTFMove(*preferredAudioCharacteristics),
-            WTFMove(*logIdentifier),
-            WTFMove(*shouldUsePersistentCache),
-            WTFMove(*isVideo),
+            *logIdentifier,
+            *shouldUsePersistentCache,
+            *isVideo,
         }};
     }
 };

Modified: trunk/Source/WebKit/WebProcess/GPU/media/RemoteMediaPlayerConfiguration.h (253939 => 253940)


--- trunk/Source/WebKit/WebProcess/GPU/media/RemoteMediaPlayerConfiguration.h	2019-12-29 21:43:12 UTC (rev 253939)
+++ trunk/Source/WebKit/WebProcess/GPU/media/RemoteMediaPlayerConfiguration.h	2019-12-29 21:55:51 UTC (rev 253940)
@@ -87,10 +87,10 @@
 
         return {{
             WTFMove(*engineDescription),
-            WTFMove(*supportsScanning),
-            WTFMove(*supportsPictureInPicture),
-            WTFMove(*supportsAcceleratedRendering),
-            WTFMove(*canPlayToWirelessPlaybackTarget),
+            *supportsScanning,
+            *supportsPictureInPicture,
+            *supportsAcceleratedRendering,
+            *canPlayToWirelessPlaybackTarget,
         }};
     }
 };

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to