Diff
Modified: trunk/LayoutTests/ChangeLog (254186 => 254187)
--- trunk/LayoutTests/ChangeLog 2020-01-08 05:02:02 UTC (rev 254186)
+++ trunk/LayoutTests/ChangeLog 2020-01-08 06:40:29 UTC (rev 254187)
@@ -1,3 +1,19 @@
+2020-01-07 Said Abou-Hallawa <sabouhall...@apple.com>
+
+ Implement css3-images image-orientation
+ https://bugs.webkit.org/show_bug.cgi?id=89052
+
+ Reviewed by Simon Fraser.
+
+ Test the css image-orientation property.
+
+ * fast/images/image-orientation-dynamic-from-image-expected.html: Added.
+ * fast/images/image-orientation-dynamic-from-image.html: Added.
+ * fast/images/image-orientation-dynamic-none-expected.html: Added.
+ * fast/images/image-orientation-dynamic-none.html: Added.
+ * fast/images/image-orientation-none-expected.html: Added.
+ * fast/images/image-orientation-none.html: Added.
+
2020-01-07 Fujii Hironori <fujii.hiron...@gmail.com>
[GTK] fast/text/atsui-rtl-override-selection.html is failing since r254114
Added: trunk/LayoutTests/fast/images/image-orientation-dynamic-from-image-expected.html (0 => 254187)
--- trunk/LayoutTests/fast/images/image-orientation-dynamic-from-image-expected.html (rev 0)
+++ trunk/LayoutTests/fast/images/image-orientation-dynamic-from-image-expected.html 2020-01-08 06:40:29 UTC (rev 254187)
@@ -0,0 +1,105 @@
+<!DOCTYPE html>
+<style>
+ div.container {
+ display: inline-block;
+ margin-right: 20px;
+ margin-bottom: 10px;
+ width: 100px;
+ vertical-align: top;
+ }
+ div.horizontal {
+ width: 102px;
+ height: 52px;
+ }
+ div.vertical {
+ width: 52px;
+ height: 102px;
+ }
+ img {
+ border: 1px solid black;
+ }
+</style>
+<body>
+ <b>The images of the <img> elements should respect their EXIF orientation after setting their style image-orientation to "from-image".</b>
+ <br>
+ <br>
+ <div class="container">
+ <div class="horizontal">
+ <img id="img1" src=""
+ </div>
+ <br>Normal
+ </div>
+ <div class="container">
+ <div class="horizontal">
+ <img id="img2" src="" style="transform: scaleX(-1);">
+ </div>
+ <br>Flipped horizontally
+ </div>
+ <div class="container">
+ <div class="horizontal">
+ <img id="img3" src="" style="transform: rotate(180deg);">
+ </div>
+ <br>Rotated 180°
+ </div>
+ <div class="container">
+ <div class="horizontal">
+ <img id="img4" src="" style="transform: scaleX(-1) rotate(180deg);">
+ </div>
+ <br>Flipped vertically
+ </div>
+ <br>
+ <div class="container">
+ <div class="vertical">
+ <img id="img5" src="" style="transform: translate(-25px, 25px) rotate(90deg) scaleY(-1);">
+ </div>
+ <br>Rotated 90° CCW and flipped vertically
+ </div>
+ <div class="container">
+ <div class="vertical">
+ <img id="img6" src="" style="transform: translate(-25px, 25px) rotate(90deg);">
+ </div>
+ <br>Rotated 90° CCW
+ </div>
+ <div class="container">
+ <div class="vertical">
+ <img id="img7" src="" style="transform: translate(-25px, 25px) rotate(270deg) scaleY(-1);">
+ </div>
+ <br>Rotated 90° CW and flipped vertically
+ </div>
+ <div class="container">
+ <div class="vertical">
+ <img id="img8" src="" style="transform: translate(-25px, 25px) rotate(270deg);">
+ </div>
+ <br>Rotated 90° CW
+ </div>
+ <br>
+ <div class="container">
+ <div class="horizontal">
+ <img id="img9" src=""
+ </div>
+ <br>Undefined (invalid value)
+ </div>
+ <br>
+ <ul id="console"></ul>
+ <script>
+ function log(str) {
+ var li = document.createElement("li");
+ li.appendChild(document.createTextNode(str));
+ var console = document.getElementById("console");
+ console.appendChild(li);
+ }
+
+ function imageSize(index) {
+ var element = document.getElementById("img" + index);
+ var computedStyle = window.getComputedStyle(element);
+ if (element.parentElement.classList.contains("vertical"))
+ return computedStyle.height + " by " + computedStyle.width;
+ return computedStyle.width + " by " + computedStyle.height;
+ }
+
+ window.addEventListener('load', (event) => {
+ for(var i = 1; i <= 9; i++)
+ log("img" + i + " size = " + imageSize(i));
+ });
+ </script>
+</body>
Added: trunk/LayoutTests/fast/images/image-orientation-dynamic-from-image.html (0 => 254187)
--- trunk/LayoutTests/fast/images/image-orientation-dynamic-from-image.html (rev 0)
+++ trunk/LayoutTests/fast/images/image-orientation-dynamic-from-image.html 2020-01-08 06:40:29 UTC (rev 254187)
@@ -0,0 +1,105 @@
+<!DOCTYPE html>
+<style>
+ div.container {
+ display: inline-block;
+ margin-right: 20px;
+ margin-bottom: 10px;
+ width: 100px;
+ vertical-align: top;
+ }
+ div.horizontal {
+ width: 102px;
+ height: 52px;
+ }
+ div.vertical {
+ width: 52px;
+ height: 102px;
+ }
+ img {
+ border: 1px solid black;
+ image-orientation: none;
+ }
+</style>
+<body>
+ <b>The images of the <img> elements should respect their EXIF orientation after setting their style image-orientation to "from-image".</b>
+ <br>
+ <br>
+ <div class="container">
+ <div class="horizontal">
+ <img id="img1" src=""
+ </div>
+ <br>Normal
+ </div>
+ <div class="container">
+ <div class="horizontal">
+ <img id="img2" src=""
+ </div>
+ <br>Flipped horizontally
+ </div>
+ <div class="container">
+ <div class="horizontal">
+ <img id="img3" src=""
+ </div>
+ <br>Rotated 180°
+ </div>
+ <div class="container">
+ <div class="horizontal">
+ <img id="img4" src=""
+ </div>
+ <br>Flipped vertically
+ </div>
+ <br>
+ <div class="container">
+ <div class="vertical">
+ <img id="img5" src=""
+ </div>
+ <br>Rotated 90° CCW and flipped vertically
+ </div>
+ <div class="container">
+ <div class="vertical">
+ <img id="img6" src=""
+ </div>
+ <br>Rotated 90° CCW
+ </div>
+ <div class="container">
+ <div class="vertical">
+ <img id="img7" src=""
+ </div>
+ <br>Rotated 90° CW and flipped vertically
+ </div>
+ <div class="container">
+ <div class="vertical">
+ <img id="img8" src=""
+ </div>
+ <br>Rotated 90° CW
+ </div>
+ <br>
+ <div class="container">
+ <div class="horizontal">
+ <img id="img9" src=""
+ </div>
+ <br>Undefined (invalid value)
+ </div>
+ <br>
+ <ul id="console"></ul>
+ <script>
+ function log(str) {
+ var li = document.createElement("li");
+ li.appendChild(document.createTextNode(str));
+ var console = document.getElementById("console");
+ console.appendChild(li);
+ }
+
+ function imageSize(el) {
+ var computedStyle = window.getComputedStyle(el);
+ return computedStyle.width + " by " + computedStyle.height;
+ }
+
+ window.addEventListener('load', (event) => {
+ for(var i = 1; i <= 9; i++)
+ document.getElementById("img" + i).style.imageOrientation = "from-image";
+ for(var i = 1; i <= 9; i++)
+ log("img" + i + " size = " + imageSize(document.getElementById("img" + i)));
+ });
+ </script>
+</body>
Added: trunk/LayoutTests/fast/images/image-orientation-dynamic-none-expected.html (0 => 254187)
--- trunk/LayoutTests/fast/images/image-orientation-dynamic-none-expected.html (rev 0)
+++ trunk/LayoutTests/fast/images/image-orientation-dynamic-none-expected.html 2020-01-08 06:40:29 UTC (rev 254187)
@@ -0,0 +1,102 @@
+<!DOCTYPE html>
+<style>
+ div.container {
+ display: inline-block;
+ margin-right: 20px;
+ margin-bottom: 10px;
+ width: 100px;
+ vertical-align: top;
+ }
+ div.horizontal {
+ width: 102px;
+ height: 52px;
+ }
+ div.vertical {
+ width: 52px;
+ height: 102px;
+ }
+ img {
+ border: 1px solid black;
+ }
+</style>
+<body>
+ <b>The images of the <img> elements should ignore their EXIF orientation after setting their style image-orientation to "none".</b>
+ <br>
+ <br>
+ <div class="container">
+ <div class="horizontal">
+ <img id="img1" src=""
+ </div>
+ <br>Normal
+ </div>
+ <div class="container">
+ <div class="horizontal">
+ <img id="img2" src=""
+ </div>
+ <br>Flipped horizontally
+ </div>
+ <div class="container">
+ <div class="horizontal">
+ <img id="img3" src=""
+ </div>
+ <br>Rotated 180°
+ </div>
+ <div class="container">
+ <div class="horizontal">
+ <img id="img4" src=""
+ </div>
+ <br>Flipped vertically
+ </div>
+ <br>
+ <div class="container">
+ <div class="vertical">
+ <img id="img5" src=""
+ </div>
+ <br>Rotated 90° CCW and flipped vertically
+ </div>
+ <div class="container">
+ <div class="vertical">
+ <img id="img6" src=""
+ </div>
+ <br>Rotated 90° CCW
+ </div>
+ <div class="container">
+ <div class="vertical">
+ <img id="img7" src=""
+ </div>
+ <br>Rotated 90° CW and flipped vertically
+ </div>
+ <div class="container">
+ <div class="vertical">
+ <img id="img8" src=""
+ </div>
+ <br>Rotated 90° CW
+ </div>
+ <br>
+ <div class="container">
+ <div class="horizontal">
+ <img id="img9" src=""
+ </div>
+ <br>Undefined (invalid value)
+ </div>
+ <br>
+ <ul id="console"></ul>
+ <script>
+ function log(str) {
+ var li = document.createElement("li");
+ li.appendChild(document.createTextNode(str));
+ var console = document.getElementById("console");
+ console.appendChild(li);
+ }
+
+ function imageSize(el) {
+ var computedStyle = window.getComputedStyle(el);
+ return computedStyle.width + " by " + computedStyle.height;
+ }
+
+ window.addEventListener('load', (event) => {
+ for(var i = 1; i <= 9; i++)
+ log("img" + i + " size = " + imageSize(document.getElementById("img" + i)));
+ });
+ </script>
+</body>
Added: trunk/LayoutTests/fast/images/image-orientation-dynamic-none.html (0 => 254187)
--- trunk/LayoutTests/fast/images/image-orientation-dynamic-none.html (rev 0)
+++ trunk/LayoutTests/fast/images/image-orientation-dynamic-none.html 2020-01-08 06:40:29 UTC (rev 254187)
@@ -0,0 +1,105 @@
+<!DOCTYPE html>
+<style>
+ div.container {
+ display: inline-block;
+ margin-right: 20px;
+ margin-bottom: 10px;
+ width: 100px;
+ vertical-align: top;
+ }
+ div.horizontal {
+ width: 102px;
+ height: 52px;
+ }
+ div.vertical {
+ width: 52px;
+ height: 102px;
+ }
+ img {
+ border: 1px solid black;
+ image-orientation: from-image;
+ }
+</style>
+<body>
+ <b>The images of the <img> elements should ignore their EXIF orientation after setting their style image-orientation to "none".</b>
+ <br>
+ <br>
+ <div class="container">
+ <div class="horizontal">
+ <img id="img1" src=""
+ </div>
+ <br>Normal
+ </div>
+ <div class="container">
+ <div class="horizontal">
+ <img id="img2" src=""
+ </div>
+ <br>Flipped horizontally
+ </div>
+ <div class="container">
+ <div class="horizontal">
+ <img id="img3" src=""
+ </div>
+ <br>Rotated 180°
+ </div>
+ <div class="container">
+ <div class="horizontal">
+ <img id="img4" src=""
+ </div>
+ <br>Flipped vertically
+ </div>
+ <br>
+ <div class="container">
+ <div class="vertical">
+ <img id="img5" src=""
+ </div>
+ <br>Rotated 90° CCW and flipped vertically
+ </div>
+ <div class="container">
+ <div class="vertical">
+ <img id="img6" src=""
+ </div>
+ <br>Rotated 90° CCW
+ </div>
+ <div class="container">
+ <div class="vertical">
+ <img id="img7" src=""
+ </div>
+ <br>Rotated 90° CW and flipped vertically
+ </div>
+ <div class="container">
+ <div class="vertical">
+ <img id="img8" src=""
+ </div>
+ <br>Rotated 90° CW
+ </div>
+ <br>
+ <div class="container">
+ <div class="horizontal">
+ <img id="img9" src=""
+ </div>
+ <br>Undefined (invalid value)
+ </div>
+ <br>
+ <ul id="console"></ul>
+ <script>
+ function log(str) {
+ var li = document.createElement("li");
+ li.appendChild(document.createTextNode(str));
+ var console = document.getElementById("console");
+ console.appendChild(li);
+ }
+
+ function imageSize(el) {
+ var computedStyle = window.getComputedStyle(el);
+ return computedStyle.width + " by " + computedStyle.height;
+ }
+
+ window.addEventListener('load', (event) => {
+ for(var i = 1; i <= 9; i++)
+ document.getElementById("img" + i).style.imageOrientation = "none";
+ for(var i = 1; i <= 9; i++)
+ log("img" + i + " size = " + imageSize(document.getElementById("img" + i)));
+ });
+ </script>
+</body>
Added: trunk/LayoutTests/fast/images/image-orientation-none-expected.html (0 => 254187)
--- trunk/LayoutTests/fast/images/image-orientation-none-expected.html (rev 0)
+++ trunk/LayoutTests/fast/images/image-orientation-none-expected.html 2020-01-08 06:40:29 UTC (rev 254187)
@@ -0,0 +1,102 @@
+<!DOCTYPE html>
+<style>
+ div.container {
+ display: inline-block;
+ margin-right: 20px;
+ margin-bottom: 10px;
+ width: 100px;
+ vertical-align: top;
+ }
+ div.horizontal {
+ width: 102px;
+ height: 52px;
+ }
+ div.vertical {
+ width: 52px;
+ height: 102px;
+ }
+ img {
+ border: 1px solid black;
+ }
+</style>
+<body>
+ <b>The images of the <img> elements should ignore their EXIF orientation.</b>
+ <br>
+ <br>
+ <div class="container">
+ <div class="horizontal">
+ <img id="img1" src=""
+ </div>
+ <br>Normal
+ </div>
+ <div class="container">
+ <div class="horizontal">
+ <img id="img2" src=""
+ </div>
+ <br>Flipped horizontally
+ </div>
+ <div class="container">
+ <div class="horizontal">
+ <img id="img3" src=""
+ </div>
+ <br>Rotated 180°
+ </div>
+ <div class="container">
+ <div class="horizontal">
+ <img id="img4" src=""
+ </div>
+ <br>Flipped vertically
+ </div>
+ <br>
+ <div class="container">
+ <div class="vertical">
+ <img id="img5" src=""
+ </div>
+ <br>Rotated 90° CCW and flipped vertically
+ </div>
+ <div class="container">
+ <div class="vertical">
+ <img id="img6" src=""
+ </div>
+ <br>Rotated 90° CCW
+ </div>
+ <div class="container">
+ <div class="vertical">
+ <img id="img7" src=""
+ </div>
+ <br>Rotated 90° CW and flipped vertically
+ </div>
+ <div class="container">
+ <div class="vertical">
+ <img id="img8" src=""
+ </div>
+ <br>Rotated 90° CW
+ </div>
+ <br>
+ <div class="container">
+ <div class="horizontal">
+ <img id="img9" src=""
+ </div>
+ <br>Undefined (invalid value)
+ </div>
+ <br>
+ <ul id="console"></ul>
+ <script>
+ function log(str) {
+ var li = document.createElement("li");
+ li.appendChild(document.createTextNode(str));
+ var console = document.getElementById("console");
+ console.appendChild(li);
+ }
+
+ function imageSize(el) {
+ var computedStyle = window.getComputedStyle(el);
+ return computedStyle.width + " by " + computedStyle.height;
+ }
+
+ window.addEventListener('load', (event) => {
+ for(var i = 1; i <= 9; i++)
+ log("img" + i + " size = " + imageSize(document.getElementById("img" + i)));
+ });
+ </script>
+</body>
Added: trunk/LayoutTests/fast/images/image-orientation-none.html (0 => 254187)
--- trunk/LayoutTests/fast/images/image-orientation-none.html (rev 0)
+++ trunk/LayoutTests/fast/images/image-orientation-none.html 2020-01-08 06:40:29 UTC (rev 254187)
@@ -0,0 +1,103 @@
+<!DOCTYPE html>
+<style>
+ div.container {
+ display: inline-block;
+ margin-right: 20px;
+ margin-bottom: 10px;
+ width: 100px;
+ vertical-align: top;
+ }
+ div.horizontal {
+ width: 102px;
+ height: 52px;
+ }
+ div.vertical {
+ width: 52px;
+ height: 102px;
+ }
+ img {
+ border: 1px solid black;
+ image-orientation: none;
+ }
+</style>
+<body>
+ <b>The images of the <img> elements should ignore their EXIF orientation.</b>
+ <br>
+ <br>
+ <div class="container">
+ <div class="horizontal">
+ <img id="img1" src=""
+ </div>
+ <br>Normal
+ </div>
+ <div class="container">
+ <div class="horizontal">
+ <img id="img2" src=""
+ </div>
+ <br>Flipped horizontally
+ </div>
+ <div class="container">
+ <div class="horizontal">
+ <img id="img3" src=""
+ </div>
+ <br>Rotated 180°
+ </div>
+ <div class="container">
+ <div class="horizontal">
+ <img id="img4" src=""
+ </div>
+ <br>Flipped vertically
+ </div>
+ <br>
+ <div class="container">
+ <div class="vertical">
+ <img id="img5" src=""
+ </div>
+ <br>Rotated 90° CCW and flipped vertically
+ </div>
+ <div class="container">
+ <div class="vertical">
+ <img id="img6" src=""
+ </div>
+ <br>Rotated 90° CCW
+ </div>
+ <div class="container">
+ <div class="vertical">
+ <img id="img7" src=""
+ </div>
+ <br>Rotated 90° CW and flipped vertically
+ </div>
+ <div class="container">
+ <div class="vertical">
+ <img id="img8" src=""
+ </div>
+ <br>Rotated 90° CW
+ </div>
+ <br>
+ <div class="container">
+ <div class="horizontal">
+ <img id="img9" src=""
+ </div>
+ <br>Undefined (invalid value)
+ </div>
+ <br>
+ <ul id="console"></ul>
+ <script>
+ function log(str) {
+ var li = document.createElement("li");
+ li.appendChild(document.createTextNode(str));
+ var console = document.getElementById("console");
+ console.appendChild(li);
+ }
+
+ function imageSize(el) {
+ var computedStyle = window.getComputedStyle(el);
+ return computedStyle.width + " by " + computedStyle.height;
+ }
+
+ window.addEventListener('load', (event) => {
+ for(var i = 1; i <= 9; i++)
+ log("img" + i + " size = " + imageSize(document.getElementById("img" + i)));
+ });
+ </script>
+</body>
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (254186 => 254187)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2020-01-08 05:02:02 UTC (rev 254186)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2020-01-08 06:40:29 UTC (rev 254187)
@@ -1,3 +1,17 @@
+2020-01-07 Said Abou-Hallawa <sabouhall...@apple.com>
+
+ Implement css3-images image-orientation
+ https://bugs.webkit.org/show_bug.cgi?id=89052
+
+ Reviewed by Simon Fraser.
+
+ * web-platform-tests/css/css-images/inheritance-expected.txt:
+ * web-platform-tests/css/css-images/inheritance.html:
+ This test is re-synced from upstream
+
+ * web-platform-tests/css/css-images/parsing/image-orientation-computed-expected.txt:
+ * web-platform-tests/css/css-images/parsing/image-orientation-valid-expected.txt:
+
2020-01-07 Chris Dumez <cdu...@apple.com>
Remove document.origin
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-images/inheritance-expected.txt (254186 => 254187)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-images/inheritance-expected.txt 2020-01-08 05:02:02 UTC (rev 254186)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-images/inheritance-expected.txt 2020-01-08 06:40:29 UTC (rev 254187)
@@ -1,6 +1,6 @@
-FAIL Property image-orientation has initial value 0deg assert_true: image-orientation doesn't seem to be supported in the computed style expected true got false
-FAIL Property image-orientation inherits assert_true: image-orientation doesn't seem to be supported in the computed style expected true got false
+PASS Property image-orientation has initial value from-image
+PASS Property image-orientation inherits
PASS Property image-rendering has initial value auto
PASS Property image-rendering inherits
PASS Property object-fit has initial value fill
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-images/inheritance.html (254186 => 254187)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-images/inheritance.html 2020-01-08 05:02:02 UTC (rev 254186)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-images/inheritance.html 2020-01-08 06:40:29 UTC (rev 254187)
@@ -15,7 +15,7 @@
<div id="target"></div>
</div>
<script>
-assert_inherited('image-orientation', '0deg', 'from-image'); // none is 0deg
+assert_inherited('image-orientation', 'from-image', 'none');
assert_inherited('image-rendering', 'auto', 'pixelated');
assert_not_inherited('object-fit', 'fill', 'contain');
assert_not_inherited('object-position', '50% 50%', '10px 20px');
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-images/parsing/image-orientation-computed-expected.txt (254186 => 254187)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-images/parsing/image-orientation-computed-expected.txt 2020-01-08 05:02:02 UTC (rev 254186)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-images/parsing/image-orientation-computed-expected.txt 2020-01-08 06:40:29 UTC (rev 254187)
@@ -1,4 +1,4 @@
-FAIL Property image-orientation value 'from-image' computes to 'from-image' assert_true: image-orientation doesn't seem to be supported in the computed style expected true got false
-FAIL Property image-orientation value 'none' computes to 'none' assert_true: image-orientation doesn't seem to be supported in the computed style expected true got false
+PASS Property image-orientation value 'from-image' computes to 'from-image'
+PASS Property image-orientation value 'none' computes to 'none'
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-images/parsing/image-orientation-valid-expected.txt (254186 => 254187)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-images/parsing/image-orientation-valid-expected.txt 2020-01-08 05:02:02 UTC (rev 254186)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-images/parsing/image-orientation-valid-expected.txt 2020-01-08 06:40:29 UTC (rev 254187)
@@ -1,4 +1,4 @@
-FAIL e.style['image-orientation'] = "from-image" should set the property value assert_not_equals: property should be set got disallowed value ""
-FAIL e.style['image-orientation'] = "none" should set the property value assert_not_equals: property should be set got disallowed value ""
+PASS e.style['image-orientation'] = "from-image" should set the property value
+PASS e.style['image-orientation'] = "none" should set the property value
Modified: trunk/Source/_javascript_Core/ChangeLog (254186 => 254187)
--- trunk/Source/_javascript_Core/ChangeLog 2020-01-08 05:02:02 UTC (rev 254186)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-01-08 06:40:29 UTC (rev 254187)
@@ -1,3 +1,14 @@
+2020-01-07 Said Abou-Hallawa <sabouhall...@apple.com>
+
+ Implement css3-images image-orientation
+ https://bugs.webkit.org/show_bug.cgi?id=89052
+
+ Reviewed by Simon Fraser.
+
+ Remove the ENABLE_CSS_IMAGE_ORIENTATION feature flag.
+
+ * Configurations/FeatureDefines.xcconfig:
+
2020-01-07 Ross Kirsling <ross.kirsl...@sony.com>
Unreviewed restabilization of non-unified build.
Modified: trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig (254186 => 254187)
--- trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig 2020-01-08 05:02:02 UTC (rev 254186)
+++ trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig 2020-01-08 06:40:29 UTC (rev 254187)
@@ -99,8 +99,6 @@
ENABLE_CSS_DEVICE_ADAPTATION = ;
-ENABLE_CSS_IMAGE_ORIENTATION = ;
-
ENABLE_CSS_IMAGE_RESOLUTION = ;
ENABLE_CSS_PAINTING_API = ENABLE_CSS_PAINTING_API;
@@ -444,4 +442,4 @@
ENABLE_XSLT = ENABLE_XSLT;
-FEATURE_DEFINES = $(ENABLE_3D_TRANSFORMS) $(ENABLE_ACCELERATED_2D_CANVAS) $(ENABLE_ACCESSIBILITY_ISOLATED_TREE) $(ENABLE_APPLE_PAY) $(ENABLE_APPLE_PAY_SESSION_V3) $(ENABLE_APPLE_PAY_SESSION_V4) $(ENABLE_APPLICATION_MANIFEST) $(ENABLE_ATTACHMENT_ELEMENT) $(ENABLE_AVF_CAPTIONS) $(ENABLE_CACHE_PARTITIONING) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CONTENT_FILTERING) $(ENABLE_CSS3_TEXT) $(ENABLE_CSS_BOX_DECORATION_BREAK) $(ENABLE_CSS_COMPOSITING) $(ENABLE_CSS_CONIC_GRADIENTS) $(ENABLE_CSS_DEVICE_ADAPTATION) $(ENABLE_CSS_IMAGE_ORIENTATION) $(ENABLE_CSS_IMAGE_RESOLUTION) $(ENABLE_CSS_PAINTING_API) $(ENABLE_CSS_SCROLL_SNAP) $(ENABLE_CSS_SELECTORS_LEVEL4) $(ENABLE_CSS_TRAILING_WORD) $(ENABLE_CSS_TYPED_OM) $(ENABLE_CURSOR_VISIBILITY) $(ENABLE_CUSTOM_SCHEME_HANDLER) $(ENABLE_C_LOOP) $(ENABLE_DARK_MODE_CSS) $(ENABLE_DATACUE_VALUE) $(ENABLE_DATALIST_ELEMENT) $(ENABLE_DATA_INTERACTION) $(ENABLE_DEVICE_ORIENTATION) $(ENABLE_DRAG_SUPPORT) $(ENABLE_ENCRYPTED_MEDIA) $(ENABLE_EXPERIMENTAL_FEA
TURES) $(ENABLE_FAST_JIT_PERMISSIONS) $(ENABLE_FILTERS_LEVEL_2) $(ENABLE_FTL_JIT) $(ENABLE_FULLSCREEN_API) $(ENABLE_PICTURE_IN_PICTURE_API) $(ENABLE_GAMEPAD) $(ENABLE_GEOLOCATION) $(ENABLE_GPU_PROCESS) $(ENABLE_INDEXED_DATABASE) $(ENABLE_INDEXED_DATABASE_IN_WORKERS) $(ENABLE_INPUT_TYPE_COLOR) $(ENABLE_INPUT_TYPE_DATE) $(ENABLE_INPUT_TYPE_DATETIMELOCAL) $(ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE) $(ENABLE_INPUT_TYPE_MONTH) $(ENABLE_INPUT_TYPE_TIME) $(ENABLE_INPUT_TYPE_WEEK) $(ENABLE_INSPECTOR_ALTERNATE_DISPATCHERS) $(ENABLE_INSPECTOR_TELEMETRY) $(ENABLE_INTERSECTION_OBSERVER) $(ENABLE_INTL) $(ENABLE_IOS_GESTURE_EVENTS) $(ENABLE_IOS_TOUCH_EVENTS) $(ENABLE_JIT) $(ENABLE_LAYOUT_FORMATTING_CONTEXT) $(ENABLE_LEGACY_CSS_VENDOR_PREFIXES) $(ENABLE_LEGACY_CUSTOM_PROTOCOL_MANAGER) $(ENABLE_LEGACY_ENCRYPTED_MEDIA) $(ENABLE_LETTERPRESS) $(ENABLE_MAC_GESTURE_EVENTS) $(ENABLE_MAC_VIDEO_TOOLBOX) $(ENABLE_MATHML) $(ENABLE_MEDIA_CAPTURE) $(ENABLE_MEDIA_CONTROLS_SCRIPT) $(ENABLE_MEDIA_SESSION) $(ENABLE_M
EDIA_SOURCE) $(ENABLE_MEDIA_STATISTICS) $(ENABLE_MEDIA_STREAM) $(ENABLE_MEMORY_SAMPLER) $(ENABLE_METER_ELEMENT) $(ENABLE_MHTML) $(ENABLE_MOUSE_CURSOR_SCALE) $(ENABLE_NAVIGATOR_STANDALONE) $(ENABLE_NETWORK_CACHE_SPECULATIVE_REVALIDATION) $(ENABLE_NOTIFICATIONS) $(ENABLE_OFFSCREEN_CANVAS) $(ENABLE_OVERFLOW_SCROLLING_TOUCH) $(ENABLE_PAYMENT_REQUEST) $(ENABLE_PDFKIT_PLUGIN) $(ENABLE_POINTER_EVENTS) $(ENABLE_POINTER_LOCK) $(ENABLE_PUBLIC_SUFFIX_LIST) $(ENABLE_QUOTA) $(ENABLE_REMOTE_INSPECTOR) $(ENABLE_RESIZE_OBSERVER) $(ENABLE_RESOLUTION_MEDIA_QUERY) $(ENABLE_RESOURCE_LOAD_STATISTICS) $(ENABLE_RESOURCE_USAGE) $(ENABLE_RUBBER_BANDING) $(ENABLE_SANDBOX_EXTENSIONS) $(ENABLE_SERVER_PRECONNECT) $(ENABLE_SERVICE_CONTROLS) $(ENABLE_SERVICE_WORKER) $(ENABLE_SHAREABLE_RESOURCE) $(ENABLE_SPEECH_SYNTHESIS) $(ENABLE_STREAMS_API) $(ENABLE_SVG_FONTS) $(ENABLE_TELEPHONE_NUMBER_DETECTION) $(ENABLE_TEXT_AUTOSIZING) $(ENABLE_TOUCH_EVENTS) $(ENABLE_USERSELECT_ALL) $(ENABLE_USER_MESSAGE_HANDLERS) $(ENABLE_V
ARIATION_FONTS) $(ENABLE_VIDEO) $(ENABLE_VIDEO_PRESENTATION_MODE) $(ENABLE_VIDEO_TRACK) $(ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN) $(ENABLE_WEBASSEMBLY) $(ENABLE_WEBASSEMBLY_STREAMING_API) $(ENABLE_WEBDRIVER_MOUSE_INTERACTIONS) $(ENABLE_WEBDRIVER_KEYBOARD_INTERACTIONS) $(ENABLE_WEBDRIVER_TOUCH_INTERACTIONS) $(ENABLE_WEBGL) $(ENABLE_WEBGL2) $(ENABLE_WEBGPU) $(ENABLE_WEB_API_STATISTICS) $(ENABLE_WEB_AUDIO) $(ENABLE_WEB_AUTHN) $(ENABLE_WEB_CRYPTO) $(ENABLE_WEB_RTC) $(ENABLE_WIRELESS_PLAYBACK_TARGET) $(ENABLE_XSLT);
+FEATURE_DEFINES = $(ENABLE_3D_TRANSFORMS) $(ENABLE_ACCELERATED_2D_CANVAS) $(ENABLE_ACCESSIBILITY_ISOLATED_TREE) $(ENABLE_APPLE_PAY) $(ENABLE_APPLE_PAY_SESSION_V3) $(ENABLE_APPLE_PAY_SESSION_V4) $(ENABLE_APPLICATION_MANIFEST) $(ENABLE_ATTACHMENT_ELEMENT) $(ENABLE_AVF_CAPTIONS) $(ENABLE_CACHE_PARTITIONING) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CONTENT_FILTERING) $(ENABLE_CSS3_TEXT) $(ENABLE_CSS_BOX_DECORATION_BREAK) $(ENABLE_CSS_COMPOSITING) $(ENABLE_CSS_CONIC_GRADIENTS) $(ENABLE_CSS_DEVICE_ADAPTATION) $(ENABLE_CSS_IMAGE_RESOLUTION) $(ENABLE_CSS_PAINTING_API) $(ENABLE_CSS_SCROLL_SNAP) $(ENABLE_CSS_SELECTORS_LEVEL4) $(ENABLE_CSS_TRAILING_WORD) $(ENABLE_CSS_TYPED_OM) $(ENABLE_CURSOR_VISIBILITY) $(ENABLE_CUSTOM_SCHEME_HANDLER) $(ENABLE_C_LOOP) $(ENABLE_DARK_MODE_CSS) $(ENABLE_DATACUE_VALUE) $(ENABLE_DATALIST_ELEMENT) $(ENABLE_DATA_INTERACTION) $(ENABLE_DEVICE_ORIENTATION) $(ENABLE_DRAG_SUPPORT) $(ENABLE_ENCRYPTED_MEDIA) $(ENABLE_EXPERIMENTAL_FEATURES) $(ENABLE_FAST_JIT_PERMISSI
ONS) $(ENABLE_FILTERS_LEVEL_2) $(ENABLE_FTL_JIT) $(ENABLE_FULLSCREEN_API) $(ENABLE_PICTURE_IN_PICTURE_API) $(ENABLE_GAMEPAD) $(ENABLE_GEOLOCATION) $(ENABLE_GPU_PROCESS) $(ENABLE_INDEXED_DATABASE) $(ENABLE_INDEXED_DATABASE_IN_WORKERS) $(ENABLE_INPUT_TYPE_COLOR) $(ENABLE_INPUT_TYPE_DATE) $(ENABLE_INPUT_TYPE_DATETIMELOCAL) $(ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE) $(ENABLE_INPUT_TYPE_MONTH) $(ENABLE_INPUT_TYPE_TIME) $(ENABLE_INPUT_TYPE_WEEK) $(ENABLE_INSPECTOR_ALTERNATE_DISPATCHERS) $(ENABLE_INSPECTOR_TELEMETRY) $(ENABLE_INTERSECTION_OBSERVER) $(ENABLE_INTL) $(ENABLE_IOS_GESTURE_EVENTS) $(ENABLE_IOS_TOUCH_EVENTS) $(ENABLE_JIT) $(ENABLE_LAYOUT_FORMATTING_CONTEXT) $(ENABLE_LEGACY_CSS_VENDOR_PREFIXES) $(ENABLE_LEGACY_CUSTOM_PROTOCOL_MANAGER) $(ENABLE_LEGACY_ENCRYPTED_MEDIA) $(ENABLE_LETTERPRESS) $(ENABLE_MAC_GESTURE_EVENTS) $(ENABLE_MAC_VIDEO_TOOLBOX) $(ENABLE_MATHML) $(ENABLE_MEDIA_CAPTURE) $(ENABLE_MEDIA_CONTROLS_SCRIPT) $(ENABLE_MEDIA_SESSION) $(ENABLE_MEDIA_SOURCE) $(ENABLE_MEDIA_STATI
STICS) $(ENABLE_MEDIA_STREAM) $(ENABLE_MEMORY_SAMPLER) $(ENABLE_METER_ELEMENT) $(ENABLE_MHTML) $(ENABLE_MOUSE_CURSOR_SCALE) $(ENABLE_NAVIGATOR_STANDALONE) $(ENABLE_NETWORK_CACHE_SPECULATIVE_REVALIDATION) $(ENABLE_NOTIFICATIONS) $(ENABLE_OFFSCREEN_CANVAS) $(ENABLE_OVERFLOW_SCROLLING_TOUCH) $(ENABLE_PAYMENT_REQUEST) $(ENABLE_PDFKIT_PLUGIN) $(ENABLE_POINTER_EVENTS) $(ENABLE_POINTER_LOCK) $(ENABLE_PUBLIC_SUFFIX_LIST) $(ENABLE_QUOTA) $(ENABLE_REMOTE_INSPECTOR) $(ENABLE_RESIZE_OBSERVER) $(ENABLE_RESOLUTION_MEDIA_QUERY) $(ENABLE_RESOURCE_LOAD_STATISTICS) $(ENABLE_RESOURCE_USAGE) $(ENABLE_RUBBER_BANDING) $(ENABLE_SANDBOX_EXTENSIONS) $(ENABLE_SERVER_PRECONNECT) $(ENABLE_SERVICE_CONTROLS) $(ENABLE_SERVICE_WORKER) $(ENABLE_SHAREABLE_RESOURCE) $(ENABLE_SPEECH_SYNTHESIS) $(ENABLE_STREAMS_API) $(ENABLE_SVG_FONTS) $(ENABLE_TELEPHONE_NUMBER_DETECTION) $(ENABLE_TEXT_AUTOSIZING) $(ENABLE_TOUCH_EVENTS) $(ENABLE_USERSELECT_ALL) $(ENABLE_USER_MESSAGE_HANDLERS) $(ENABLE_VARIATION_FONTS) $(ENABLE_VIDEO) $
(ENABLE_VIDEO_PRESENTATION_MODE) $(ENABLE_VIDEO_TRACK) $(ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN) $(ENABLE_WEBASSEMBLY) $(ENABLE_WEBASSEMBLY_STREAMING_API) $(ENABLE_WEBDRIVER_MOUSE_INTERACTIONS) $(ENABLE_WEBDRIVER_KEYBOARD_INTERACTIONS) $(ENABLE_WEBDRIVER_TOUCH_INTERACTIONS) $(ENABLE_WEBGL) $(ENABLE_WEBGL2) $(ENABLE_WEBGPU) $(ENABLE_WEB_API_STATISTICS) $(ENABLE_WEB_AUDIO) $(ENABLE_WEB_AUTHN) $(ENABLE_WEB_CRYPTO) $(ENABLE_WEB_RTC) $(ENABLE_WIRELESS_PLAYBACK_TARGET) $(ENABLE_XSLT);
Modified: trunk/Source/WTF/ChangeLog (254186 => 254187)
--- trunk/Source/WTF/ChangeLog 2020-01-08 05:02:02 UTC (rev 254186)
+++ trunk/Source/WTF/ChangeLog 2020-01-08 06:40:29 UTC (rev 254187)
@@ -1,3 +1,14 @@
+2020-01-07 Said Abou-Hallawa <sabouhall...@apple.com>
+
+ Implement css3-images image-orientation
+ https://bugs.webkit.org/show_bug.cgi?id=89052
+
+ Reviewed by Simon Fraser.
+
+ Remove the ENABLE_CSS_IMAGE_ORIENTATION feature flag.
+
+ * wtf/FeatureDefines.h:
+
2020-01-07 Simon Fraser <simon.fra...@apple.com>
Add some more Animations logging
Modified: trunk/Source/WTF/wtf/FeatureDefines.h (254186 => 254187)
--- trunk/Source/WTF/wtf/FeatureDefines.h 2020-01-08 05:02:02 UTC (rev 254186)
+++ trunk/Source/WTF/wtf/FeatureDefines.h 2020-01-08 06:40:29 UTC (rev 254187)
@@ -447,10 +447,6 @@
#define ENABLE_CSS_COMPOSITING 0
#endif
-#if !defined(ENABLE_CSS_IMAGE_ORIENTATION)
-#define ENABLE_CSS_IMAGE_ORIENTATION 0
-#endif
-
#if !defined(ENABLE_CSS_IMAGE_RESOLUTION)
#define ENABLE_CSS_IMAGE_RESOLUTION 0
#endif
Modified: trunk/Source/WebCore/ChangeLog (254186 => 254187)
--- trunk/Source/WebCore/ChangeLog 2020-01-08 05:02:02 UTC (rev 254186)
+++ trunk/Source/WebCore/ChangeLog 2020-01-08 06:40:29 UTC (rev 254187)
@@ -1,3 +1,47 @@
+2020-01-07 Said Abou-Hallawa <sabouhall...@apple.com>
+
+ Implement css3-images image-orientation
+ https://bugs.webkit.org/show_bug.cgi?id=89052
+
+ Reviewed by Simon Fraser.
+
+ Implement the CSS image-orientation property for content images. The valid
+ values are "from-image" or "none". The default value is "from-image".
+
+ Specification: https://drafts.csswg.org/css-images-3/#the-image-orientation
+ GitHub issue: https://github.com/w3c/csswg-drafts/issues/4164
+
+ Tests: fast/images/image-orientation-dynamic-from-image.html
+ fast/images/image-orientation-dynamic-none.html
+ fast/images/image-orientation-none.html
+
+ * Configurations/FeatureDefines.xcconfig:
+ * css/CSSComputedStyleDeclaration.cpp:
+ (WebCore::ComputedStyleExtractor::valueForPropertyInStyle):
+ * css/CSSPrimitiveValueMappings.h:
+ (WebCore::CSSPrimitiveValue::operator ImageOrientation const): Deleted.
+ * css/CSSProperties.json:
+ * css/CSSValueKeywords.in:
+ * css/parser/CSSPropertyParser.cpp:
+ (WebCore::consumeImageOrientation):
+ (WebCore::CSSPropertyParser::parseSingleValue):
+ * rendering/RenderElement.cpp:
+ (WebCore::RenderElement::imageOrientation const):
+ * rendering/RenderImage.cpp:
+ (WebCore::RenderImage::styleDidChange):
+ * rendering/style/RenderStyle.cpp:
+ (WebCore::rareInheritedDataChangeRequiresLayout):
+ * rendering/style/RenderStyle.h:
+ (WebCore::RenderStyle::setImageOrientation):
+ (WebCore::RenderStyle::initialImageOrientation):
+ (WebCore::RenderStyle::imageOrientation const):
+ * rendering/style/StyleRareInheritedData.cpp:
+ (WebCore::StyleRareInheritedData::StyleRareInheritedData):
+ (WebCore::StyleRareInheritedData::operator== const):
+ * rendering/style/StyleRareInheritedData.h:
+ * style/StyleBuilderConverter.h:
+ (WebCore::Style::BuilderConverter::convertImageOrientation):
+
2020-01-07 Devin Rousso <drou...@apple.com>
Web Inspector: unable to edit or view the source of style sheets injected by safari app extensions
Modified: trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig (254186 => 254187)
--- trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig 2020-01-08 05:02:02 UTC (rev 254186)
+++ trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig 2020-01-08 06:40:29 UTC (rev 254187)
@@ -99,8 +99,6 @@
ENABLE_CSS_DEVICE_ADAPTATION = ;
-ENABLE_CSS_IMAGE_ORIENTATION = ;
-
ENABLE_CSS_IMAGE_RESOLUTION = ;
ENABLE_CSS_PAINTING_API = ENABLE_CSS_PAINTING_API;
@@ -444,4 +442,4 @@
ENABLE_XSLT = ENABLE_XSLT;
-FEATURE_DEFINES = $(ENABLE_3D_TRANSFORMS) $(ENABLE_ACCELERATED_2D_CANVAS) $(ENABLE_ACCESSIBILITY_ISOLATED_TREE) $(ENABLE_APPLE_PAY) $(ENABLE_APPLE_PAY_SESSION_V3) $(ENABLE_APPLE_PAY_SESSION_V4) $(ENABLE_APPLICATION_MANIFEST) $(ENABLE_ATTACHMENT_ELEMENT) $(ENABLE_AVF_CAPTIONS) $(ENABLE_CACHE_PARTITIONING) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CONTENT_FILTERING) $(ENABLE_CSS3_TEXT) $(ENABLE_CSS_BOX_DECORATION_BREAK) $(ENABLE_CSS_COMPOSITING) $(ENABLE_CSS_CONIC_GRADIENTS) $(ENABLE_CSS_DEVICE_ADAPTATION) $(ENABLE_CSS_IMAGE_ORIENTATION) $(ENABLE_CSS_IMAGE_RESOLUTION) $(ENABLE_CSS_PAINTING_API) $(ENABLE_CSS_SCROLL_SNAP) $(ENABLE_CSS_SELECTORS_LEVEL4) $(ENABLE_CSS_TRAILING_WORD) $(ENABLE_CSS_TYPED_OM) $(ENABLE_CURSOR_VISIBILITY) $(ENABLE_CUSTOM_SCHEME_HANDLER) $(ENABLE_C_LOOP) $(ENABLE_DARK_MODE_CSS) $(ENABLE_DATACUE_VALUE) $(ENABLE_DATALIST_ELEMENT) $(ENABLE_DATA_INTERACTION) $(ENABLE_DEVICE_ORIENTATION) $(ENABLE_DRAG_SUPPORT) $(ENABLE_ENCRYPTED_MEDIA) $(ENABLE_EXPERIMENTAL_FEA
TURES) $(ENABLE_FAST_JIT_PERMISSIONS) $(ENABLE_FILTERS_LEVEL_2) $(ENABLE_FTL_JIT) $(ENABLE_FULLSCREEN_API) $(ENABLE_PICTURE_IN_PICTURE_API) $(ENABLE_GAMEPAD) $(ENABLE_GEOLOCATION) $(ENABLE_GPU_PROCESS) $(ENABLE_INDEXED_DATABASE) $(ENABLE_INDEXED_DATABASE_IN_WORKERS) $(ENABLE_INPUT_TYPE_COLOR) $(ENABLE_INPUT_TYPE_DATE) $(ENABLE_INPUT_TYPE_DATETIMELOCAL) $(ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE) $(ENABLE_INPUT_TYPE_MONTH) $(ENABLE_INPUT_TYPE_TIME) $(ENABLE_INPUT_TYPE_WEEK) $(ENABLE_INSPECTOR_ALTERNATE_DISPATCHERS) $(ENABLE_INSPECTOR_TELEMETRY) $(ENABLE_INTERSECTION_OBSERVER) $(ENABLE_INTL) $(ENABLE_IOS_GESTURE_EVENTS) $(ENABLE_IOS_TOUCH_EVENTS) $(ENABLE_JIT) $(ENABLE_LAYOUT_FORMATTING_CONTEXT) $(ENABLE_LEGACY_CSS_VENDOR_PREFIXES) $(ENABLE_LEGACY_CUSTOM_PROTOCOL_MANAGER) $(ENABLE_LEGACY_ENCRYPTED_MEDIA) $(ENABLE_LETTERPRESS) $(ENABLE_MAC_GESTURE_EVENTS) $(ENABLE_MAC_VIDEO_TOOLBOX) $(ENABLE_MATHML) $(ENABLE_MEDIA_CAPTURE) $(ENABLE_MEDIA_CONTROLS_SCRIPT) $(ENABLE_MEDIA_SESSION) $(ENABLE_M
EDIA_SOURCE) $(ENABLE_MEDIA_STATISTICS) $(ENABLE_MEDIA_STREAM) $(ENABLE_MEMORY_SAMPLER) $(ENABLE_METER_ELEMENT) $(ENABLE_MHTML) $(ENABLE_MOUSE_CURSOR_SCALE) $(ENABLE_NAVIGATOR_STANDALONE) $(ENABLE_NETWORK_CACHE_SPECULATIVE_REVALIDATION) $(ENABLE_NOTIFICATIONS) $(ENABLE_OFFSCREEN_CANVAS) $(ENABLE_OVERFLOW_SCROLLING_TOUCH) $(ENABLE_PAYMENT_REQUEST) $(ENABLE_PDFKIT_PLUGIN) $(ENABLE_POINTER_EVENTS) $(ENABLE_POINTER_LOCK) $(ENABLE_PUBLIC_SUFFIX_LIST) $(ENABLE_QUOTA) $(ENABLE_REMOTE_INSPECTOR) $(ENABLE_RESIZE_OBSERVER) $(ENABLE_RESOLUTION_MEDIA_QUERY) $(ENABLE_RESOURCE_LOAD_STATISTICS) $(ENABLE_RESOURCE_USAGE) $(ENABLE_RUBBER_BANDING) $(ENABLE_SANDBOX_EXTENSIONS) $(ENABLE_SERVER_PRECONNECT) $(ENABLE_SERVICE_CONTROLS) $(ENABLE_SERVICE_WORKER) $(ENABLE_SHAREABLE_RESOURCE) $(ENABLE_SPEECH_SYNTHESIS) $(ENABLE_STREAMS_API) $(ENABLE_SVG_FONTS) $(ENABLE_TELEPHONE_NUMBER_DETECTION) $(ENABLE_TEXT_AUTOSIZING) $(ENABLE_TOUCH_EVENTS) $(ENABLE_USERSELECT_ALL) $(ENABLE_USER_MESSAGE_HANDLERS) $(ENABLE_V
ARIATION_FONTS) $(ENABLE_VIDEO) $(ENABLE_VIDEO_PRESENTATION_MODE) $(ENABLE_VIDEO_TRACK) $(ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN) $(ENABLE_WEBASSEMBLY) $(ENABLE_WEBASSEMBLY_STREAMING_API) $(ENABLE_WEBDRIVER_MOUSE_INTERACTIONS) $(ENABLE_WEBDRIVER_KEYBOARD_INTERACTIONS) $(ENABLE_WEBDRIVER_TOUCH_INTERACTIONS) $(ENABLE_WEBGL) $(ENABLE_WEBGL2) $(ENABLE_WEBGPU) $(ENABLE_WEB_API_STATISTICS) $(ENABLE_WEB_AUDIO) $(ENABLE_WEB_AUTHN) $(ENABLE_WEB_CRYPTO) $(ENABLE_WEB_RTC) $(ENABLE_WIRELESS_PLAYBACK_TARGET) $(ENABLE_XSLT);
+FEATURE_DEFINES = $(ENABLE_3D_TRANSFORMS) $(ENABLE_ACCELERATED_2D_CANVAS) $(ENABLE_ACCESSIBILITY_ISOLATED_TREE) $(ENABLE_APPLE_PAY) $(ENABLE_APPLE_PAY_SESSION_V3) $(ENABLE_APPLE_PAY_SESSION_V4) $(ENABLE_APPLICATION_MANIFEST) $(ENABLE_ATTACHMENT_ELEMENT) $(ENABLE_AVF_CAPTIONS) $(ENABLE_CACHE_PARTITIONING) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CONTENT_FILTERING) $(ENABLE_CSS3_TEXT) $(ENABLE_CSS_BOX_DECORATION_BREAK) $(ENABLE_CSS_COMPOSITING) $(ENABLE_CSS_CONIC_GRADIENTS) $(ENABLE_CSS_DEVICE_ADAPTATION) $(ENABLE_CSS_IMAGE_RESOLUTION) $(ENABLE_CSS_PAINTING_API) $(ENABLE_CSS_SCROLL_SNAP) $(ENABLE_CSS_SELECTORS_LEVEL4) $(ENABLE_CSS_TRAILING_WORD) $(ENABLE_CSS_TYPED_OM) $(ENABLE_CURSOR_VISIBILITY) $(ENABLE_CUSTOM_SCHEME_HANDLER) $(ENABLE_C_LOOP) $(ENABLE_DARK_MODE_CSS) $(ENABLE_DATACUE_VALUE) $(ENABLE_DATALIST_ELEMENT) $(ENABLE_DATA_INTERACTION) $(ENABLE_DEVICE_ORIENTATION) $(ENABLE_DRAG_SUPPORT) $(ENABLE_ENCRYPTED_MEDIA) $(ENABLE_EXPERIMENTAL_FEATURES) $(ENABLE_FAST_JIT_PERMISSI
ONS) $(ENABLE_FILTERS_LEVEL_2) $(ENABLE_FTL_JIT) $(ENABLE_FULLSCREEN_API) $(ENABLE_PICTURE_IN_PICTURE_API) $(ENABLE_GAMEPAD) $(ENABLE_GEOLOCATION) $(ENABLE_GPU_PROCESS) $(ENABLE_INDEXED_DATABASE) $(ENABLE_INDEXED_DATABASE_IN_WORKERS) $(ENABLE_INPUT_TYPE_COLOR) $(ENABLE_INPUT_TYPE_DATE) $(ENABLE_INPUT_TYPE_DATETIMELOCAL) $(ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE) $(ENABLE_INPUT_TYPE_MONTH) $(ENABLE_INPUT_TYPE_TIME) $(ENABLE_INPUT_TYPE_WEEK) $(ENABLE_INSPECTOR_ALTERNATE_DISPATCHERS) $(ENABLE_INSPECTOR_TELEMETRY) $(ENABLE_INTERSECTION_OBSERVER) $(ENABLE_INTL) $(ENABLE_IOS_GESTURE_EVENTS) $(ENABLE_IOS_TOUCH_EVENTS) $(ENABLE_JIT) $(ENABLE_LAYOUT_FORMATTING_CONTEXT) $(ENABLE_LEGACY_CSS_VENDOR_PREFIXES) $(ENABLE_LEGACY_CUSTOM_PROTOCOL_MANAGER) $(ENABLE_LEGACY_ENCRYPTED_MEDIA) $(ENABLE_LETTERPRESS) $(ENABLE_MAC_GESTURE_EVENTS) $(ENABLE_MAC_VIDEO_TOOLBOX) $(ENABLE_MATHML) $(ENABLE_MEDIA_CAPTURE) $(ENABLE_MEDIA_CONTROLS_SCRIPT) $(ENABLE_MEDIA_SESSION) $(ENABLE_MEDIA_SOURCE) $(ENABLE_MEDIA_STATI
STICS) $(ENABLE_MEDIA_STREAM) $(ENABLE_MEMORY_SAMPLER) $(ENABLE_METER_ELEMENT) $(ENABLE_MHTML) $(ENABLE_MOUSE_CURSOR_SCALE) $(ENABLE_NAVIGATOR_STANDALONE) $(ENABLE_NETWORK_CACHE_SPECULATIVE_REVALIDATION) $(ENABLE_NOTIFICATIONS) $(ENABLE_OFFSCREEN_CANVAS) $(ENABLE_OVERFLOW_SCROLLING_TOUCH) $(ENABLE_PAYMENT_REQUEST) $(ENABLE_PDFKIT_PLUGIN) $(ENABLE_POINTER_EVENTS) $(ENABLE_POINTER_LOCK) $(ENABLE_PUBLIC_SUFFIX_LIST) $(ENABLE_QUOTA) $(ENABLE_REMOTE_INSPECTOR) $(ENABLE_RESIZE_OBSERVER) $(ENABLE_RESOLUTION_MEDIA_QUERY) $(ENABLE_RESOURCE_LOAD_STATISTICS) $(ENABLE_RESOURCE_USAGE) $(ENABLE_RUBBER_BANDING) $(ENABLE_SANDBOX_EXTENSIONS) $(ENABLE_SERVER_PRECONNECT) $(ENABLE_SERVICE_CONTROLS) $(ENABLE_SERVICE_WORKER) $(ENABLE_SHAREABLE_RESOURCE) $(ENABLE_SPEECH_SYNTHESIS) $(ENABLE_STREAMS_API) $(ENABLE_SVG_FONTS) $(ENABLE_TELEPHONE_NUMBER_DETECTION) $(ENABLE_TEXT_AUTOSIZING) $(ENABLE_TOUCH_EVENTS) $(ENABLE_USERSELECT_ALL) $(ENABLE_USER_MESSAGE_HANDLERS) $(ENABLE_VARIATION_FONTS) $(ENABLE_VIDEO) $
(ENABLE_VIDEO_PRESENTATION_MODE) $(ENABLE_VIDEO_TRACK) $(ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN) $(ENABLE_WEBASSEMBLY) $(ENABLE_WEBASSEMBLY_STREAMING_API) $(ENABLE_WEBDRIVER_MOUSE_INTERACTIONS) $(ENABLE_WEBDRIVER_KEYBOARD_INTERACTIONS) $(ENABLE_WEBDRIVER_TOUCH_INTERACTIONS) $(ENABLE_WEBGL) $(ENABLE_WEBGL2) $(ENABLE_WEBGPU) $(ENABLE_WEB_API_STATISTICS) $(ENABLE_WEB_AUDIO) $(ENABLE_WEB_AUTHN) $(ENABLE_WEB_CRYPTO) $(ENABLE_WEB_RTC) $(ENABLE_WIRELESS_PLAYBACK_TARGET) $(ENABLE_XSLT);
Modified: trunk/Source/WebCore/PAL/ChangeLog (254186 => 254187)
--- trunk/Source/WebCore/PAL/ChangeLog 2020-01-08 05:02:02 UTC (rev 254186)
+++ trunk/Source/WebCore/PAL/ChangeLog 2020-01-08 06:40:29 UTC (rev 254187)
@@ -1,3 +1,14 @@
+2020-01-07 Said Abou-Hallawa <sabouhall...@apple.com>
+
+ Implement css3-images image-orientation
+ https://bugs.webkit.org/show_bug.cgi?id=89052
+
+ Reviewed by Simon Fraser.
+
+ Remove the ENABLE_CSS_IMAGE_ORIENTATION feature flag.
+
+ * Configurations/FeatureDefines.xcconfig:
+
2020-01-07 Jer Noble <jer.no...@apple.com>
Flaky API Test: TestWebKitAPI.WebKitLegacy.AudioSessionCategoryIOS
Modified: trunk/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig (254186 => 254187)
--- trunk/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig 2020-01-08 05:02:02 UTC (rev 254186)
+++ trunk/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig 2020-01-08 06:40:29 UTC (rev 254187)
@@ -99,8 +99,6 @@
ENABLE_CSS_DEVICE_ADAPTATION = ;
-ENABLE_CSS_IMAGE_ORIENTATION = ;
-
ENABLE_CSS_IMAGE_RESOLUTION = ;
ENABLE_CSS_PAINTING_API = ENABLE_CSS_PAINTING_API;
@@ -444,4 +442,4 @@
ENABLE_XSLT = ENABLE_XSLT;
-FEATURE_DEFINES = $(ENABLE_3D_TRANSFORMS) $(ENABLE_ACCELERATED_2D_CANVAS) $(ENABLE_ACCESSIBILITY_ISOLATED_TREE) $(ENABLE_APPLE_PAY) $(ENABLE_APPLE_PAY_SESSION_V3) $(ENABLE_APPLE_PAY_SESSION_V4) $(ENABLE_APPLICATION_MANIFEST) $(ENABLE_ATTACHMENT_ELEMENT) $(ENABLE_AVF_CAPTIONS) $(ENABLE_CACHE_PARTITIONING) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CONTENT_FILTERING) $(ENABLE_CSS3_TEXT) $(ENABLE_CSS_BOX_DECORATION_BREAK) $(ENABLE_CSS_COMPOSITING) $(ENABLE_CSS_CONIC_GRADIENTS) $(ENABLE_CSS_DEVICE_ADAPTATION) $(ENABLE_CSS_IMAGE_ORIENTATION) $(ENABLE_CSS_IMAGE_RESOLUTION) $(ENABLE_CSS_PAINTING_API) $(ENABLE_CSS_SCROLL_SNAP) $(ENABLE_CSS_SELECTORS_LEVEL4) $(ENABLE_CSS_TRAILING_WORD) $(ENABLE_CSS_TYPED_OM) $(ENABLE_CURSOR_VISIBILITY) $(ENABLE_CUSTOM_SCHEME_HANDLER) $(ENABLE_C_LOOP) $(ENABLE_DARK_MODE_CSS) $(ENABLE_DATACUE_VALUE) $(ENABLE_DATALIST_ELEMENT) $(ENABLE_DATA_INTERACTION) $(ENABLE_DEVICE_ORIENTATION) $(ENABLE_DRAG_SUPPORT) $(ENABLE_ENCRYPTED_MEDIA) $(ENABLE_EXPERIMENTAL_FEA
TURES) $(ENABLE_FAST_JIT_PERMISSIONS) $(ENABLE_FILTERS_LEVEL_2) $(ENABLE_FTL_JIT) $(ENABLE_FULLSCREEN_API) $(ENABLE_PICTURE_IN_PICTURE_API) $(ENABLE_GAMEPAD) $(ENABLE_GEOLOCATION) $(ENABLE_GPU_PROCESS) $(ENABLE_INDEXED_DATABASE) $(ENABLE_INDEXED_DATABASE_IN_WORKERS) $(ENABLE_INPUT_TYPE_COLOR) $(ENABLE_INPUT_TYPE_DATE) $(ENABLE_INPUT_TYPE_DATETIMELOCAL) $(ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE) $(ENABLE_INPUT_TYPE_MONTH) $(ENABLE_INPUT_TYPE_TIME) $(ENABLE_INPUT_TYPE_WEEK) $(ENABLE_INSPECTOR_ALTERNATE_DISPATCHERS) $(ENABLE_INSPECTOR_TELEMETRY) $(ENABLE_INTERSECTION_OBSERVER) $(ENABLE_INTL) $(ENABLE_IOS_GESTURE_EVENTS) $(ENABLE_IOS_TOUCH_EVENTS) $(ENABLE_JIT) $(ENABLE_LAYOUT_FORMATTING_CONTEXT) $(ENABLE_LEGACY_CSS_VENDOR_PREFIXES) $(ENABLE_LEGACY_CUSTOM_PROTOCOL_MANAGER) $(ENABLE_LEGACY_ENCRYPTED_MEDIA) $(ENABLE_LETTERPRESS) $(ENABLE_MAC_GESTURE_EVENTS) $(ENABLE_MAC_VIDEO_TOOLBOX) $(ENABLE_MATHML) $(ENABLE_MEDIA_CAPTURE) $(ENABLE_MEDIA_CONTROLS_SCRIPT) $(ENABLE_MEDIA_SESSION) $(ENABLE_M
EDIA_SOURCE) $(ENABLE_MEDIA_STATISTICS) $(ENABLE_MEDIA_STREAM) $(ENABLE_MEMORY_SAMPLER) $(ENABLE_METER_ELEMENT) $(ENABLE_MHTML) $(ENABLE_MOUSE_CURSOR_SCALE) $(ENABLE_NAVIGATOR_STANDALONE) $(ENABLE_NETWORK_CACHE_SPECULATIVE_REVALIDATION) $(ENABLE_NOTIFICATIONS) $(ENABLE_OFFSCREEN_CANVAS) $(ENABLE_OVERFLOW_SCROLLING_TOUCH) $(ENABLE_PAYMENT_REQUEST) $(ENABLE_PDFKIT_PLUGIN) $(ENABLE_POINTER_EVENTS) $(ENABLE_POINTER_LOCK) $(ENABLE_PUBLIC_SUFFIX_LIST) $(ENABLE_QUOTA) $(ENABLE_REMOTE_INSPECTOR) $(ENABLE_RESIZE_OBSERVER) $(ENABLE_RESOLUTION_MEDIA_QUERY) $(ENABLE_RESOURCE_LOAD_STATISTICS) $(ENABLE_RESOURCE_USAGE) $(ENABLE_RUBBER_BANDING) $(ENABLE_SANDBOX_EXTENSIONS) $(ENABLE_SERVER_PRECONNECT) $(ENABLE_SERVICE_CONTROLS) $(ENABLE_SERVICE_WORKER) $(ENABLE_SHAREABLE_RESOURCE) $(ENABLE_SPEECH_SYNTHESIS) $(ENABLE_STREAMS_API) $(ENABLE_SVG_FONTS) $(ENABLE_TELEPHONE_NUMBER_DETECTION) $(ENABLE_TEXT_AUTOSIZING) $(ENABLE_TOUCH_EVENTS) $(ENABLE_USERSELECT_ALL) $(ENABLE_USER_MESSAGE_HANDLERS) $(ENABLE_V
ARIATION_FONTS) $(ENABLE_VIDEO) $(ENABLE_VIDEO_PRESENTATION_MODE) $(ENABLE_VIDEO_TRACK) $(ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN) $(ENABLE_WEBASSEMBLY) $(ENABLE_WEBASSEMBLY_STREAMING_API) $(ENABLE_WEBDRIVER_MOUSE_INTERACTIONS) $(ENABLE_WEBDRIVER_KEYBOARD_INTERACTIONS) $(ENABLE_WEBDRIVER_TOUCH_INTERACTIONS) $(ENABLE_WEBGL) $(ENABLE_WEBGL2) $(ENABLE_WEBGPU) $(ENABLE_WEB_API_STATISTICS) $(ENABLE_WEB_AUDIO) $(ENABLE_WEB_AUTHN) $(ENABLE_WEB_CRYPTO) $(ENABLE_WEB_RTC) $(ENABLE_WIRELESS_PLAYBACK_TARGET) $(ENABLE_XSLT);
+FEATURE_DEFINES = $(ENABLE_3D_TRANSFORMS) $(ENABLE_ACCELERATED_2D_CANVAS) $(ENABLE_ACCESSIBILITY_ISOLATED_TREE) $(ENABLE_APPLE_PAY) $(ENABLE_APPLE_PAY_SESSION_V3) $(ENABLE_APPLE_PAY_SESSION_V4) $(ENABLE_APPLICATION_MANIFEST) $(ENABLE_ATTACHMENT_ELEMENT) $(ENABLE_AVF_CAPTIONS) $(ENABLE_CACHE_PARTITIONING) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CONTENT_FILTERING) $(ENABLE_CSS3_TEXT) $(ENABLE_CSS_BOX_DECORATION_BREAK) $(ENABLE_CSS_COMPOSITING) $(ENABLE_CSS_CONIC_GRADIENTS) $(ENABLE_CSS_DEVICE_ADAPTATION) $(ENABLE_CSS_IMAGE_RESOLUTION) $(ENABLE_CSS_PAINTING_API) $(ENABLE_CSS_SCROLL_SNAP) $(ENABLE_CSS_SELECTORS_LEVEL4) $(ENABLE_CSS_TRAILING_WORD) $(ENABLE_CSS_TYPED_OM) $(ENABLE_CURSOR_VISIBILITY) $(ENABLE_CUSTOM_SCHEME_HANDLER) $(ENABLE_C_LOOP) $(ENABLE_DARK_MODE_CSS) $(ENABLE_DATACUE_VALUE) $(ENABLE_DATALIST_ELEMENT) $(ENABLE_DATA_INTERACTION) $(ENABLE_DEVICE_ORIENTATION) $(ENABLE_DRAG_SUPPORT) $(ENABLE_ENCRYPTED_MEDIA) $(ENABLE_EXPERIMENTAL_FEATURES) $(ENABLE_FAST_JIT_PERMISSI
ONS) $(ENABLE_FILTERS_LEVEL_2) $(ENABLE_FTL_JIT) $(ENABLE_FULLSCREEN_API) $(ENABLE_PICTURE_IN_PICTURE_API) $(ENABLE_GAMEPAD) $(ENABLE_GEOLOCATION) $(ENABLE_GPU_PROCESS) $(ENABLE_INDEXED_DATABASE) $(ENABLE_INDEXED_DATABASE_IN_WORKERS) $(ENABLE_INPUT_TYPE_COLOR) $(ENABLE_INPUT_TYPE_DATE) $(ENABLE_INPUT_TYPE_DATETIMELOCAL) $(ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE) $(ENABLE_INPUT_TYPE_MONTH) $(ENABLE_INPUT_TYPE_TIME) $(ENABLE_INPUT_TYPE_WEEK) $(ENABLE_INSPECTOR_ALTERNATE_DISPATCHERS) $(ENABLE_INSPECTOR_TELEMETRY) $(ENABLE_INTERSECTION_OBSERVER) $(ENABLE_INTL) $(ENABLE_IOS_GESTURE_EVENTS) $(ENABLE_IOS_TOUCH_EVENTS) $(ENABLE_JIT) $(ENABLE_LAYOUT_FORMATTING_CONTEXT) $(ENABLE_LEGACY_CSS_VENDOR_PREFIXES) $(ENABLE_LEGACY_CUSTOM_PROTOCOL_MANAGER) $(ENABLE_LEGACY_ENCRYPTED_MEDIA) $(ENABLE_LETTERPRESS) $(ENABLE_MAC_GESTURE_EVENTS) $(ENABLE_MAC_VIDEO_TOOLBOX) $(ENABLE_MATHML) $(ENABLE_MEDIA_CAPTURE) $(ENABLE_MEDIA_CONTROLS_SCRIPT) $(ENABLE_MEDIA_SESSION) $(ENABLE_MEDIA_SOURCE) $(ENABLE_MEDIA_STATI
STICS) $(ENABLE_MEDIA_STREAM) $(ENABLE_MEMORY_SAMPLER) $(ENABLE_METER_ELEMENT) $(ENABLE_MHTML) $(ENABLE_MOUSE_CURSOR_SCALE) $(ENABLE_NAVIGATOR_STANDALONE) $(ENABLE_NETWORK_CACHE_SPECULATIVE_REVALIDATION) $(ENABLE_NOTIFICATIONS) $(ENABLE_OFFSCREEN_CANVAS) $(ENABLE_OVERFLOW_SCROLLING_TOUCH) $(ENABLE_PAYMENT_REQUEST) $(ENABLE_PDFKIT_PLUGIN) $(ENABLE_POINTER_EVENTS) $(ENABLE_POINTER_LOCK) $(ENABLE_PUBLIC_SUFFIX_LIST) $(ENABLE_QUOTA) $(ENABLE_REMOTE_INSPECTOR) $(ENABLE_RESIZE_OBSERVER) $(ENABLE_RESOLUTION_MEDIA_QUERY) $(ENABLE_RESOURCE_LOAD_STATISTICS) $(ENABLE_RESOURCE_USAGE) $(ENABLE_RUBBER_BANDING) $(ENABLE_SANDBOX_EXTENSIONS) $(ENABLE_SERVER_PRECONNECT) $(ENABLE_SERVICE_CONTROLS) $(ENABLE_SERVICE_WORKER) $(ENABLE_SHAREABLE_RESOURCE) $(ENABLE_SPEECH_SYNTHESIS) $(ENABLE_STREAMS_API) $(ENABLE_SVG_FONTS) $(ENABLE_TELEPHONE_NUMBER_DETECTION) $(ENABLE_TEXT_AUTOSIZING) $(ENABLE_TOUCH_EVENTS) $(ENABLE_USERSELECT_ALL) $(ENABLE_USER_MESSAGE_HANDLERS) $(ENABLE_VARIATION_FONTS) $(ENABLE_VIDEO) $
(ENABLE_VIDEO_PRESENTATION_MODE) $(ENABLE_VIDEO_TRACK) $(ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN) $(ENABLE_WEBASSEMBLY) $(ENABLE_WEBASSEMBLY_STREAMING_API) $(ENABLE_WEBDRIVER_MOUSE_INTERACTIONS) $(ENABLE_WEBDRIVER_KEYBOARD_INTERACTIONS) $(ENABLE_WEBDRIVER_TOUCH_INTERACTIONS) $(ENABLE_WEBGL) $(ENABLE_WEBGL2) $(ENABLE_WEBGPU) $(ENABLE_WEB_API_STATISTICS) $(ENABLE_WEB_AUDIO) $(ENABLE_WEB_AUTHN) $(ENABLE_WEB_CRYPTO) $(ENABLE_WEB_RTC) $(ENABLE_WIRELESS_PLAYBACK_TARGET) $(ENABLE_XSLT);
Modified: trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp (254186 => 254187)
--- trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp 2020-01-08 05:02:02 UTC (rev 254186)
+++ trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp 2020-01-08 06:40:29 UTC (rev 254187)
@@ -2895,10 +2895,10 @@
if (style.borderFit() == BorderFit::Border)
return cssValuePool.createIdentifierValue(CSSValueBorder);
return cssValuePool.createIdentifierValue(CSSValueLines);
-#if ENABLE(CSS_IMAGE_ORIENTATION)
case CSSPropertyImageOrientation:
- return cssValuePool.createValue(style.imageOrientation());
-#endif
+ if (style.imageOrientation() == ImageOrientation::FromImage)
+ return cssValuePool.createIdentifierValue(CSSValueFromImage);
+ return cssValuePool.createIdentifierValue(CSSValueNone);
case CSSPropertyImageRendering:
return CSSPrimitiveValue::create(style.imageRendering());
#if ENABLE(CSS_IMAGE_RESOLUTION)
Modified: trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h (254186 => 254187)
--- trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h 2020-01-08 05:02:02 UTC (rev 254186)
+++ trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h 2020-01-08 06:40:29 UTC (rev 254187)
@@ -47,10 +47,6 @@
#include <wtf/MathExtras.h>
#include <wtf/OptionSet.h>
-#if ENABLE(CSS_IMAGE_ORIENTATION)
-#include "ImageOrientation.h"
-#endif
-
namespace WebCore {
template<> inline CSSPrimitiveValue::CSSPrimitiveValue(short i)
@@ -4883,56 +4879,6 @@
return MaskType::Luminance;
}
-#if ENABLE(CSS_IMAGE_ORIENTATION)
-
-template<> inline CSSPrimitiveValue::CSSPrimitiveValue(ImageOrientation e)
- : CSSValue(PrimitiveClass)
-{
- setPrimitiveUnitType(CSSUnitType::CSS_DEG);
- switch (e) {
- case ImageOrientation::OriginTopLeft:
- m_value.num = 0;
- break;
- case ImageOrientation::OriginRightTop:
- m_value.num = 90;
- break;
- case ImageOrientation::OriginBottomRight:
- m_value.num = 180;
- break;
- case ImageOrientation::OriginLeftBottom:
- m_value.num = 270;
- break;
- case ImageOrientation::FromImage:
- case ImageOrientation::OriginTopRight:
- case ImageOrientation::OriginLeftTop:
- case ImageOrientation::OriginBottomLeft:
- case ImageOrientation::OriginRightBottom:
- ASSERT_NOT_REACHED();
- }
-}
-
-template<> inline CSSPrimitiveValue::operator ImageOrientation() const
-{
- ASSERT(isAngle());
- double quarters = 4 * doubleValue(CSSUnitType::CSS_TURN);
- int orientation = 3 & static_cast<int>(quarters < 0 ? floor(quarters) : ceil(quarters));
- switch (orientation) {
- case 0:
- return ImageOrientation::OriginTopLeft;
- case 1:
- return ImageOrientation::OriginRightTop;
- case 2:
- return ImageOrientation::OriginBottomRight;
- case 3:
- return ImageOrientation::OriginLeftBottom;
- }
-
- ASSERT_NOT_REACHED();
- return ImageOrientation::None;
-}
-
-#endif // ENABLE(CSS_IMAGE_ORIENTATION)
-
template<> inline CSSPrimitiveValue::CSSPrimitiveValue(CSSBoxType cssBox)
: CSSValue(PrimitiveClass)
{
Modified: trunk/Source/WebCore/css/CSSProperties.json (254186 => 254187)
--- trunk/Source/WebCore/css/CSSProperties.json 2020-01-08 05:02:02 UTC (rev 254186)
+++ trunk/Source/WebCore/css/CSSProperties.json 2020-01-08 06:40:29 UTC (rev 254187)
@@ -2495,12 +2495,9 @@
"image-orientation": {
"inherited": true,
"codegen-properties": {
- "enable-if": "ENABLE_CSS_IMAGE_ORIENTATION"
+ "initial": "initialImageOrientation",
+ "converter": "ImageOrientation"
},
- "status": {
- "status": "under consideration",
- "enabled-by-default": false
- },
"specification": {
"category": "css-images",
"url": "https://www.w3.org/TR/css3-images/#the-image-orientation"
Modified: trunk/Source/WebCore/css/CSSValueKeywords.in (254186 => 254187)
--- trunk/Source/WebCore/css/CSSValueKeywords.in 2020-01-08 05:02:02 UTC (rev 254186)
+++ trunk/Source/WebCore/css/CSSValueKeywords.in 2020-01-08 06:40:29 UTC (rev 254187)
@@ -1310,8 +1310,9 @@
max
clamp
+from-image
+
#if defined(ENABLE_CSS_IMAGE_RESOLUTION) && ENABLE_CSS_IMAGE_RESOLUTION
-from-image
snap
#endif
Modified: trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp (254186 => 254187)
--- trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp 2020-01-08 05:02:02 UTC (rev 254186)
+++ trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp 2020-01-08 06:40:29 UTC (rev 254187)
@@ -2901,17 +2901,12 @@
return CSSReflectValue::create(direction.releaseNonNull(), offset.releaseNonNull(), WTFMove(mask));
}
-#if ENABLE(CSS_IMAGE_ORIENTATION)
-static RefPtr<CSSValue> consumeImageOrientation(CSSParserTokenRange& range, CSSParserMode cssParserMode, UnitlessQuirk unitless = UnitlessQuirk::Forbid)
+static RefPtr<CSSValue> consumeImageOrientation(CSSParserTokenRange& range)
{
- if (range.peek().type() != NumberToken) {
- RefPtr<CSSPrimitiveValue> angle = consumeAngle(range, cssParserMode, unitless);
- if (angle && angle->doubleValue() == 0)
- return angle;
- }
+ if (range.peek().id() == CSSValueNone || range.peek().id() == CSSValueFromImage)
+ return consumeIdent(range);
return nullptr;
}
-#endif
static RefPtr<CSSPrimitiveValue> consumeBackgroundBlendMode(CSSParserTokenRange& range)
{
@@ -4173,10 +4168,8 @@
return consumeReflect(m_range, m_context);
case CSSPropertyWebkitLineBoxContain:
return consumeLineBoxContain(m_range);
-#if ENABLE(CSS_IMAGE_ORIENTATION)
case CSSPropertyImageOrientation:
- return consumeImageOrientation(m_range, m_context.mode);
-#endif
+ return consumeImageOrientation(m_range);
case CSSPropertyBackgroundAttachment:
case CSSPropertyBackgroundBlendMode:
case CSSPropertyBackgroundClip:
Modified: trunk/Source/WebCore/rendering/RenderElement.cpp (254186 => 254187)
--- trunk/Source/WebCore/rendering/RenderElement.cpp 2020-01-08 05:02:02 UTC (rev 254186)
+++ trunk/Source/WebCore/rendering/RenderElement.cpp 2020-01-08 06:40:29 UTC (rev 254187)
@@ -2052,7 +2052,7 @@
ImageOrientation RenderElement::imageOrientation() const
{
- return ImageOrientation::FromImage;
+ return style().imageOrientation();
}
void RenderElement::adjustFragmentedFlowStateOnContainingBlockChangeIfNeeded()
Modified: trunk/Source/WebCore/rendering/RenderImage.cpp (254186 => 254187)
--- trunk/Source/WebCore/rendering/RenderImage.cpp 2020-01-08 05:02:02 UTC (rev 254186)
+++ trunk/Source/WebCore/rendering/RenderImage.cpp 2020-01-08 06:40:29 UTC (rev 254187)
@@ -245,10 +245,8 @@
repaintOrMarkForLayout(ImageSizeChangeForAltText);
m_needsToSetSizeForAltText = false;
}
-#if ENABLE(CSS_IMAGE_ORIENTATION)
if (diff == StyleDifference::Layout && oldStyle->imageOrientation() != style().imageOrientation())
return repaintOrMarkForLayout(ImageSizeChangeNone);
-#endif
#if ENABLE(CSS_IMAGE_RESOLUTION)
if (diff == StyleDifference::Layout
Modified: trunk/Source/WebCore/rendering/style/RenderStyle.cpp (254186 => 254187)
--- trunk/Source/WebCore/rendering/style/RenderStyle.cpp 2020-01-08 05:02:02 UTC (rev 254186)
+++ trunk/Source/WebCore/rendering/style/RenderStyle.cpp 2020-01-08 06:40:29 UTC (rev 254187)
@@ -758,9 +758,7 @@
|| first.tabSize != second.tabSize
|| first.lineBoxContain != second.lineBoxContain
|| first.lineGrid != second.lineGrid
-#if ENABLE(CSS_IMAGE_ORIENTATION)
|| first.imageOrientation != second.imageOrientation
-#endif
#if ENABLE(CSS_IMAGE_RESOLUTION)
|| first.imageResolutionSource != second.imageResolutionSource
|| first.imageResolutionSnap != second.imageResolutionSnap
Modified: trunk/Source/WebCore/rendering/style/RenderStyle.h (254186 => 254187)
--- trunk/Source/WebCore/rendering/style/RenderStyle.h 2020-01-08 05:02:02 UTC (rev 254186)
+++ trunk/Source/WebCore/rendering/style/RenderStyle.h 2020-01-08 06:40:29 UTC (rev 254187)
@@ -948,10 +948,7 @@
void setSpecifiedLineHeight(Length&&);
#endif
-#if ENABLE(CSS_IMAGE_ORIENTATION)
void setImageOrientation(ImageOrientation v) { SET_VAR(m_rareInheritedData, imageOrientation, static_cast<int>(v)); }
-#endif
-
void setImageRendering(ImageRendering v) { SET_VAR(m_rareInheritedData, imageRendering, static_cast<unsigned>(v)); }
#if ENABLE(CSS_IMAGE_RESOLUTION)
@@ -1601,7 +1598,7 @@
static OptionSet<TextEmphasisPosition> initialTextEmphasisPosition() { return { TextEmphasisPosition::Over, TextEmphasisPosition::Right }; }
static RubyPosition initialRubyPosition() { return RubyPosition::Before; }
static OptionSet<LineBoxContain> initialLineBoxContain() { return { LineBoxContain::Block, LineBoxContain::Inline, LineBoxContain::Replaced }; }
- static ImageOrientation initialImageOrientation() { return ImageOrientation::None; }
+ static ImageOrientation initialImageOrientation() { return ImageOrientation::FromImage; }
static ImageRendering initialImageRendering() { return ImageRendering::Auto; }
static ImageResolutionSource initialImageResolutionSource() { return ImageResolutionSource::Specified; }
static ImageResolutionSnap initialImageResolutionSnap() { return ImageResolutionSnap::None; }
@@ -2112,11 +2109,7 @@
inline ImageOrientation RenderStyle::imageOrientation() const
{
-#if ENABLE(CSS_IMAGE_ORIENTATION)
- return ImageOrientation(m_rareInheritedData->imageOrientation);
-#else
- return ImageOrientation::None;
-#endif
+ return static_cast<ImageOrientation::Orientation>(m_rareInheritedData->imageOrientation);
}
inline void RenderStyle::setLogicalWidth(Length&& logicalWidth)
Modified: trunk/Source/WebCore/rendering/style/StyleRareInheritedData.cpp (254186 => 254187)
--- trunk/Source/WebCore/rendering/style/StyleRareInheritedData.cpp 2020-01-08 05:02:02 UTC (rev 254186)
+++ trunk/Source/WebCore/rendering/style/StyleRareInheritedData.cpp 2020-01-08 06:40:29 UTC (rev 254187)
@@ -105,9 +105,7 @@
, textIndentType(RenderStyle::initialTextIndentType())
#endif
, lineBoxContain(static_cast<unsigned>(RenderStyle::initialLineBoxContain().toRaw()))
-#if ENABLE(CSS_IMAGE_ORIENTATION)
, imageOrientation(RenderStyle::initialImageOrientation())
-#endif
, imageRendering(static_cast<unsigned>(RenderStyle::initialImageRendering()))
, lineSnap(static_cast<unsigned>(RenderStyle::initialLineSnap()))
, lineAlign(static_cast<unsigned>(RenderStyle::initialLineAlign()))
@@ -203,9 +201,7 @@
, textIndentType(o.textIndentType)
#endif
, lineBoxContain(o.lineBoxContain)
-#if ENABLE(CSS_IMAGE_ORIENTATION)
, imageOrientation(o.imageOrientation)
-#endif
, imageRendering(o.imageRendering)
, lineSnap(o.lineSnap)
, lineAlign(o.lineAlign)
@@ -333,9 +329,7 @@
&& appleColorFilter == o.appleColorFilter
&& tabSize == o.tabSize
&& lineGrid == o.lineGrid
-#if ENABLE(CSS_IMAGE_ORIENTATION)
&& imageOrientation == o.imageOrientation
-#endif
&& imageRendering == o.imageRendering
#if ENABLE(CSS_IMAGE_RESOLUTION)
&& imageResolutionSource == o.imageResolutionSource
Modified: trunk/Source/WebCore/rendering/style/StyleRareInheritedData.h (254186 => 254187)
--- trunk/Source/WebCore/rendering/style/StyleRareInheritedData.h 2020-01-08 05:02:02 UTC (rev 254186)
+++ trunk/Source/WebCore/rendering/style/StyleRareInheritedData.h 2020-01-08 06:40:29 UTC (rev 254187)
@@ -122,9 +122,7 @@
#endif
unsigned lineBoxContain: 7; // OptionSet<LineBoxContain>
// CSS Image Values Level 3
-#if ENABLE(CSS_IMAGE_ORIENTATION)
- unsigned imageOrientation : 4; // ImageOrientation
-#endif
+ unsigned imageOrientation : 1; // ImageOrientation
unsigned imageRendering : 3; // ImageRendering
unsigned lineSnap : 2; // LineSnap
unsigned lineAlign : 1; // LineAlign
Modified: trunk/Source/WebCore/style/StyleBuilderConverter.h (254186 => 254187)
--- trunk/Source/WebCore/style/StyleBuilderConverter.h 2020-01-08 05:02:02 UTC (rev 254186)
+++ trunk/Source/WebCore/style/StyleBuilderConverter.h 2020-01-08 06:40:29 UTC (rev 254187)
@@ -81,6 +81,7 @@
template<CSSPropertyID> static NinePieceImage convertBorderImage(BuilderState&, CSSValue&);
template<CSSPropertyID> static NinePieceImage convertBorderMask(BuilderState&, CSSValue&);
template<CSSPropertyID> static RefPtr<StyleImage> convertStyleImage(BuilderState&, CSSValue&);
+ static ImageOrientation convertImageOrientation(BuilderState&, const CSSValue&);
static TransformOperations convertTransform(BuilderState&, const CSSValue&);
#if ENABLE(DARK_MODE_CSS)
static StyleColorScheme convertColorScheme(BuilderState&, const CSSValue&);
@@ -468,6 +469,14 @@
return builderState.createStyleImage(value);
}
+inline ImageOrientation BuilderConverter::convertImageOrientation(BuilderState&, const CSSValue& value)
+{
+ auto& primitiveValue = downcast<CSSPrimitiveValue>(value);
+ if (primitiveValue.valueID() == CSSValueFromImage)
+ return ImageOrientation::FromImage;
+ return ImageOrientation::None;
+}
+
inline TransformOperations BuilderConverter::convertTransform(BuilderState& builderState, const CSSValue& value)
{
TransformOperations operations;
Modified: trunk/Source/WebKit/ChangeLog (254186 => 254187)
--- trunk/Source/WebKit/ChangeLog 2020-01-08 05:02:02 UTC (rev 254186)
+++ trunk/Source/WebKit/ChangeLog 2020-01-08 06:40:29 UTC (rev 254187)
@@ -1,3 +1,14 @@
+2020-01-07 Said Abou-Hallawa <sabouhall...@apple.com>
+
+ Implement css3-images image-orientation
+ https://bugs.webkit.org/show_bug.cgi?id=89052
+
+ Reviewed by Simon Fraser.
+
+ Remove the ENABLE_CSS_IMAGE_ORIENTATION feature flag.
+
+ * Configurations/FeatureDefines.xcconfig:
+
2020-01-07 Alex Christensen <achristen...@webkit.org>
Introduce _WKResourceLoadDelegate
Modified: trunk/Source/WebKit/Configurations/FeatureDefines.xcconfig (254186 => 254187)
--- trunk/Source/WebKit/Configurations/FeatureDefines.xcconfig 2020-01-08 05:02:02 UTC (rev 254186)
+++ trunk/Source/WebKit/Configurations/FeatureDefines.xcconfig 2020-01-08 06:40:29 UTC (rev 254187)
@@ -99,8 +99,6 @@
ENABLE_CSS_DEVICE_ADAPTATION = ;
-ENABLE_CSS_IMAGE_ORIENTATION = ;
-
ENABLE_CSS_IMAGE_RESOLUTION = ;
ENABLE_CSS_PAINTING_API = ENABLE_CSS_PAINTING_API;
@@ -444,4 +442,4 @@
ENABLE_XSLT = ENABLE_XSLT;
-FEATURE_DEFINES = $(ENABLE_3D_TRANSFORMS) $(ENABLE_ACCELERATED_2D_CANVAS) $(ENABLE_ACCESSIBILITY_ISOLATED_TREE) $(ENABLE_APPLE_PAY) $(ENABLE_APPLE_PAY_SESSION_V3) $(ENABLE_APPLE_PAY_SESSION_V4) $(ENABLE_APPLICATION_MANIFEST) $(ENABLE_ATTACHMENT_ELEMENT) $(ENABLE_AVF_CAPTIONS) $(ENABLE_CACHE_PARTITIONING) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CONTENT_FILTERING) $(ENABLE_CSS3_TEXT) $(ENABLE_CSS_BOX_DECORATION_BREAK) $(ENABLE_CSS_COMPOSITING) $(ENABLE_CSS_CONIC_GRADIENTS) $(ENABLE_CSS_DEVICE_ADAPTATION) $(ENABLE_CSS_IMAGE_ORIENTATION) $(ENABLE_CSS_IMAGE_RESOLUTION) $(ENABLE_CSS_PAINTING_API) $(ENABLE_CSS_SCROLL_SNAP) $(ENABLE_CSS_SELECTORS_LEVEL4) $(ENABLE_CSS_TRAILING_WORD) $(ENABLE_CSS_TYPED_OM) $(ENABLE_CURSOR_VISIBILITY) $(ENABLE_CUSTOM_SCHEME_HANDLER) $(ENABLE_C_LOOP) $(ENABLE_DARK_MODE_CSS) $(ENABLE_DATACUE_VALUE) $(ENABLE_DATALIST_ELEMENT) $(ENABLE_DATA_INTERACTION) $(ENABLE_DEVICE_ORIENTATION) $(ENABLE_DRAG_SUPPORT) $(ENABLE_ENCRYPTED_MEDIA) $(ENABLE_EXPERIMENTAL_FEA
TURES) $(ENABLE_FAST_JIT_PERMISSIONS) $(ENABLE_FILTERS_LEVEL_2) $(ENABLE_FTL_JIT) $(ENABLE_FULLSCREEN_API) $(ENABLE_PICTURE_IN_PICTURE_API) $(ENABLE_GAMEPAD) $(ENABLE_GEOLOCATION) $(ENABLE_GPU_PROCESS) $(ENABLE_INDEXED_DATABASE) $(ENABLE_INDEXED_DATABASE_IN_WORKERS) $(ENABLE_INPUT_TYPE_COLOR) $(ENABLE_INPUT_TYPE_DATE) $(ENABLE_INPUT_TYPE_DATETIMELOCAL) $(ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE) $(ENABLE_INPUT_TYPE_MONTH) $(ENABLE_INPUT_TYPE_TIME) $(ENABLE_INPUT_TYPE_WEEK) $(ENABLE_INSPECTOR_ALTERNATE_DISPATCHERS) $(ENABLE_INSPECTOR_TELEMETRY) $(ENABLE_INTERSECTION_OBSERVER) $(ENABLE_INTL) $(ENABLE_IOS_GESTURE_EVENTS) $(ENABLE_IOS_TOUCH_EVENTS) $(ENABLE_JIT) $(ENABLE_LAYOUT_FORMATTING_CONTEXT) $(ENABLE_LEGACY_CSS_VENDOR_PREFIXES) $(ENABLE_LEGACY_CUSTOM_PROTOCOL_MANAGER) $(ENABLE_LEGACY_ENCRYPTED_MEDIA) $(ENABLE_LETTERPRESS) $(ENABLE_MAC_GESTURE_EVENTS) $(ENABLE_MAC_VIDEO_TOOLBOX) $(ENABLE_MATHML) $(ENABLE_MEDIA_CAPTURE) $(ENABLE_MEDIA_CONTROLS_SCRIPT) $(ENABLE_MEDIA_SESSION) $(ENABLE_M
EDIA_SOURCE) $(ENABLE_MEDIA_STATISTICS) $(ENABLE_MEDIA_STREAM) $(ENABLE_MEMORY_SAMPLER) $(ENABLE_METER_ELEMENT) $(ENABLE_MHTML) $(ENABLE_MOUSE_CURSOR_SCALE) $(ENABLE_NAVIGATOR_STANDALONE) $(ENABLE_NETWORK_CACHE_SPECULATIVE_REVALIDATION) $(ENABLE_NOTIFICATIONS) $(ENABLE_OFFSCREEN_CANVAS) $(ENABLE_OVERFLOW_SCROLLING_TOUCH) $(ENABLE_PAYMENT_REQUEST) $(ENABLE_PDFKIT_PLUGIN) $(ENABLE_POINTER_EVENTS) $(ENABLE_POINTER_LOCK) $(ENABLE_PUBLIC_SUFFIX_LIST) $(ENABLE_QUOTA) $(ENABLE_REMOTE_INSPECTOR) $(ENABLE_RESIZE_OBSERVER) $(ENABLE_RESOLUTION_MEDIA_QUERY) $(ENABLE_RESOURCE_LOAD_STATISTICS) $(ENABLE_RESOURCE_USAGE) $(ENABLE_RUBBER_BANDING) $(ENABLE_SANDBOX_EXTENSIONS) $(ENABLE_SERVER_PRECONNECT) $(ENABLE_SERVICE_CONTROLS) $(ENABLE_SERVICE_WORKER) $(ENABLE_SHAREABLE_RESOURCE) $(ENABLE_SPEECH_SYNTHESIS) $(ENABLE_STREAMS_API) $(ENABLE_SVG_FONTS) $(ENABLE_TELEPHONE_NUMBER_DETECTION) $(ENABLE_TEXT_AUTOSIZING) $(ENABLE_TOUCH_EVENTS) $(ENABLE_USERSELECT_ALL) $(ENABLE_USER_MESSAGE_HANDLERS) $(ENABLE_V
ARIATION_FONTS) $(ENABLE_VIDEO) $(ENABLE_VIDEO_PRESENTATION_MODE) $(ENABLE_VIDEO_TRACK) $(ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN) $(ENABLE_WEBASSEMBLY) $(ENABLE_WEBASSEMBLY_STREAMING_API) $(ENABLE_WEBDRIVER_MOUSE_INTERACTIONS) $(ENABLE_WEBDRIVER_KEYBOARD_INTERACTIONS) $(ENABLE_WEBDRIVER_TOUCH_INTERACTIONS) $(ENABLE_WEBGL) $(ENABLE_WEBGL2) $(ENABLE_WEBGPU) $(ENABLE_WEB_API_STATISTICS) $(ENABLE_WEB_AUDIO) $(ENABLE_WEB_AUTHN) $(ENABLE_WEB_CRYPTO) $(ENABLE_WEB_RTC) $(ENABLE_WIRELESS_PLAYBACK_TARGET) $(ENABLE_XSLT);
+FEATURE_DEFINES = $(ENABLE_3D_TRANSFORMS) $(ENABLE_ACCELERATED_2D_CANVAS) $(ENABLE_ACCESSIBILITY_ISOLATED_TREE) $(ENABLE_APPLE_PAY) $(ENABLE_APPLE_PAY_SESSION_V3) $(ENABLE_APPLE_PAY_SESSION_V4) $(ENABLE_APPLICATION_MANIFEST) $(ENABLE_ATTACHMENT_ELEMENT) $(ENABLE_AVF_CAPTIONS) $(ENABLE_CACHE_PARTITIONING) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CONTENT_FILTERING) $(ENABLE_CSS3_TEXT) $(ENABLE_CSS_BOX_DECORATION_BREAK) $(ENABLE_CSS_COMPOSITING) $(ENABLE_CSS_CONIC_GRADIENTS) $(ENABLE_CSS_DEVICE_ADAPTATION) $(ENABLE_CSS_IMAGE_RESOLUTION) $(ENABLE_CSS_PAINTING_API) $(ENABLE_CSS_SCROLL_SNAP) $(ENABLE_CSS_SELECTORS_LEVEL4) $(ENABLE_CSS_TRAILING_WORD) $(ENABLE_CSS_TYPED_OM) $(ENABLE_CURSOR_VISIBILITY) $(ENABLE_CUSTOM_SCHEME_HANDLER) $(ENABLE_C_LOOP) $(ENABLE_DARK_MODE_CSS) $(ENABLE_DATACUE_VALUE) $(ENABLE_DATALIST_ELEMENT) $(ENABLE_DATA_INTERACTION) $(ENABLE_DEVICE_ORIENTATION) $(ENABLE_DRAG_SUPPORT) $(ENABLE_ENCRYPTED_MEDIA) $(ENABLE_EXPERIMENTAL_FEATURES) $(ENABLE_FAST_JIT_PERMISSI
ONS) $(ENABLE_FILTERS_LEVEL_2) $(ENABLE_FTL_JIT) $(ENABLE_FULLSCREEN_API) $(ENABLE_PICTURE_IN_PICTURE_API) $(ENABLE_GAMEPAD) $(ENABLE_GEOLOCATION) $(ENABLE_GPU_PROCESS) $(ENABLE_INDEXED_DATABASE) $(ENABLE_INDEXED_DATABASE_IN_WORKERS) $(ENABLE_INPUT_TYPE_COLOR) $(ENABLE_INPUT_TYPE_DATE) $(ENABLE_INPUT_TYPE_DATETIMELOCAL) $(ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE) $(ENABLE_INPUT_TYPE_MONTH) $(ENABLE_INPUT_TYPE_TIME) $(ENABLE_INPUT_TYPE_WEEK) $(ENABLE_INSPECTOR_ALTERNATE_DISPATCHERS) $(ENABLE_INSPECTOR_TELEMETRY) $(ENABLE_INTERSECTION_OBSERVER) $(ENABLE_INTL) $(ENABLE_IOS_GESTURE_EVENTS) $(ENABLE_IOS_TOUCH_EVENTS) $(ENABLE_JIT) $(ENABLE_LAYOUT_FORMATTING_CONTEXT) $(ENABLE_LEGACY_CSS_VENDOR_PREFIXES) $(ENABLE_LEGACY_CUSTOM_PROTOCOL_MANAGER) $(ENABLE_LEGACY_ENCRYPTED_MEDIA) $(ENABLE_LETTERPRESS) $(ENABLE_MAC_GESTURE_EVENTS) $(ENABLE_MAC_VIDEO_TOOLBOX) $(ENABLE_MATHML) $(ENABLE_MEDIA_CAPTURE) $(ENABLE_MEDIA_CONTROLS_SCRIPT) $(ENABLE_MEDIA_SESSION) $(ENABLE_MEDIA_SOURCE) $(ENABLE_MEDIA_STATI
STICS) $(ENABLE_MEDIA_STREAM) $(ENABLE_MEMORY_SAMPLER) $(ENABLE_METER_ELEMENT) $(ENABLE_MHTML) $(ENABLE_MOUSE_CURSOR_SCALE) $(ENABLE_NAVIGATOR_STANDALONE) $(ENABLE_NETWORK_CACHE_SPECULATIVE_REVALIDATION) $(ENABLE_NOTIFICATIONS) $(ENABLE_OFFSCREEN_CANVAS) $(ENABLE_OVERFLOW_SCROLLING_TOUCH) $(ENABLE_PAYMENT_REQUEST) $(ENABLE_PDFKIT_PLUGIN) $(ENABLE_POINTER_EVENTS) $(ENABLE_POINTER_LOCK) $(ENABLE_PUBLIC_SUFFIX_LIST) $(ENABLE_QUOTA) $(ENABLE_REMOTE_INSPECTOR) $(ENABLE_RESIZE_OBSERVER) $(ENABLE_RESOLUTION_MEDIA_QUERY) $(ENABLE_RESOURCE_LOAD_STATISTICS) $(ENABLE_RESOURCE_USAGE) $(ENABLE_RUBBER_BANDING) $(ENABLE_SANDBOX_EXTENSIONS) $(ENABLE_SERVER_PRECONNECT) $(ENABLE_SERVICE_CONTROLS) $(ENABLE_SERVICE_WORKER) $(ENABLE_SHAREABLE_RESOURCE) $(ENABLE_SPEECH_SYNTHESIS) $(ENABLE_STREAMS_API) $(ENABLE_SVG_FONTS) $(ENABLE_TELEPHONE_NUMBER_DETECTION) $(ENABLE_TEXT_AUTOSIZING) $(ENABLE_TOUCH_EVENTS) $(ENABLE_USERSELECT_ALL) $(ENABLE_USER_MESSAGE_HANDLERS) $(ENABLE_VARIATION_FONTS) $(ENABLE_VIDEO) $
(ENABLE_VIDEO_PRESENTATION_MODE) $(ENABLE_VIDEO_TRACK) $(ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN) $(ENABLE_WEBASSEMBLY) $(ENABLE_WEBASSEMBLY_STREAMING_API) $(ENABLE_WEBDRIVER_MOUSE_INTERACTIONS) $(ENABLE_WEBDRIVER_KEYBOARD_INTERACTIONS) $(ENABLE_WEBDRIVER_TOUCH_INTERACTIONS) $(ENABLE_WEBGL) $(ENABLE_WEBGL2) $(ENABLE_WEBGPU) $(ENABLE_WEB_API_STATISTICS) $(ENABLE_WEB_AUDIO) $(ENABLE_WEB_AUTHN) $(ENABLE_WEB_CRYPTO) $(ENABLE_WEB_RTC) $(ENABLE_WIRELESS_PLAYBACK_TARGET) $(ENABLE_XSLT);
Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (254186 => 254187)
--- trunk/Source/WebKitLegacy/mac/ChangeLog 2020-01-08 05:02:02 UTC (rev 254186)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog 2020-01-08 06:40:29 UTC (rev 254187)
@@ -1,3 +1,14 @@
+2020-01-07 Said Abou-Hallawa <sabouhall...@apple.com>
+
+ Implement css3-images image-orientation
+ https://bugs.webkit.org/show_bug.cgi?id=89052
+
+ Reviewed by Simon Fraser.
+
+ Remove the ENABLE_CSS_IMAGE_ORIENTATION feature flag.
+
+ * Configurations/FeatureDefines.xcconfig:
+
2020-01-07 Chris Dumez <cdu...@apple.com>
Remove document.origin
Modified: trunk/Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig (254186 => 254187)
--- trunk/Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig 2020-01-08 05:02:02 UTC (rev 254186)
+++ trunk/Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig 2020-01-08 06:40:29 UTC (rev 254187)
@@ -99,8 +99,6 @@
ENABLE_CSS_DEVICE_ADAPTATION = ;
-ENABLE_CSS_IMAGE_ORIENTATION = ;
-
ENABLE_CSS_IMAGE_RESOLUTION = ;
ENABLE_CSS_PAINTING_API = ENABLE_CSS_PAINTING_API;
@@ -444,4 +442,4 @@
ENABLE_XSLT = ENABLE_XSLT;
-FEATURE_DEFINES = $(ENABLE_3D_TRANSFORMS) $(ENABLE_ACCELERATED_2D_CANVAS) $(ENABLE_ACCESSIBILITY_ISOLATED_TREE) $(ENABLE_APPLE_PAY) $(ENABLE_APPLE_PAY_SESSION_V3) $(ENABLE_APPLE_PAY_SESSION_V4) $(ENABLE_APPLICATION_MANIFEST) $(ENABLE_ATTACHMENT_ELEMENT) $(ENABLE_AVF_CAPTIONS) $(ENABLE_CACHE_PARTITIONING) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CONTENT_FILTERING) $(ENABLE_CSS3_TEXT) $(ENABLE_CSS_BOX_DECORATION_BREAK) $(ENABLE_CSS_COMPOSITING) $(ENABLE_CSS_CONIC_GRADIENTS) $(ENABLE_CSS_DEVICE_ADAPTATION) $(ENABLE_CSS_IMAGE_ORIENTATION) $(ENABLE_CSS_IMAGE_RESOLUTION) $(ENABLE_CSS_PAINTING_API) $(ENABLE_CSS_SCROLL_SNAP) $(ENABLE_CSS_SELECTORS_LEVEL4) $(ENABLE_CSS_TRAILING_WORD) $(ENABLE_CSS_TYPED_OM) $(ENABLE_CURSOR_VISIBILITY) $(ENABLE_CUSTOM_SCHEME_HANDLER) $(ENABLE_C_LOOP) $(ENABLE_DARK_MODE_CSS) $(ENABLE_DATACUE_VALUE) $(ENABLE_DATALIST_ELEMENT) $(ENABLE_DATA_INTERACTION) $(ENABLE_DEVICE_ORIENTATION) $(ENABLE_DRAG_SUPPORT) $(ENABLE_ENCRYPTED_MEDIA) $(ENABLE_EXPERIMENTAL_FEA
TURES) $(ENABLE_FAST_JIT_PERMISSIONS) $(ENABLE_FILTERS_LEVEL_2) $(ENABLE_FTL_JIT) $(ENABLE_FULLSCREEN_API) $(ENABLE_PICTURE_IN_PICTURE_API) $(ENABLE_GAMEPAD) $(ENABLE_GEOLOCATION) $(ENABLE_GPU_PROCESS) $(ENABLE_INDEXED_DATABASE) $(ENABLE_INDEXED_DATABASE_IN_WORKERS) $(ENABLE_INPUT_TYPE_COLOR) $(ENABLE_INPUT_TYPE_DATE) $(ENABLE_INPUT_TYPE_DATETIMELOCAL) $(ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE) $(ENABLE_INPUT_TYPE_MONTH) $(ENABLE_INPUT_TYPE_TIME) $(ENABLE_INPUT_TYPE_WEEK) $(ENABLE_INSPECTOR_ALTERNATE_DISPATCHERS) $(ENABLE_INSPECTOR_TELEMETRY) $(ENABLE_INTERSECTION_OBSERVER) $(ENABLE_INTL) $(ENABLE_IOS_GESTURE_EVENTS) $(ENABLE_IOS_TOUCH_EVENTS) $(ENABLE_JIT) $(ENABLE_LAYOUT_FORMATTING_CONTEXT) $(ENABLE_LEGACY_CSS_VENDOR_PREFIXES) $(ENABLE_LEGACY_CUSTOM_PROTOCOL_MANAGER) $(ENABLE_LEGACY_ENCRYPTED_MEDIA) $(ENABLE_LETTERPRESS) $(ENABLE_MAC_GESTURE_EVENTS) $(ENABLE_MAC_VIDEO_TOOLBOX) $(ENABLE_MATHML) $(ENABLE_MEDIA_CAPTURE) $(ENABLE_MEDIA_CONTROLS_SCRIPT) $(ENABLE_MEDIA_SESSION) $(ENABLE_M
EDIA_SOURCE) $(ENABLE_MEDIA_STATISTICS) $(ENABLE_MEDIA_STREAM) $(ENABLE_MEMORY_SAMPLER) $(ENABLE_METER_ELEMENT) $(ENABLE_MHTML) $(ENABLE_MOUSE_CURSOR_SCALE) $(ENABLE_NAVIGATOR_STANDALONE) $(ENABLE_NETWORK_CACHE_SPECULATIVE_REVALIDATION) $(ENABLE_NOTIFICATIONS) $(ENABLE_OFFSCREEN_CANVAS) $(ENABLE_OVERFLOW_SCROLLING_TOUCH) $(ENABLE_PAYMENT_REQUEST) $(ENABLE_PDFKIT_PLUGIN) $(ENABLE_POINTER_EVENTS) $(ENABLE_POINTER_LOCK) $(ENABLE_PUBLIC_SUFFIX_LIST) $(ENABLE_QUOTA) $(ENABLE_REMOTE_INSPECTOR) $(ENABLE_RESIZE_OBSERVER) $(ENABLE_RESOLUTION_MEDIA_QUERY) $(ENABLE_RESOURCE_LOAD_STATISTICS) $(ENABLE_RESOURCE_USAGE) $(ENABLE_RUBBER_BANDING) $(ENABLE_SANDBOX_EXTENSIONS) $(ENABLE_SERVER_PRECONNECT) $(ENABLE_SERVICE_CONTROLS) $(ENABLE_SERVICE_WORKER) $(ENABLE_SHAREABLE_RESOURCE) $(ENABLE_SPEECH_SYNTHESIS) $(ENABLE_STREAMS_API) $(ENABLE_SVG_FONTS) $(ENABLE_TELEPHONE_NUMBER_DETECTION) $(ENABLE_TEXT_AUTOSIZING) $(ENABLE_TOUCH_EVENTS) $(ENABLE_USERSELECT_ALL) $(ENABLE_USER_MESSAGE_HANDLERS) $(ENABLE_V
ARIATION_FONTS) $(ENABLE_VIDEO) $(ENABLE_VIDEO_PRESENTATION_MODE) $(ENABLE_VIDEO_TRACK) $(ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN) $(ENABLE_WEBASSEMBLY) $(ENABLE_WEBASSEMBLY_STREAMING_API) $(ENABLE_WEBDRIVER_MOUSE_INTERACTIONS) $(ENABLE_WEBDRIVER_KEYBOARD_INTERACTIONS) $(ENABLE_WEBDRIVER_TOUCH_INTERACTIONS) $(ENABLE_WEBGL) $(ENABLE_WEBGL2) $(ENABLE_WEBGPU) $(ENABLE_WEB_API_STATISTICS) $(ENABLE_WEB_AUDIO) $(ENABLE_WEB_AUTHN) $(ENABLE_WEB_CRYPTO) $(ENABLE_WEB_RTC) $(ENABLE_WIRELESS_PLAYBACK_TARGET) $(ENABLE_XSLT);
+FEATURE_DEFINES = $(ENABLE_3D_TRANSFORMS) $(ENABLE_ACCELERATED_2D_CANVAS) $(ENABLE_ACCESSIBILITY_ISOLATED_TREE) $(ENABLE_APPLE_PAY) $(ENABLE_APPLE_PAY_SESSION_V3) $(ENABLE_APPLE_PAY_SESSION_V4) $(ENABLE_APPLICATION_MANIFEST) $(ENABLE_ATTACHMENT_ELEMENT) $(ENABLE_AVF_CAPTIONS) $(ENABLE_CACHE_PARTITIONING) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CONTENT_FILTERING) $(ENABLE_CSS3_TEXT) $(ENABLE_CSS_BOX_DECORATION_BREAK) $(ENABLE_CSS_COMPOSITING) $(ENABLE_CSS_CONIC_GRADIENTS) $(ENABLE_CSS_DEVICE_ADAPTATION) $(ENABLE_CSS_IMAGE_RESOLUTION) $(ENABLE_CSS_PAINTING_API) $(ENABLE_CSS_SCROLL_SNAP) $(ENABLE_CSS_SELECTORS_LEVEL4) $(ENABLE_CSS_TRAILING_WORD) $(ENABLE_CSS_TYPED_OM) $(ENABLE_CURSOR_VISIBILITY) $(ENABLE_CUSTOM_SCHEME_HANDLER) $(ENABLE_C_LOOP) $(ENABLE_DARK_MODE_CSS) $(ENABLE_DATACUE_VALUE) $(ENABLE_DATALIST_ELEMENT) $(ENABLE_DATA_INTERACTION) $(ENABLE_DEVICE_ORIENTATION) $(ENABLE_DRAG_SUPPORT) $(ENABLE_ENCRYPTED_MEDIA) $(ENABLE_EXPERIMENTAL_FEATURES) $(ENABLE_FAST_JIT_PERMISSI
ONS) $(ENABLE_FILTERS_LEVEL_2) $(ENABLE_FTL_JIT) $(ENABLE_FULLSCREEN_API) $(ENABLE_PICTURE_IN_PICTURE_API) $(ENABLE_GAMEPAD) $(ENABLE_GEOLOCATION) $(ENABLE_GPU_PROCESS) $(ENABLE_INDEXED_DATABASE) $(ENABLE_INDEXED_DATABASE_IN_WORKERS) $(ENABLE_INPUT_TYPE_COLOR) $(ENABLE_INPUT_TYPE_DATE) $(ENABLE_INPUT_TYPE_DATETIMELOCAL) $(ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE) $(ENABLE_INPUT_TYPE_MONTH) $(ENABLE_INPUT_TYPE_TIME) $(ENABLE_INPUT_TYPE_WEEK) $(ENABLE_INSPECTOR_ALTERNATE_DISPATCHERS) $(ENABLE_INSPECTOR_TELEMETRY) $(ENABLE_INTERSECTION_OBSERVER) $(ENABLE_INTL) $(ENABLE_IOS_GESTURE_EVENTS) $(ENABLE_IOS_TOUCH_EVENTS) $(ENABLE_JIT) $(ENABLE_LAYOUT_FORMATTING_CONTEXT) $(ENABLE_LEGACY_CSS_VENDOR_PREFIXES) $(ENABLE_LEGACY_CUSTOM_PROTOCOL_MANAGER) $(ENABLE_LEGACY_ENCRYPTED_MEDIA) $(ENABLE_LETTERPRESS) $(ENABLE_MAC_GESTURE_EVENTS) $(ENABLE_MAC_VIDEO_TOOLBOX) $(ENABLE_MATHML) $(ENABLE_MEDIA_CAPTURE) $(ENABLE_MEDIA_CONTROLS_SCRIPT) $(ENABLE_MEDIA_SESSION) $(ENABLE_MEDIA_SOURCE) $(ENABLE_MEDIA_STATI
STICS) $(ENABLE_MEDIA_STREAM) $(ENABLE_MEMORY_SAMPLER) $(ENABLE_METER_ELEMENT) $(ENABLE_MHTML) $(ENABLE_MOUSE_CURSOR_SCALE) $(ENABLE_NAVIGATOR_STANDALONE) $(ENABLE_NETWORK_CACHE_SPECULATIVE_REVALIDATION) $(ENABLE_NOTIFICATIONS) $(ENABLE_OFFSCREEN_CANVAS) $(ENABLE_OVERFLOW_SCROLLING_TOUCH) $(ENABLE_PAYMENT_REQUEST) $(ENABLE_PDFKIT_PLUGIN) $(ENABLE_POINTER_EVENTS) $(ENABLE_POINTER_LOCK) $(ENABLE_PUBLIC_SUFFIX_LIST) $(ENABLE_QUOTA) $(ENABLE_REMOTE_INSPECTOR) $(ENABLE_RESIZE_OBSERVER) $(ENABLE_RESOLUTION_MEDIA_QUERY) $(ENABLE_RESOURCE_LOAD_STATISTICS) $(ENABLE_RESOURCE_USAGE) $(ENABLE_RUBBER_BANDING) $(ENABLE_SANDBOX_EXTENSIONS) $(ENABLE_SERVER_PRECONNECT) $(ENABLE_SERVICE_CONTROLS) $(ENABLE_SERVICE_WORKER) $(ENABLE_SHAREABLE_RESOURCE) $(ENABLE_SPEECH_SYNTHESIS) $(ENABLE_STREAMS_API) $(ENABLE_SVG_FONTS) $(ENABLE_TELEPHONE_NUMBER_DETECTION) $(ENABLE_TEXT_AUTOSIZING) $(ENABLE_TOUCH_EVENTS) $(ENABLE_USERSELECT_ALL) $(ENABLE_USER_MESSAGE_HANDLERS) $(ENABLE_VARIATION_FONTS) $(ENABLE_VIDEO) $
(ENABLE_VIDEO_PRESENTATION_MODE) $(ENABLE_VIDEO_TRACK) $(ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN) $(ENABLE_WEBASSEMBLY) $(ENABLE_WEBASSEMBLY_STREAMING_API) $(ENABLE_WEBDRIVER_MOUSE_INTERACTIONS) $(ENABLE_WEBDRIVER_KEYBOARD_INTERACTIONS) $(ENABLE_WEBDRIVER_TOUCH_INTERACTIONS) $(ENABLE_WEBGL) $(ENABLE_WEBGL2) $(ENABLE_WEBGPU) $(ENABLE_WEB_API_STATISTICS) $(ENABLE_WEB_AUDIO) $(ENABLE_WEB_AUTHN) $(ENABLE_WEB_CRYPTO) $(ENABLE_WEB_RTC) $(ENABLE_WIRELESS_PLAYBACK_TARGET) $(ENABLE_XSLT);
Modified: trunk/Tools/ChangeLog (254186 => 254187)
--- trunk/Tools/ChangeLog 2020-01-08 05:02:02 UTC (rev 254186)
+++ trunk/Tools/ChangeLog 2020-01-08 06:40:29 UTC (rev 254187)
@@ -1,3 +1,14 @@
+2020-01-07 Said Abou-Hallawa <sabouhall...@apple.com>
+
+ Implement css3-images image-orientation
+ https://bugs.webkit.org/show_bug.cgi?id=89052
+
+ Reviewed by Simon Fraser.
+
+ Remove the ENABLE_CSS_IMAGE_ORIENTATION feature flag.
+
+ * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
+
2020-01-07 Alex Christensen <achristen...@webkit.org>
Introduce _WKResourceLoadDelegate
Modified: trunk/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig (254186 => 254187)
--- trunk/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig 2020-01-08 05:02:02 UTC (rev 254186)
+++ trunk/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig 2020-01-08 06:40:29 UTC (rev 254187)
@@ -99,8 +99,6 @@
ENABLE_CSS_DEVICE_ADAPTATION = ;
-ENABLE_CSS_IMAGE_ORIENTATION = ;
-
ENABLE_CSS_IMAGE_RESOLUTION = ;
ENABLE_CSS_PAINTING_API = ENABLE_CSS_PAINTING_API;
@@ -444,4 +442,4 @@
ENABLE_XSLT = ENABLE_XSLT;
-FEATURE_DEFINES = $(ENABLE_3D_TRANSFORMS) $(ENABLE_ACCELERATED_2D_CANVAS) $(ENABLE_ACCESSIBILITY_ISOLATED_TREE) $(ENABLE_APPLE_PAY) $(ENABLE_APPLE_PAY_SESSION_V3) $(ENABLE_APPLE_PAY_SESSION_V4) $(ENABLE_APPLICATION_MANIFEST) $(ENABLE_ATTACHMENT_ELEMENT) $(ENABLE_AVF_CAPTIONS) $(ENABLE_CACHE_PARTITIONING) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CONTENT_FILTERING) $(ENABLE_CSS3_TEXT) $(ENABLE_CSS_BOX_DECORATION_BREAK) $(ENABLE_CSS_COMPOSITING) $(ENABLE_CSS_CONIC_GRADIENTS) $(ENABLE_CSS_DEVICE_ADAPTATION) $(ENABLE_CSS_IMAGE_ORIENTATION) $(ENABLE_CSS_IMAGE_RESOLUTION) $(ENABLE_CSS_PAINTING_API) $(ENABLE_CSS_SCROLL_SNAP) $(ENABLE_CSS_SELECTORS_LEVEL4) $(ENABLE_CSS_TRAILING_WORD) $(ENABLE_CSS_TYPED_OM) $(ENABLE_CURSOR_VISIBILITY) $(ENABLE_CUSTOM_SCHEME_HANDLER) $(ENABLE_C_LOOP) $(ENABLE_DARK_MODE_CSS) $(ENABLE_DATACUE_VALUE) $(ENABLE_DATALIST_ELEMENT) $(ENABLE_DATA_INTERACTION) $(ENABLE_DEVICE_ORIENTATION) $(ENABLE_DRAG_SUPPORT) $(ENABLE_ENCRYPTED_MEDIA) $(ENABLE_EXPERIMENTAL_FEA
TURES) $(ENABLE_FAST_JIT_PERMISSIONS) $(ENABLE_FILTERS_LEVEL_2) $(ENABLE_FTL_JIT) $(ENABLE_FULLSCREEN_API) $(ENABLE_PICTURE_IN_PICTURE_API) $(ENABLE_GAMEPAD) $(ENABLE_GEOLOCATION) $(ENABLE_GPU_PROCESS) $(ENABLE_INDEXED_DATABASE) $(ENABLE_INDEXED_DATABASE_IN_WORKERS) $(ENABLE_INPUT_TYPE_COLOR) $(ENABLE_INPUT_TYPE_DATE) $(ENABLE_INPUT_TYPE_DATETIMELOCAL) $(ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE) $(ENABLE_INPUT_TYPE_MONTH) $(ENABLE_INPUT_TYPE_TIME) $(ENABLE_INPUT_TYPE_WEEK) $(ENABLE_INSPECTOR_ALTERNATE_DISPATCHERS) $(ENABLE_INSPECTOR_TELEMETRY) $(ENABLE_INTERSECTION_OBSERVER) $(ENABLE_INTL) $(ENABLE_IOS_GESTURE_EVENTS) $(ENABLE_IOS_TOUCH_EVENTS) $(ENABLE_JIT) $(ENABLE_LAYOUT_FORMATTING_CONTEXT) $(ENABLE_LEGACY_CSS_VENDOR_PREFIXES) $(ENABLE_LEGACY_CUSTOM_PROTOCOL_MANAGER) $(ENABLE_LEGACY_ENCRYPTED_MEDIA) $(ENABLE_LETTERPRESS) $(ENABLE_MAC_GESTURE_EVENTS) $(ENABLE_MAC_VIDEO_TOOLBOX) $(ENABLE_MATHML) $(ENABLE_MEDIA_CAPTURE) $(ENABLE_MEDIA_CONTROLS_SCRIPT) $(ENABLE_MEDIA_SESSION) $(ENABLE_M
EDIA_SOURCE) $(ENABLE_MEDIA_STATISTICS) $(ENABLE_MEDIA_STREAM) $(ENABLE_MEMORY_SAMPLER) $(ENABLE_METER_ELEMENT) $(ENABLE_MHTML) $(ENABLE_MOUSE_CURSOR_SCALE) $(ENABLE_NAVIGATOR_STANDALONE) $(ENABLE_NETWORK_CACHE_SPECULATIVE_REVALIDATION) $(ENABLE_NOTIFICATIONS) $(ENABLE_OFFSCREEN_CANVAS) $(ENABLE_OVERFLOW_SCROLLING_TOUCH) $(ENABLE_PAYMENT_REQUEST) $(ENABLE_PDFKIT_PLUGIN) $(ENABLE_POINTER_EVENTS) $(ENABLE_POINTER_LOCK) $(ENABLE_PUBLIC_SUFFIX_LIST) $(ENABLE_QUOTA) $(ENABLE_REMOTE_INSPECTOR) $(ENABLE_RESIZE_OBSERVER) $(ENABLE_RESOLUTION_MEDIA_QUERY) $(ENABLE_RESOURCE_LOAD_STATISTICS) $(ENABLE_RESOURCE_USAGE) $(ENABLE_RUBBER_BANDING) $(ENABLE_SANDBOX_EXTENSIONS) $(ENABLE_SERVER_PRECONNECT) $(ENABLE_SERVICE_CONTROLS) $(ENABLE_SERVICE_WORKER) $(ENABLE_SHAREABLE_RESOURCE) $(ENABLE_SPEECH_SYNTHESIS) $(ENABLE_STREAMS_API) $(ENABLE_SVG_FONTS) $(ENABLE_TELEPHONE_NUMBER_DETECTION) $(ENABLE_TEXT_AUTOSIZING) $(ENABLE_TOUCH_EVENTS) $(ENABLE_USERSELECT_ALL) $(ENABLE_USER_MESSAGE_HANDLERS) $(ENABLE_V
ARIATION_FONTS) $(ENABLE_VIDEO) $(ENABLE_VIDEO_PRESENTATION_MODE) $(ENABLE_VIDEO_TRACK) $(ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN) $(ENABLE_WEBASSEMBLY) $(ENABLE_WEBASSEMBLY_STREAMING_API) $(ENABLE_WEBDRIVER_MOUSE_INTERACTIONS) $(ENABLE_WEBDRIVER_KEYBOARD_INTERACTIONS) $(ENABLE_WEBDRIVER_TOUCH_INTERACTIONS) $(ENABLE_WEBGL) $(ENABLE_WEBGL2) $(ENABLE_WEBGPU) $(ENABLE_WEB_API_STATISTICS) $(ENABLE_WEB_AUDIO) $(ENABLE_WEB_AUTHN) $(ENABLE_WEB_CRYPTO) $(ENABLE_WEB_RTC) $(ENABLE_WIRELESS_PLAYBACK_TARGET) $(ENABLE_XSLT);
+FEATURE_DEFINES = $(ENABLE_3D_TRANSFORMS) $(ENABLE_ACCELERATED_2D_CANVAS) $(ENABLE_ACCESSIBILITY_ISOLATED_TREE) $(ENABLE_APPLE_PAY) $(ENABLE_APPLE_PAY_SESSION_V3) $(ENABLE_APPLE_PAY_SESSION_V4) $(ENABLE_APPLICATION_MANIFEST) $(ENABLE_ATTACHMENT_ELEMENT) $(ENABLE_AVF_CAPTIONS) $(ENABLE_CACHE_PARTITIONING) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CONTENT_FILTERING) $(ENABLE_CSS3_TEXT) $(ENABLE_CSS_BOX_DECORATION_BREAK) $(ENABLE_CSS_COMPOSITING) $(ENABLE_CSS_CONIC_GRADIENTS) $(ENABLE_CSS_DEVICE_ADAPTATION) $(ENABLE_CSS_IMAGE_RESOLUTION) $(ENABLE_CSS_PAINTING_API) $(ENABLE_CSS_SCROLL_SNAP) $(ENABLE_CSS_SELECTORS_LEVEL4) $(ENABLE_CSS_TRAILING_WORD) $(ENABLE_CSS_TYPED_OM) $(ENABLE_CURSOR_VISIBILITY) $(ENABLE_CUSTOM_SCHEME_HANDLER) $(ENABLE_C_LOOP) $(ENABLE_DARK_MODE_CSS) $(ENABLE_DATACUE_VALUE) $(ENABLE_DATALIST_ELEMENT) $(ENABLE_DATA_INTERACTION) $(ENABLE_DEVICE_ORIENTATION) $(ENABLE_DRAG_SUPPORT) $(ENABLE_ENCRYPTED_MEDIA) $(ENABLE_EXPERIMENTAL_FEATURES) $(ENABLE_FAST_JIT_PERMISSI
ONS) $(ENABLE_FILTERS_LEVEL_2) $(ENABLE_FTL_JIT) $(ENABLE_FULLSCREEN_API) $(ENABLE_PICTURE_IN_PICTURE_API) $(ENABLE_GAMEPAD) $(ENABLE_GEOLOCATION) $(ENABLE_GPU_PROCESS) $(ENABLE_INDEXED_DATABASE) $(ENABLE_INDEXED_DATABASE_IN_WORKERS) $(ENABLE_INPUT_TYPE_COLOR) $(ENABLE_INPUT_TYPE_DATE) $(ENABLE_INPUT_TYPE_DATETIMELOCAL) $(ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE) $(ENABLE_INPUT_TYPE_MONTH) $(ENABLE_INPUT_TYPE_TIME) $(ENABLE_INPUT_TYPE_WEEK) $(ENABLE_INSPECTOR_ALTERNATE_DISPATCHERS) $(ENABLE_INSPECTOR_TELEMETRY) $(ENABLE_INTERSECTION_OBSERVER) $(ENABLE_INTL) $(ENABLE_IOS_GESTURE_EVENTS) $(ENABLE_IOS_TOUCH_EVENTS) $(ENABLE_JIT) $(ENABLE_LAYOUT_FORMATTING_CONTEXT) $(ENABLE_LEGACY_CSS_VENDOR_PREFIXES) $(ENABLE_LEGACY_CUSTOM_PROTOCOL_MANAGER) $(ENABLE_LEGACY_ENCRYPTED_MEDIA) $(ENABLE_LETTERPRESS) $(ENABLE_MAC_GESTURE_EVENTS) $(ENABLE_MAC_VIDEO_TOOLBOX) $(ENABLE_MATHML) $(ENABLE_MEDIA_CAPTURE) $(ENABLE_MEDIA_CONTROLS_SCRIPT) $(ENABLE_MEDIA_SESSION) $(ENABLE_MEDIA_SOURCE) $(ENABLE_MEDIA_STATI
STICS) $(ENABLE_MEDIA_STREAM) $(ENABLE_MEMORY_SAMPLER) $(ENABLE_METER_ELEMENT) $(ENABLE_MHTML) $(ENABLE_MOUSE_CURSOR_SCALE) $(ENABLE_NAVIGATOR_STANDALONE) $(ENABLE_NETWORK_CACHE_SPECULATIVE_REVALIDATION) $(ENABLE_NOTIFICATIONS) $(ENABLE_OFFSCREEN_CANVAS) $(ENABLE_OVERFLOW_SCROLLING_TOUCH) $(ENABLE_PAYMENT_REQUEST) $(ENABLE_PDFKIT_PLUGIN) $(ENABLE_POINTER_EVENTS) $(ENABLE_POINTER_LOCK) $(ENABLE_PUBLIC_SUFFIX_LIST) $(ENABLE_QUOTA) $(ENABLE_REMOTE_INSPECTOR) $(ENABLE_RESIZE_OBSERVER) $(ENABLE_RESOLUTION_MEDIA_QUERY) $(ENABLE_RESOURCE_LOAD_STATISTICS) $(ENABLE_RESOURCE_USAGE) $(ENABLE_RUBBER_BANDING) $(ENABLE_SANDBOX_EXTENSIONS) $(ENABLE_SERVER_PRECONNECT) $(ENABLE_SERVICE_CONTROLS) $(ENABLE_SERVICE_WORKER) $(ENABLE_SHAREABLE_RESOURCE) $(ENABLE_SPEECH_SYNTHESIS) $(ENABLE_STREAMS_API) $(ENABLE_SVG_FONTS) $(ENABLE_TELEPHONE_NUMBER_DETECTION) $(ENABLE_TEXT_AUTOSIZING) $(ENABLE_TOUCH_EVENTS) $(ENABLE_USERSELECT_ALL) $(ENABLE_USER_MESSAGE_HANDLERS) $(ENABLE_VARIATION_FONTS) $(ENABLE_VIDEO) $
(ENABLE_VIDEO_PRESENTATION_MODE) $(ENABLE_VIDEO_TRACK) $(ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN) $(ENABLE_WEBASSEMBLY) $(ENABLE_WEBASSEMBLY_STREAMING_API) $(ENABLE_WEBDRIVER_MOUSE_INTERACTIONS) $(ENABLE_WEBDRIVER_KEYBOARD_INTERACTIONS) $(ENABLE_WEBDRIVER_TOUCH_INTERACTIONS) $(ENABLE_WEBGL) $(ENABLE_WEBGL2) $(ENABLE_WEBGPU) $(ENABLE_WEB_API_STATISTICS) $(ENABLE_WEB_AUDIO) $(ENABLE_WEB_AUTHN) $(ENABLE_WEB_CRYPTO) $(ENABLE_WEB_RTC) $(ENABLE_WIRELESS_PLAYBACK_TARGET) $(ENABLE_XSLT);
