Title: [254196] trunk/Tools
- Revision
- 254196
- Author
- [email protected]
- Date
- 2020-01-08 06:07:49 -0800 (Wed, 08 Jan 2020)
Log Message
Allow multiple cmakeargs inside inside envvar
https://bugs.webkit.org/show_bug.cgi?id=205722
Patch by Paulo Matos <[email protected]> on 2020-01-08
Reviewed by Carlos Alberto Lopez Perez.
Allow sub-argument lists to be passed in a build environment variable.
* Scripts/build-jsc:
* Scripts/build-webkit:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (254195 => 254196)
--- trunk/Tools/ChangeLog 2020-01-08 13:48:20 UTC (rev 254195)
+++ trunk/Tools/ChangeLog 2020-01-08 14:07:49 UTC (rev 254196)
@@ -1,3 +1,15 @@
+2020-01-08 Paulo Matos <[email protected]>
+
+ Allow multiple cmakeargs inside inside envvar
+ https://bugs.webkit.org/show_bug.cgi?id=205722
+
+ Reviewed by Carlos Alberto Lopez Perez.
+
+ Allow sub-argument lists to be passed in a build environment variable.
+
+ * Scripts/build-jsc:
+ * Scripts/build-webkit:
+
2020-01-07 Saam Barati <[email protected]>
run-jsc should not print "... I should not be here ..." when it doesn't get killed when sending a signal to itself
Modified: trunk/Tools/Scripts/build-jsc (254195 => 254196)
--- trunk/Tools/Scripts/build-jsc 2020-01-08 13:48:20 UTC (rev 254195)
+++ trunk/Tools/Scripts/build-jsc 2020-01-08 14:07:49 UTC (rev 254196)
@@ -36,6 +36,7 @@
use webkitdirs;
use webkitperl::FeatureList qw(getFeatureOptionList);
use POSIX;
+use Text::ParseWords;
sub writeCongrats();
@@ -69,7 +70,7 @@
}
# Additional environment parameters
-push @ARGV, split(/ /, $ENV{'BUILD_JSC_ARGS'}) if ($ENV{'BUILD_JSC_ARGS'});
+push @ARGV, parse_line('\s+', 0, $ENV{'BUILD_JSC_ARGS'}) if ($ENV{'BUILD_JSC_ARGS'});
my $programName = basename($0);
my $usage = <<EOF;
Modified: trunk/Tools/Scripts/build-webkit (254195 => 254196)
--- trunk/Tools/Scripts/build-webkit 2020-01-08 13:48:20 UTC (rev 254195)
+++ trunk/Tools/Scripts/build-webkit 2020-01-08 14:07:49 UTC (rev 254196)
@@ -44,6 +44,7 @@
use List::Util qw(first);
use webkitperl::FeatureList qw(getFeatureOptionList);
use POSIX;
+use Text::ParseWords;
sub writeCongrats();
@@ -82,7 +83,7 @@
my @features = getFeatureOptionList();
# Additional environment parameters
-push @ARGV, split(/ /, $ENV{'BUILD_WEBKIT_ARGS'}) if ($ENV{'BUILD_WEBKIT_ARGS'});
+push @ARGV, parse_line('\s+', 0, $ENV{'BUILD_WEBKIT_ARGS'}) if ($ENV{'BUILD_WEBKIT_ARGS'});
# Initialize values from defaults
foreach (@ARGV) {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
