Title: [254208] trunk/Source/WebKit
- Revision
- 254208
- Author
- [email protected]
- Date
- 2020-01-08 11:26:04 -0800 (Wed, 08 Jan 2020)
Log Message
IPC::Connection::sendMessage() should use CRASH_WITH_INFO()
<https://webkit.org/b/205419>
<rdar://problem/58058661>
Reviewed by Mark Lam.
* Platform/IPC/cocoa/ConnectionCocoa.mm:
(IPC::Connection::sendMessage):
- Switch from CRASH() to CRASH_WITH_INFO().
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (254207 => 254208)
--- trunk/Source/WebKit/ChangeLog 2020-01-08 19:15:04 UTC (rev 254207)
+++ trunk/Source/WebKit/ChangeLog 2020-01-08 19:26:04 UTC (rev 254208)
@@ -1,3 +1,15 @@
+2020-01-08 David Kilzer <[email protected]>
+
+ IPC::Connection::sendMessage() should use CRASH_WITH_INFO()
+ <https://webkit.org/b/205419>
+ <rdar://problem/58058661>
+
+ Reviewed by Mark Lam.
+
+ * Platform/IPC/cocoa/ConnectionCocoa.mm:
+ (IPC::Connection::sendMessage):
+ - Switch from CRASH() to CRASH_WITH_INFO().
+
2020-01-08 Truitt Savell <[email protected]>
Unreviewed, rolling out r254174.
Modified: trunk/Source/WebKit/Platform/IPC/cocoa/ConnectionCocoa.mm (254207 => 254208)
--- trunk/Source/WebKit/Platform/IPC/cocoa/ConnectionCocoa.mm 2020-01-08 19:15:04 UTC (rev 254207)
+++ trunk/Source/WebKit/Platform/IPC/cocoa/ConnectionCocoa.mm 2020-01-08 19:26:04 UTC (rev 254208)
@@ -39,6 +39,7 @@
#import <wtf/MachSendRight.h>
#import <wtf/RunLoop.h>
#import <wtf/spi/darwin/XPCSPI.h>
+#import <wtf/text/StringConcatenate.h>
#if PLATFORM(IOS_FAMILY)
#import "ProcessAssertion.h"
@@ -272,8 +273,9 @@
return false;
default:
- WebKit::setCrashReportApplicationSpecificInformation((__bridge CFStringRef)[NSString stringWithFormat:@"Unhandled error code %x, message '%s::%s'", kr, message->messageReceiverName().data(), message->messageName().data()]);
- CRASH();
+ CString messageName = makeString(message->messageReceiverName().data(), "::", message->messageName().data()).utf8();
+ WebKit::setCrashReportApplicationSpecificInformation((__bridge CFStringRef)[NSString stringWithFormat:@"Unhandled error code %x, message '%s', hash %d", kr, messageName.data(), messageName.hash()]);
+ CRASH_WITH_INFO(kr, messageName.hash());
}
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
