Title: [254292] trunk/Source/WebKit
- Revision
- 254292
- Author
- [email protected]
- Date
- 2020-01-09 13:10:17 -0800 (Thu, 09 Jan 2020)
Log Message
Set the title for images so it will be correctly displayed in UIContextMenus
https://bugs.webkit.org/show_bug.cgi?id=205980
<rdar://problem/57701988>
Reviewed by Dean Jackson.
Need to set the title text for images.
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView continueContextMenuInteraction:]):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (254291 => 254292)
--- trunk/Source/WebKit/ChangeLog 2020-01-09 20:52:33 UTC (rev 254291)
+++ trunk/Source/WebKit/ChangeLog 2020-01-09 21:10:17 UTC (rev 254292)
@@ -1,3 +1,16 @@
+2020-01-09 Megan Gardner <[email protected]>
+
+ Set the title for images so it will be correctly displayed in UIContextMenus
+ https://bugs.webkit.org/show_bug.cgi?id=205980
+ <rdar://problem/57701988>
+
+ Reviewed by Dean Jackson.
+
+ Need to set the title text for images.
+
+ * UIProcess/ios/WKContentViewInteraction.mm:
+ (-[WKContentView continueContextMenuInteraction:]):
+
2020-01-09 Peng Liu <[email protected]>
Fullscreen videos do not enter PiP in first tap
Modified: trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (254291 => 254292)
--- trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2020-01-09 20:52:33 UTC (rev 254291)
+++ trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2020-01-09 21:10:17 UTC (rev 254292)
@@ -8480,7 +8480,7 @@
RetainPtr<NSArray<_WKElementAction *>> defaultActionsFromAssistant = [strongSelf->_actionSheetAssistant defaultActionsForImageSheet:elementInfo.get()];
auto actions = menuElementsFromDefaultActions(defaultActionsFromAssistant, elementInfo);
- return [UIMenu menuWithTitle:@"" children:actions];
+ return [UIMenu menuWithTitle:strongSelf->_positionInformation.title children:actions];
};
UIContextMenuContentPreviewProvider contentPreviewProvider = [weakSelf, cgImage, elementInfo] () -> UIViewController * {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
