Title: [254301] trunk
- Revision
- 254301
- Author
- [email protected]
- Date
- 2020-01-09 14:41:28 -0800 (Thu, 09 Jan 2020)
Log Message
REGRESSION (r253662): Large Data URLs are not being handled properly
https://bugs.webkit.org/show_bug.cgi?id=205979
<rdar://problem/58346124>
Reviewed by Youenn Fablet.
Source/WebCore:
The URL size limitation added in r253662 was too low. We should bump it to handle
reasonable data URI sizes.
Test: fast/url/data-url-large.html.
* page/SecurityOrigin.cpp:
LayoutTests:
* fast/url/data-url-large-expected.txt: Added.
* fast/url/data-url-large.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (254300 => 254301)
--- trunk/LayoutTests/ChangeLog 2020-01-09 22:38:13 UTC (rev 254300)
+++ trunk/LayoutTests/ChangeLog 2020-01-09 22:41:28 UTC (rev 254301)
@@ -1,3 +1,14 @@
+2020-01-09 Brent Fulgham <[email protected]>
+
+ REGRESSION (r253662): Large Data URLs are not being handled properly
+ https://bugs.webkit.org/show_bug.cgi?id=205979
+ <rdar://problem/58346124>
+
+ Reviewed by Youenn Fablet.
+
+ * fast/url/data-url-large-expected.txt: Added.
+ * fast/url/data-url-large.html: Added.
+
2020-01-09 John Wilander <[email protected]>
Resource Load Statistics: Add timing information to WebPageProxy::logFrameNavigation() to detect delayed client-side redirects
Added: trunk/LayoutTests/fast/url/data-url-large-expected.txt (0 => 254301)
--- trunk/LayoutTests/fast/url/data-url-large-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/url/data-url-large-expected.txt 2020-01-09 22:41:28 UTC (rev 254301)
@@ -0,0 +1,5 @@
+PASS Large URL handled properly.
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/fast/url/data-url-large.html (0 => 254301)
--- trunk/LayoutTests/fast/url/data-url-large.html (rev 0)
+++ trunk/LayoutTests/fast/url/data-url-large.html 2020-01-09 22:41:28 UTC (rev 254301)
@@ -0,0 +1,22 @@
+<!DOCTYPE html>
+<html>
+<body>
+<script src=""
+<script>
+jsTestIsAsync = true;
+const url = "" + "q".repeat(32535);
+
+const xhr = new XMLHttpRequest();
+xhr._onload_ = function() {
+ testPassed("Large URL handled properly.");
+ finishJSTest();
+}
+xhr._onerror_ = function() {
+ testFailed("Large URL was improperly rejected.");
+ finishJSTest();
+}
+xhr.open("GET", url);
+xhr.send();
+</script>
+</body>
+</html>
Modified: trunk/Source/WebCore/ChangeLog (254300 => 254301)
--- trunk/Source/WebCore/ChangeLog 2020-01-09 22:38:13 UTC (rev 254300)
+++ trunk/Source/WebCore/ChangeLog 2020-01-09 22:41:28 UTC (rev 254301)
@@ -1,3 +1,18 @@
+2020-01-09 Brent Fulgham <[email protected]>
+
+ REGRESSION (r253662): Large Data URLs are not being handled properly
+ https://bugs.webkit.org/show_bug.cgi?id=205979
+ <rdar://problem/58346124>
+
+ Reviewed by Youenn Fablet.
+
+ The URL size limitation added in r253662 was too low. We should bump it to handle
+ reasonable data URI sizes.
+
+ Test: fast/url/data-url-large.html.
+
+ * page/SecurityOrigin.cpp:
+
2020-01-09 Eamon Sisk <[email protected]>
Update status for Web SQL Database
Modified: trunk/Source/WebCore/page/SecurityOrigin.cpp (254300 => 254301)
--- trunk/Source/WebCore/page/SecurityOrigin.cpp 2020-01-09 22:38:13 UTC (rev 254300)
+++ trunk/Source/WebCore/page/SecurityOrigin.cpp 2020-01-09 22:41:28 UTC (rev 254301)
@@ -46,7 +46,7 @@
namespace WebCore {
-constexpr unsigned maximumURLSize = 0x8000;
+constexpr unsigned maximumURLSize = 0x04000000;
static bool schemeRequiresHost(const URL& url)
{
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
