[webkit-changes] [254362] branches/safari-609-branch

Fri, 10 Jan 2020 12:34:07 -0800

Title: [254362] branches/safari-609-branch

Diff

Modified: branches/safari-609-branch/LayoutTests/ChangeLog (254361 => 254362)


--- branches/safari-609-branch/LayoutTests/ChangeLog	2020-01-10 19:56:52 UTC (rev 254361)
+++ branches/safari-609-branch/LayoutTests/ChangeLog	2020-01-10 20:32:31 UTC (rev 254362)
@@ -1,3 +1,41 @@
+2020-01-09  Alan Coon  <[email protected]>
+
+        Cherry-pick r254301. rdar://problem/58346124
+
+    REGRESSION (r253662): Large Data URLs are not being handled properly
+    https://bugs.webkit.org/show_bug.cgi?id=205979
+    <rdar://problem/58346124>
+    
+    Reviewed by Youenn Fablet.
+    
+    Source/WebCore:
+    
+    The URL size limitation added in r253662 was too low. We should bump it to handle
+    reasonable data URI sizes.
+    
+    Test: fast/url/data-url-large.html.
+    
+    * page/SecurityOrigin.cpp:
+    
+    LayoutTests:
+    
+    * fast/url/data-url-large-expected.txt: Added.
+    * fast/url/data-url-large.html: Added.
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254301 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2020-01-09  Brent Fulgham  <[email protected]>
+
+            REGRESSION (r253662): Large Data URLs are not being handled properly
+            https://bugs.webkit.org/show_bug.cgi?id=205979
+            <rdar://problem/58346124>
+
+            Reviewed by Youenn Fablet.
+
+            * fast/url/data-url-large-expected.txt: Added.
+            * fast/url/data-url-large.html: Added.
+
 2020-01-07  Alan Coon  <[email protected]>
 
         Cherry-pick r254111. rdar://problem/58093690

Added: branches/safari-609-branch/LayoutTests/fast/url/data-url-large-expected.txt (0 => 254362)


--- branches/safari-609-branch/LayoutTests/fast/url/data-url-large-expected.txt	                        (rev 0)
+++ branches/safari-609-branch/LayoutTests/fast/url/data-url-large-expected.txt	2020-01-10 20:32:31 UTC (rev 254362)
@@ -0,0 +1,5 @@
+PASS Large URL handled properly.
+PASS successfullyParsed is true
+
+TEST COMPLETE
+

Added: branches/safari-609-branch/LayoutTests/fast/url/data-url-large.html (0 => 254362)


--- branches/safari-609-branch/LayoutTests/fast/url/data-url-large.html	                        (rev 0)
+++ branches/safari-609-branch/LayoutTests/fast/url/data-url-large.html	2020-01-10 20:32:31 UTC (rev 254362)
@@ -0,0 +1,22 @@
+<!DOCTYPE html>
+<html>
+<body>
+<script src=""
+<script>
+jsTestIsAsync = true;
+const url = "" + "q".repeat(32535);
+
+const xhr = new XMLHttpRequest();
+xhr._onload_ = function() {
+    testPassed("Large URL handled properly.");
+    finishJSTest();
+}
+xhr._onerror_ = function() {
+    testFailed("Large URL was improperly rejected.");
+    finishJSTest();
+}
+xhr.open("GET", url);
+xhr.send();
+</script>
+</body>
+</html>

Modified: branches/safari-609-branch/Source/WebCore/ChangeLog (254361 => 254362)


--- branches/safari-609-branch/Source/WebCore/ChangeLog	2020-01-10 19:56:52 UTC (rev 254361)
+++ branches/safari-609-branch/Source/WebCore/ChangeLog	2020-01-10 20:32:31 UTC (rev 254362)
@@ -1,3 +1,45 @@
+2020-01-09  Alan Coon  <[email protected]>
+
+        Cherry-pick r254301. rdar://problem/58346124
+
+    REGRESSION (r253662): Large Data URLs are not being handled properly
+    https://bugs.webkit.org/show_bug.cgi?id=205979
+    <rdar://problem/58346124>
+    
+    Reviewed by Youenn Fablet.
+    
+    Source/WebCore:
+    
+    The URL size limitation added in r253662 was too low. We should bump it to handle
+    reasonable data URI sizes.
+    
+    Test: fast/url/data-url-large.html.
+    
+    * page/SecurityOrigin.cpp:
+    
+    LayoutTests:
+    
+    * fast/url/data-url-large-expected.txt: Added.
+    * fast/url/data-url-large.html: Added.
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254301 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2020-01-09  Brent Fulgham  <[email protected]>
+
+            REGRESSION (r253662): Large Data URLs are not being handled properly
+            https://bugs.webkit.org/show_bug.cgi?id=205979
+            <rdar://problem/58346124>
+
+            Reviewed by Youenn Fablet.
+
+            The URL size limitation added in r253662 was too low. We should bump it to handle
+            reasonable data URI sizes.
+
+            Test: fast/url/data-url-large.html.
+
+            * page/SecurityOrigin.cpp:
+
 2020-01-03  Sihui Liu  <[email protected]>
 
         Crash in com.apple.WebKit.Networking at UniqueIDBDatabase::performCurrentOpenOperation

Modified: branches/safari-609-branch/Source/WebCore/page/SecurityOrigin.cpp (254361 => 254362)


--- branches/safari-609-branch/Source/WebCore/page/SecurityOrigin.cpp	2020-01-10 19:56:52 UTC (rev 254361)
+++ branches/safari-609-branch/Source/WebCore/page/SecurityOrigin.cpp	2020-01-10 20:32:31 UTC (rev 254362)
@@ -46,7 +46,7 @@
 
 namespace WebCore {
 
-constexpr unsigned maximumURLSize = 0x8000;
+constexpr unsigned maximumURLSize = 0x04000000;
 
 static bool schemeRequiresHost(const URL& url)
 {

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to