Title: [254366] trunk
Revision
254366
Author
[email protected]
Date
2020-01-10 14:21:43 -0800 (Fri, 10 Jan 2020)

Log Message

[iOS] Remove 'com.apple.powerlog.plxpclogger.xpc' from the WebContent process sandbox
https://bugs.webkit.org/show_bug.cgi?id=206086
<rdar://problem/57195681>

Reviewed by Per Arne Vollan.

Source/WebKit:

Telemetry and testing have confirmed that we no longer need a mach connection to the
'com.apple.powerlog.plxpclogger.xpc' service. We should remove it from the WebContent process sandbox.

Test: fast/sandbox/ios/sandbox-mach-lookup.html

* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

LayoutTests:

* fast/sandbox/ios/sandbox-mach-lookup-expected.txt:
* fast/sandbox/ios/sandbox-mach-lookup.html:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (254365 => 254366)


--- trunk/LayoutTests/ChangeLog	2020-01-10 22:17:17 UTC (rev 254365)
+++ trunk/LayoutTests/ChangeLog	2020-01-10 22:21:43 UTC (rev 254366)
@@ -1,5 +1,16 @@
 2020-01-10  Brent Fulgham  <[email protected]>
 
+        [iOS] Remove 'com.apple.powerlog.plxpclogger.xpc' from the WebContent process sandbox
+        https://bugs.webkit.org/show_bug.cgi?id=206086
+        <rdar://problem/57195681>
+
+        Reviewed by Per Arne Vollan.
+
+        * fast/sandbox/ios/sandbox-mach-lookup-expected.txt:
+        * fast/sandbox/ios/sandbox-mach-lookup.html:
+
+2020-01-10  Brent Fulgham  <[email protected]>
+
         Remove 'com.apple.iohideventsystem' from the WebContent process sandbox
         https://bugs.webkit.org/show_bug.cgi?id=206085
         <rdar://problem/36085204>

Modified: trunk/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup-expected.txt (254365 => 254366)


--- trunk/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup-expected.txt	2020-01-10 22:17:17 UTC (rev 254365)
+++ trunk/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup-expected.txt	2020-01-10 22:21:43 UTC (rev 254366)
@@ -13,5 +13,6 @@
 PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.nesessionmanager") is false
 PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.nesessionmanager.content-filter") is false
 PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.pluginkit.pkd") is false
+PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.powerlog.plxpclogger.xpc") is false
 PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.system.logger") is false
 

Modified: trunk/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup.html (254365 => 254366)


--- trunk/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup.html	2020-01-10 22:17:17 UTC (rev 254365)
+++ trunk/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup.html	2020-01-10 22:21:43 UTC (rev 254366)
@@ -16,6 +16,7 @@
     shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.nesessionmanager\")");
     shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.nesessionmanager.content-filter\")");
     shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.pluginkit.pkd\")");
+    shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.powerlog.plxpclogger.xpc\")");
     shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.system.logger\")");
 }
 </script>

Modified: trunk/Source/WebKit/ChangeLog (254365 => 254366)


--- trunk/Source/WebKit/ChangeLog	2020-01-10 22:17:17 UTC (rev 254365)
+++ trunk/Source/WebKit/ChangeLog	2020-01-10 22:21:43 UTC (rev 254366)
@@ -1,5 +1,20 @@
 2020-01-10  Brent Fulgham  <[email protected]>
 
+        [iOS] Remove 'com.apple.powerlog.plxpclogger.xpc' from the WebContent process sandbox
+        https://bugs.webkit.org/show_bug.cgi?id=206086
+        <rdar://problem/57195681>
+
+        Reviewed by Per Arne Vollan.
+
+        Telemetry and testing have confirmed that we no longer need a mach connection to the
+        'com.apple.powerlog.plxpclogger.xpc' service. We should remove it from the WebContent process sandbox.
+
+        Test: fast/sandbox/ios/sandbox-mach-lookup.html
+
+        * Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
+
+2020-01-10  Brent Fulgham  <[email protected]>
+
         Remove 'com.apple.iohideventsystem' from the WebContent process sandbox
         https://bugs.webkit.org/show_bug.cgi?id=206085
         <rdar://problem/36085204>

Modified: trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb (254365 => 254366)


--- trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb	2020-01-10 22:17:17 UTC (rev 254365)
+++ trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb	2020-01-10 22:21:43 UTC (rev 254366)
@@ -742,10 +742,6 @@
 (allow file-read*
     (home-subpath "/Library/Caches/com.apple.keyboards"))
 
-;; Power logging
-(allow mach-lookup (with report) (with telemetry)
-    (global-name "com.apple.powerlog.plxpclogger.xpc")) ;;  <rdar://problem/36442803>
-
 (mobile-preferences-read
     "com.apple.EmojiPreferences"
     ; <rdar://problem/8477596> com.apple.InputModePreferences
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to