Title: [254407] trunk/Source/WebCore
- Revision
- 254407
- Author
- [email protected]
- Date
- 2020-01-11 16:49:34 -0800 (Sat, 11 Jan 2020)
Log Message
[LFC] isOkToAccessDisplayBox should return false on formatting context root access.
https://bugs.webkit.org/show_bug.cgi?id=206123
<rdar://problem/58500267>
Reviewed by Antti Koivisto.
>From now on any geometry access outside of the formatting context without a valid reason is considered an escape.
* layout/FormattingContext.cpp:
(WebCore::Layout::FormattingContext::geometryForBox const):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (254406 => 254407)
--- trunk/Source/WebCore/ChangeLog 2020-01-12 00:29:34 UTC (rev 254406)
+++ trunk/Source/WebCore/ChangeLog 2020-01-12 00:49:34 UTC (rev 254407)
@@ -1,3 +1,16 @@
+2020-01-11 Zalan Bujtas <[email protected]>
+
+ [LFC] isOkToAccessDisplayBox should return false on formatting context root access.
+ https://bugs.webkit.org/show_bug.cgi?id=206123
+ <rdar://problem/58500267>
+
+ Reviewed by Antti Koivisto.
+
+ From now on any geometry access outside of the formatting context without a valid reason is considered an escape.
+
+ * layout/FormattingContext.cpp:
+ (WebCore::Layout::FormattingContext::geometryForBox const):
+
2020-01-11 Noam Rosenthal <[email protected]>
Support image-set() standard syntax
Modified: trunk/Source/WebCore/layout/FormattingContext.cpp (254406 => 254407)
--- trunk/Source/WebCore/layout/FormattingContext.cpp 2020-01-12 00:29:34 UTC (rev 254406)
+++ trunk/Source/WebCore/layout/FormattingContext.cpp 2020-01-12 00:49:34 UTC (rev 254407)
@@ -221,14 +221,8 @@
return true;
}
- if (&layoutBox == &root()) {
- // FIXME: This is formatting context escaping in the strict sense, since the formatting context root box lives in the parent formatting context.
- // This happens e.g. when a block level box box needs to stretch horizontally and checks its containing block for horizontal space (this should probably be limited to reading horizontal constraint values).
- return true;
- }
-
if (!escapeReason) {
- // At this point any access is considered an escape.
+ // Any geometry access outside of the formatting context without a valid reason is considered an escape.
return false;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
