Title: [254431] trunk
Revision
254431
Author
[email protected]
Date
2020-01-13 08:09:24 -0800 (Mon, 13 Jan 2020)

Log Message

[LFC][Integration] editing/text-iterator/findString.html fails on iOS
https://bugs.webkit.org/show_bug.cgi?id=206164

Reviewed by Zalan Bujtas.

Source/WebCore:

* rendering/line/LineLayoutTraversalDisplayRunPath.h:
(WebCore::LineLayoutTraversal::DisplayRunPath::isLastOnLine const):

The test here was reversed.

LayoutTests:

* platform/ios/TestExpectations:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (254430 => 254431)


--- trunk/LayoutTests/ChangeLog	2020-01-13 16:02:51 UTC (rev 254430)
+++ trunk/LayoutTests/ChangeLog	2020-01-13 16:09:24 UTC (rev 254431)
@@ -1,5 +1,14 @@
 2020-01-13  Antti Koivisto  <[email protected]>
 
+        [LFC][Integration] editing/text-iterator/findString.html fails on iOS
+        https://bugs.webkit.org/show_bug.cgi?id=206164
+
+        Reviewed by Zalan Bujtas.
+
+        * platform/ios/TestExpectations:
+
+2020-01-13  Antti Koivisto  <[email protected]>
+
         [iOS] Unreviewed test gardening after r254428.
 
         * platform/ios/css1/text_properties/letter_spacing-expected.txt:

Modified: trunk/LayoutTests/platform/ios/TestExpectations (254430 => 254431)


--- trunk/LayoutTests/platform/ios/TestExpectations	2020-01-13 16:02:51 UTC (rev 254430)
+++ trunk/LayoutTests/platform/ios/TestExpectations	2020-01-13 16:09:24 UTC (rev 254431)
@@ -3462,5 +3462,3 @@
 webkit.org/b/205309 scrollingcoordinator/ios/scroll-position-after-reattach.html [ ImageOnlyFailure ]
 
 webkit.org/b/200043 fast/text/international/system-language/navigator-language [ Pass Failure ]
-
-webkit.org/b/206164 editing/text-iterator/findString.html [ Failure ]

Modified: trunk/Source/WebCore/ChangeLog (254430 => 254431)


--- trunk/Source/WebCore/ChangeLog	2020-01-13 16:02:51 UTC (rev 254430)
+++ trunk/Source/WebCore/ChangeLog	2020-01-13 16:09:24 UTC (rev 254431)
@@ -1,5 +1,17 @@
 2020-01-13  Antti Koivisto  <[email protected]>
 
+        [LFC][Integration] editing/text-iterator/findString.html fails on iOS
+        https://bugs.webkit.org/show_bug.cgi?id=206164
+
+        Reviewed by Zalan Bujtas.
+
+        * rendering/line/LineLayoutTraversalDisplayRunPath.h:
+        (WebCore::LineLayoutTraversal::DisplayRunPath::isLastOnLine const):
+
+        The test here was reversed.
+
+2020-01-13  Antti Koivisto  <[email protected]>
+
         [LFC][Integration] Enable LFC integration
         https://bugs.webkit.org/show_bug.cgi?id=206128
 

Modified: trunk/Source/WebCore/rendering/line/LineLayoutTraversalDisplayRunPath.h (254430 => 254431)


--- trunk/Source/WebCore/rendering/line/LineLayoutTraversalDisplayRunPath.h	2020-01-13 16:02:51 UTC (rev 254430)
+++ trunk/Source/WebCore/rendering/line/LineLayoutTraversalDisplayRunPath.h	2020-01-13 16:09:24 UTC (rev 254431)
@@ -84,7 +84,7 @@
         if (isLast())
             return true;
         auto& next = runs()[m_runIndex + 1];
-        return run().lineIndex() == next.lineIndex();
+        return run().lineIndex() != next.lineIndex();
     }
     bool isLast() const
     {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to