Title: [254485] trunk/Source/WebInspectorUI
- Revision
- 254485
- Author
- [email protected]
- Date
- 2020-01-13 19:44:30 -0800 (Mon, 13 Jan 2020)
Log Message
Web Inspector: "Enable Local Override" and "Delete Local Override" are displayed twice in the contextual menu
https://bugs.webkit.org/show_bug.cgi?id=206184
<rdar://problem/58409880>
Reviewed by Brian Burg.
* UserInterface/Views/ContextMenuUtilities.js:
(WI.appendContextMenuItemsForSourceCode):
* UserInterface/Views/LocalResourceOverrideTreeElement.js:
(WI.LocalResourceOverrideTreeElement.prototype.populateContextMenu):
Add an expando flag that can be set by `WI.LocalResourceOverrideTreeElement` to ensure that
the local override context menu items aren't added again by `WI.ResourceTreeElement`.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (254484 => 254485)
--- trunk/Source/WebInspectorUI/ChangeLog 2020-01-14 03:28:33 UTC (rev 254484)
+++ trunk/Source/WebInspectorUI/ChangeLog 2020-01-14 03:44:30 UTC (rev 254485)
@@ -1,3 +1,18 @@
+2020-01-13 Devin Rousso <[email protected]>
+
+ Web Inspector: "Enable Local Override" and "Delete Local Override" are displayed twice in the contextual menu
+ https://bugs.webkit.org/show_bug.cgi?id=206184
+ <rdar://problem/58409880>
+
+ Reviewed by Brian Burg.
+
+ * UserInterface/Views/ContextMenuUtilities.js:
+ (WI.appendContextMenuItemsForSourceCode):
+ * UserInterface/Views/LocalResourceOverrideTreeElement.js:
+ (WI.LocalResourceOverrideTreeElement.prototype.populateContextMenu):
+ Add an expando flag that can be set by `WI.LocalResourceOverrideTreeElement` to ensure that
+ the local override context menu items aren't added again by `WI.ResourceTreeElement`.
+
2020-01-09 Nikita Vasilyev <[email protected]>
Web Inspector: suggest "color()" when defining color in CSS value
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ContextMenuUtilities.js (254484 => 254485)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ContextMenuUtilities.js 2020-01-14 03:28:33 UTC (rev 254484)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ContextMenuUtilities.js 2020-01-14 03:44:30 UTC (rev 254485)
@@ -70,7 +70,12 @@
if (!(sourceCode instanceof WI.SourceCode))
return;
- if (WI.NetworkManager.supportsLocalResourceOverrides()) {
+ if (contextMenu.__domBreakpointItemsAdded)
+ return;
+
+ if (!contextMenu.__localOverrideItemsAdded && WI.NetworkManager.supportsLocalResourceOverrides()) {
+ contextMenu.__localOverrideItemsAdded = true;
+
if (WI.networkManager.canBeOverridden(sourceCode)) {
contextMenu.appendSeparator();
contextMenu.appendItem(WI.UIString("Create Local Override"), async () => {
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/LocalResourceOverrideTreeElement.js (254484 => 254485)
--- trunk/Source/WebInspectorUI/UserInterface/Views/LocalResourceOverrideTreeElement.js 2020-01-14 03:28:33 UTC (rev 254484)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/LocalResourceOverrideTreeElement.js 2020-01-14 03:44:30 UTC (rev 254485)
@@ -99,6 +99,8 @@
populateContextMenu(contextMenu, event)
{
+ contextMenu.__localOverrideItemsAdded = true;
+
contextMenu.appendItem(WI.UIString("Edit Local Override\u2026"), (event) => {
let popover = new WI.LocalResourceOverridePopover(this);
popover.show(this._localResourceOverride, this.status, [WI.RectEdge.MAX_X, WI.RectEdge.MIN_X]);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
