Title: [254492] trunk
- Revision
- 254492
- Author
- [email protected]
- Date
- 2020-01-13 21:40:51 -0800 (Mon, 13 Jan 2020)
Log Message
Scrollbar hiding on iOS via ::-webkit-scrollbar { display: none } doesn't work
https://bugs.webkit.org/show_bug.cgi?id=206197
Reviewed by Tim Horton.
Source/WebCore:
The logic added in r251369 was reversed, causing scrollbar hiding to not work correctly.
Tested by fast/scrolling/ios/scrollbar-hiding.html
* rendering/RenderScrollbar.cpp:
(WebCore::RenderScrollbar::isHiddenByStyle const):
LayoutTests:
The logic added in r251369 was reversed, causing scrollbar hiding to not work correctly.
* fast/scrolling/ios/scrollbar-hiding-expected.txt:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (254491 => 254492)
--- trunk/LayoutTests/ChangeLog 2020-01-14 05:24:58 UTC (rev 254491)
+++ trunk/LayoutTests/ChangeLog 2020-01-14 05:40:51 UTC (rev 254492)
@@ -1,3 +1,14 @@
+2020-01-13 Simon Fraser <[email protected]>
+
+ Scrollbar hiding on iOS via ::-webkit-scrollbar { display: none } doesn't work
+ https://bugs.webkit.org/show_bug.cgi?id=206197
+
+ Reviewed by Tim Horton.
+
+ The logic added in r251369 was reversed, causing scrollbar hiding to not work correctly.
+
+ * fast/scrolling/ios/scrollbar-hiding-expected.txt:
+
2020-01-13 Pablo Saavedra <[email protected]>
[GTK] Many imported/w3c/web-platform-tests/html/ tests failing after r253791
Modified: trunk/LayoutTests/fast/scrolling/ios/scrollbar-hiding-expected.txt (254491 => 254492)
--- trunk/LayoutTests/fast/scrolling/ios/scrollbar-hiding-expected.txt 2020-01-14 05:24:58 UTC (rev 254491)
+++ trunk/LayoutTests/fast/scrolling/ios/scrollbar-hiding-expected.txt 2020-01-14 05:40:51 UTC (rev 254492)
@@ -35,9 +35,7 @@
(horizontal scrollbar mode 0)
(vertical scrollbar mode 0)
(has enabled horizontal scrollbar 1)
- (has enabled vertical scrollbar 1)
- (horizontal scrollbar hidden by style 1)
- (vertical scrollbar hidden by style 1)))
+ (has enabled vertical scrollbar 1)))
(overflow scrolling node
(scrollable area size width=200 height=100)
(total content size width=400 height=200)
@@ -49,7 +47,7 @@
(vertical scrollbar mode 0)
(has enabled horizontal scrollbar 1)
(has enabled vertical scrollbar 1)
- (horizontal scrollbar hidden by style 1)))
+ (vertical scrollbar hidden by style 1)))
(overflow scrolling node
(scrollable area size width=200 height=100)
(total content size width=400 height=200)
@@ -61,7 +59,7 @@
(vertical scrollbar mode 0)
(has enabled horizontal scrollbar 1)
(has enabled vertical scrollbar 1)
- (vertical scrollbar hidden by style 1)))
+ (horizontal scrollbar hidden by style 1)))
(overflow scrolling node
(scrollable area size width=200 height=100)
(total content size width=400 height=200)
@@ -72,4 +70,6 @@
(horizontal scrollbar mode 0)
(vertical scrollbar mode 0)
(has enabled horizontal scrollbar 1)
- (has enabled vertical scrollbar 1)))))
+ (has enabled vertical scrollbar 1)
+ (horizontal scrollbar hidden by style 1)
+ (vertical scrollbar hidden by style 1)))))
Modified: trunk/Source/WebCore/ChangeLog (254491 => 254492)
--- trunk/Source/WebCore/ChangeLog 2020-01-14 05:24:58 UTC (rev 254491)
+++ trunk/Source/WebCore/ChangeLog 2020-01-14 05:40:51 UTC (rev 254492)
@@ -1,3 +1,17 @@
+2020-01-13 Simon Fraser <[email protected]>
+
+ Scrollbar hiding on iOS via ::-webkit-scrollbar { display: none } doesn't work
+ https://bugs.webkit.org/show_bug.cgi?id=206197
+
+ Reviewed by Tim Horton.
+
+ The logic added in r251369 was reversed, causing scrollbar hiding to not work correctly.
+
+ Tested by fast/scrolling/ios/scrollbar-hiding.html
+
+ * rendering/RenderScrollbar.cpp:
+ (WebCore::RenderScrollbar::isHiddenByStyle const):
+
2020-01-13 Jer Noble <[email protected]>
[WK1][iOS] VideoFullscreenControllerContext uses UIKit on the WebThread
Modified: trunk/Source/WebCore/rendering/RenderScrollbar.cpp (254491 => 254492)
--- trunk/Source/WebCore/rendering/RenderScrollbar.cpp 2020-01-14 05:24:58 UTC (rev 254491)
+++ trunk/Source/WebCore/rendering/RenderScrollbar.cpp 2020-01-14 05:40:51 UTC (rev 254492)
@@ -363,7 +363,7 @@
bool RenderScrollbar::isHiddenByStyle() const
{
std::unique_ptr<RenderStyle> partStyle = getScrollbarPseudoStyle(ScrollbarBGPart, pseudoForScrollbarPart(ScrollbarBGPart));
- return partStyle && partStyle->display() != DisplayType::None;
+ return partStyle && partStyle->display() == DisplayType::None;
}
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
