Title: [254605] branches/safari-609-branch/LayoutTests
Revision
254605
Author
alanc...@apple.com
Date
2020-01-15 11:15:30 -0800 (Wed, 15 Jan 2020)

Log Message

Cherry-pick r254260. rdar://problem/58552882

    REGRESSION: [ Mac ] webrtc/video-autoplay.html is a flaky failure
    https://bugs.webkit.org/show_bug.cgi?id=205893
    <rdar://problem/58391046>

    Reviewed by Eric Carlson.

    * webrtc/video-autoplay.html:
    Speculative fix as I am not able to reproduce locally.
    Hypothesis is that removing from DOM the video element is supposed to asynchronously pause the video element.
    We should therefore ensure that the video element is paused before calling getUserMedia.

    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

Diff

Modified: branches/safari-609-branch/LayoutTests/ChangeLog (254604 => 254605)


--- branches/safari-609-branch/LayoutTests/ChangeLog	2020-01-15 19:15:27 UTC (rev 254604)
+++ branches/safari-609-branch/LayoutTests/ChangeLog	2020-01-15 19:15:30 UTC (rev 254605)
@@ -1,5 +1,36 @@
 2020-01-14  Alan Coon  <alanc...@apple.com>
 
+        Cherry-pick r254260. rdar://problem/58552882
+
+    REGRESSION: [ Mac ] webrtc/video-autoplay.html is a flaky failure
+    https://bugs.webkit.org/show_bug.cgi?id=205893
+    <rdar://problem/58391046>
+    
+    Reviewed by Eric Carlson.
+    
+    * webrtc/video-autoplay.html:
+    Speculative fix as I am not able to reproduce locally.
+    Hypothesis is that removing from DOM the video element is supposed to asynchronously pause the video element.
+    We should therefore ensure that the video element is paused before calling getUserMedia.
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254260 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2020-01-09  Youenn Fablet  <you...@apple.com>
+
+            REGRESSION: [ Mac ] webrtc/video-autoplay.html is a flaky failure
+            https://bugs.webkit.org/show_bug.cgi?id=205893
+            <rdar://problem/58391046>
+
+            Reviewed by Eric Carlson.
+
+            * webrtc/video-autoplay.html:
+            Speculative fix as I am not able to reproduce locally.
+            Hypothesis is that removing from DOM the video element is supposed to asynchronously pause the video element.
+            We should therefore ensure that the video element is paused before calling getUserMedia.
+
+2020-01-14  Alan Coon  <alanc...@apple.com>
+
         Cherry-pick r254201. rdar://problem/58552859
 
     [Web Animations] Stop creating CSS Animations for <noscript> elements

Modified: branches/safari-609-branch/LayoutTests/webrtc/video-autoplay.html (254604 => 254605)


--- branches/safari-609-branch/LayoutTests/webrtc/video-autoplay.html	2020-01-15 19:15:27 UTC (rev 254604)
+++ branches/safari-609-branch/LayoutTests/webrtc/video-autoplay.html	2020-01-15 19:15:30 UTC (rev 254605)
@@ -102,12 +102,17 @@
     let removedVideo2 = video2;
     removedVideo2.remove();
 
+    let cptr = 0;
+    while (++cptr < 20 && !removedVideo2.paused)
+        await new Promise(resolve => setTimeout(resolve, 50));
+    assert_true(removedVideo2.paused, "out of DOM video should get paused");
+
     video4.srcObject = await navigator.mediaDevices.getUserMedia({ video : true });
 
     while (video4.paused)
         await new Promise(resolve => setTimeout(resolve, 50));
 
-    assert_true(removedVideo2.paused, "out of DOM video");
+    assert_true(removedVideo2.paused, "out of DOM video should not restart after getUserMedia call");
 }, "Granting getUserMedia should not start paused media 2");
 
 promise_test(async (test) => {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to