Title: [254609] branches/safari-609-branch/Source/WebKit
- Revision
- 254609
- Author
- [email protected]
- Date
- 2020-01-15 11:15:40 -0800 (Wed, 15 Jan 2020)
Log Message
Cherry-pick r254292. rdar://problem/58552868
Set the title for images so it will be correctly displayed in UIContextMenus
https://bugs.webkit.org/show_bug.cgi?id=205980
<rdar://problem/57701988>
Reviewed by Dean Jackson.
Need to set the title text for images.
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView continueContextMenuInteraction:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254292 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
Diff
Modified: branches/safari-609-branch/Source/WebKit/ChangeLog (254608 => 254609)
--- branches/safari-609-branch/Source/WebKit/ChangeLog 2020-01-15 19:15:37 UTC (rev 254608)
+++ branches/safari-609-branch/Source/WebKit/ChangeLog 2020-01-15 19:15:40 UTC (rev 254609)
@@ -1,5 +1,36 @@
2020-01-14 Alan Coon <[email protected]>
+ Cherry-pick r254292. rdar://problem/58552868
+
+ Set the title for images so it will be correctly displayed in UIContextMenus
+ https://bugs.webkit.org/show_bug.cgi?id=205980
+ <rdar://problem/57701988>
+
+ Reviewed by Dean Jackson.
+
+ Need to set the title text for images.
+
+ * UIProcess/ios/WKContentViewInteraction.mm:
+ (-[WKContentView continueContextMenuInteraction:]):
+
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254292 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2020-01-09 Megan Gardner <[email protected]>
+
+ Set the title for images so it will be correctly displayed in UIContextMenus
+ https://bugs.webkit.org/show_bug.cgi?id=205980
+ <rdar://problem/57701988>
+
+ Reviewed by Dean Jackson.
+
+ Need to set the title text for images.
+
+ * UIProcess/ios/WKContentViewInteraction.mm:
+ (-[WKContentView continueContextMenuInteraction:]):
+
+2020-01-14 Alan Coon <[email protected]>
+
Cherry-pick r254287. rdar://problem/58552886
Fullscreen videos do not enter PiP in first tap
Modified: branches/safari-609-branch/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (254608 => 254609)
--- branches/safari-609-branch/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2020-01-15 19:15:37 UTC (rev 254608)
+++ branches/safari-609-branch/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2020-01-15 19:15:40 UTC (rev 254609)
@@ -8480,7 +8480,7 @@
RetainPtr<NSArray<_WKElementAction *>> defaultActionsFromAssistant = [strongSelf->_actionSheetAssistant defaultActionsForImageSheet:elementInfo.get()];
auto actions = menuElementsFromDefaultActions(defaultActionsFromAssistant, elementInfo);
- return [UIMenu menuWithTitle:@"" children:actions];
+ return [UIMenu menuWithTitle:strongSelf->_positionInformation.title children:actions];
};
UIContextMenuContentPreviewProvider contentPreviewProvider = [weakSelf, cgImage, elementInfo] () -> UIViewController * {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
