Title: [254637] trunk/Source/_javascript_Core
- Revision
- 254637
- Author
- [email protected]
- Date
- 2020-01-15 14:15:38 -0800 (Wed, 15 Jan 2020)
Log Message
Offlineasm warnings with newer Ruby versions
https://bugs.webkit.org/show_bug.cgi?id=206233
Reviewed by Yusuke Suzuki.
Avoid a warning about using Object#=~ on Annotation instances, which
has been deprecated in Ruby 2.7.
* offlineasm/parser.rb: Swap checks to prevent applying the =~ operator
to Annotation instances, which do not define it.
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (254636 => 254637)
--- trunk/Source/_javascript_Core/ChangeLog 2020-01-15 22:04:45 UTC (rev 254636)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-01-15 22:15:38 UTC (rev 254637)
@@ -1,3 +1,16 @@
+2020-01-15 Adrian Perez de Castro <[email protected]>
+
+ Offlineasm warnings with newer Ruby versions
+ https://bugs.webkit.org/show_bug.cgi?id=206233
+
+ Reviewed by Yusuke Suzuki.
+
+ Avoid a warning about using Object#=~ on Annotation instances, which
+ has been deprecated in Ruby 2.7.
+
+ * offlineasm/parser.rb: Swap checks to prevent applying the =~ operator
+ to Annotation instances, which do not define it.
+
2020-01-15 Keith Miller <[email protected]>
Revert bytecode checkpoints since it breaks watch
Modified: trunk/Source/_javascript_Core/offlineasm/parser.rb (254636 => 254637)
--- trunk/Source/_javascript_Core/offlineasm/parser.rb 2020-01-15 22:04:45 UTC (rev 254636)
+++ trunk/Source/_javascript_Core/offlineasm/parser.rb 2020-01-15 22:15:38 UTC (rev 254637)
@@ -628,9 +628,7 @@
firstCodeOrigin = @tokens[@idx].codeOrigin
list = []
loop {
- if (@idx == @tokens.length and not final) or (final and @tokens[@idx] =~ final)
- break
- elsif @tokens[@idx].is_a? Annotation
+ if @tokens[@idx].is_a? Annotation
# This is the only place where we can encounter a global
# annotation, and hence need to be able to distinguish between
# them.
@@ -644,6 +642,8 @@
list << Instruction.new(codeOrigin, annotationOpcode, [], @tokens[@idx].string)
@annotation = nil
@idx += 2 # Consume the newline as well.
+ elsif (@idx == @tokens.length and not final) or (final and @tokens[@idx] =~ final)
+ break
elsif @tokens[@idx] == "\n"
# ignore
@idx += 1
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
