Title: [254644] branches/safari-609-branch/Source/WebInspectorUI
Revision
254644
Author
[email protected]
Date
2020-01-15 15:07:19 -0800 (Wed, 15 Jan 2020)

Log Message

Cherry-pick r254058. rdar://problem/58606175

    Web Inspector: Canvas: unable to see recording actions for WebGL canvases that have lots of shader programs
    https://bugs.webkit.org/show_bug.cgi?id=205659

    Reviewed by Brian Burg.

    Limit the height of the canvas and shader program tree a recording is selected.

    * UserInterface/Views/CanvasSidebarPanel.js:
    (WI.CanvasSidebarPanel.prototype._updateRecordingScopeBar):
    * UserInterface/Views/CanvasSidebarPanel.css:
    (.sidebar > .panel.navigation.canvas.showing-recording > .content > .tree-outline.canvas): Added.

    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

Diff

Modified: branches/safari-609-branch/Source/WebInspectorUI/ChangeLog (254643 => 254644)


--- branches/safari-609-branch/Source/WebInspectorUI/ChangeLog	2020-01-15 23:07:16 UTC (rev 254643)
+++ branches/safari-609-branch/Source/WebInspectorUI/ChangeLog	2020-01-15 23:07:19 UTC (rev 254644)
@@ -1,3 +1,36 @@
+2020-01-15  Alan Coon  <[email protected]>
+
+        Cherry-pick r254058. rdar://problem/58606175
+
+    Web Inspector: Canvas: unable to see recording actions for WebGL canvases that have lots of shader programs
+    https://bugs.webkit.org/show_bug.cgi?id=205659
+    
+    Reviewed by Brian Burg.
+    
+    Limit the height of the canvas and shader program tree a recording is selected.
+    
+    * UserInterface/Views/CanvasSidebarPanel.js:
+    (WI.CanvasSidebarPanel.prototype._updateRecordingScopeBar):
+    * UserInterface/Views/CanvasSidebarPanel.css:
+    (.sidebar > .panel.navigation.canvas.showing-recording > .content > .tree-outline.canvas): Added.
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254058 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2020-01-06  Devin Rousso  <[email protected]>
+
+            Web Inspector: Canvas: unable to see recording actions for WebGL canvases that have lots of shader programs
+            https://bugs.webkit.org/show_bug.cgi?id=205659
+
+            Reviewed by Brian Burg.
+
+            Limit the height of the canvas and shader program tree a recording is selected.
+
+            * UserInterface/Views/CanvasSidebarPanel.js:
+            (WI.CanvasSidebarPanel.prototype._updateRecordingScopeBar):
+            * UserInterface/Views/CanvasSidebarPanel.css:
+            (.sidebar > .panel.navigation.canvas.showing-recording > .content > .tree-outline.canvas): Added.
+
 2020-01-14  Alan Coon  <[email protected]>
 
         Cherry-pick r254145. rdar://problem/58552861

Modified: branches/safari-609-branch/Source/WebInspectorUI/UserInterface/Views/CanvasSidebarPanel.css (254643 => 254644)


--- branches/safari-609-branch/Source/WebInspectorUI/UserInterface/Views/CanvasSidebarPanel.css	2020-01-15 23:07:16 UTC (rev 254643)
+++ branches/safari-609-branch/Source/WebInspectorUI/UserInterface/Views/CanvasSidebarPanel.css	2020-01-15 23:07:19 UTC (rev 254644)
@@ -52,6 +52,13 @@
     overflow-y: scroll;
 }
 
+.sidebar > .panel.navigation.canvas.showing-recording > .content > .tree-outline.canvas {
+    flex-shrink: 0;
+    height: fit-content;
+    max-height: 110px;
+    overflow-y: auto;
+}
+
 .sidebar > .panel.navigation.canvas:not(.has-recordings) > .filter-bar,
 .sidebar > .panel.navigation.canvas:not(.has-recordings) > .content > :matches(.navigation-bar, .recording-content) {
     display: none;

Modified: branches/safari-609-branch/Source/WebInspectorUI/UserInterface/Views/CanvasSidebarPanel.js (254643 => 254644)


--- branches/safari-609-branch/Source/WebInspectorUI/UserInterface/Views/CanvasSidebarPanel.js	2020-01-15 23:07:16 UTC (rev 254643)
+++ branches/safari-609-branch/Source/WebInspectorUI/UserInterface/Views/CanvasSidebarPanel.js	2020-01-15 23:07:19 UTC (rev 254644)
@@ -498,6 +498,7 @@
 
         let hasRecordings = this._recording || (this._canvas && this._canvas.recordingCollection.size);
         this.element.classList.toggle("has-recordings", hasRecordings);
+        this.element.classList.toggle("showing-recording", !!this._recording);
         if (!hasRecordings)
             return;
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to