Title: [254675] trunk
- Revision
- 254675
- Author
- [email protected]
- Date
- 2020-01-16 06:44:19 -0800 (Thu, 16 Jan 2020)
Log Message
[GTK][WPE] Password field doesn't get input method
https://bugs.webkit.org/show_bug.cgi?id=34285
Reviewed by Žan Doberšek.
Source/WebCore:
Allow input methods in password fields for GTK and WPE ports, since the input methods are notified that the
active editable element is a password field.
* html/PasswordInputType.cpp:
(WebCore::PasswordInputType::shouldUseInputMethod const):
Tools:
Enable the test case for password field.
* TestWebKitAPI/Tests/WebKitGLib/TestInputMethodContext.cpp:
(testWebKitInputMethodContextContentType):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (254674 => 254675)
--- trunk/Source/WebCore/ChangeLog 2020-01-16 13:21:07 UTC (rev 254674)
+++ trunk/Source/WebCore/ChangeLog 2020-01-16 14:44:19 UTC (rev 254675)
@@ -1,3 +1,16 @@
+2020-01-16 Carlos Garcia Campos <[email protected]>
+
+ [GTK][WPE] Password field doesn't get input method
+ https://bugs.webkit.org/show_bug.cgi?id=34285
+
+ Reviewed by Žan Doberšek.
+
+ Allow input methods in password fields for GTK and WPE ports, since the input methods are notified that the
+ active editable element is a password field.
+
+ * html/PasswordInputType.cpp:
+ (WebCore::PasswordInputType::shouldUseInputMethod const):
+
2020-01-16 Fujii Hironori <[email protected]>
Unreviewed build fix for curl.
Modified: trunk/Source/WebCore/html/PasswordInputType.cpp (254674 => 254675)
--- trunk/Source/WebCore/html/PasswordInputType.cpp 2020-01-16 13:21:07 UTC (rev 254674)
+++ trunk/Source/WebCore/html/PasswordInputType.cpp 2020-01-16 14:44:19 UTC (rev 254675)
@@ -64,9 +64,16 @@
bool PasswordInputType::shouldUseInputMethod() const
{
+#if PLATFORM(GTK) || PLATFORM(WPE)
+ // Input methods are enabled for the password field in GTK and WPE ports
+ // because the input methods are notified that the active editable element
+ // is a password field.
+ return true;
+#else
// Input methods are disabled for the password field because otherwise
// anyone can access the underlying password and display it in clear text.
return false;
+#endif
}
bool PasswordInputType::shouldResetOnDocumentActivation()
Modified: trunk/Tools/ChangeLog (254674 => 254675)
--- trunk/Tools/ChangeLog 2020-01-16 13:21:07 UTC (rev 254674)
+++ trunk/Tools/ChangeLog 2020-01-16 14:44:19 UTC (rev 254675)
@@ -1,3 +1,15 @@
+2020-01-16 Carlos Garcia Campos <[email protected]>
+
+ [GTK][WPE] Password field doesn't get input method
+ https://bugs.webkit.org/show_bug.cgi?id=34285
+
+ Reviewed by Žan Doberšek.
+
+ Enable the test case for password field.
+
+ * TestWebKitAPI/Tests/WebKitGLib/TestInputMethodContext.cpp:
+ (testWebKitInputMethodContextContentType):
+
2020-01-16 Cathie Chen <[email protected]>
Mapping HTML attributes width/height to the default aspect ratio of <img>
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestInputMethodContext.cpp (254674 => 254675)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestInputMethodContext.cpp 2020-01-16 13:21:07 UTC (rev 254674)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestInputMethodContext.cpp 2020-01-16 14:44:19 UTC (rev 254675)
@@ -898,15 +898,12 @@
g_assert_cmpuint(test->hints(), ==, WEBKIT_INPUT_HINT_NONE);
test->unfocusEditableAndWaitUntilInputMethodDisabled();
-#if 0
- // FIXME: We should enable input methods in password fields too.
- test->loadHtml("<input id='editable' type='password'>", nullptr);
+ test->loadHtml("<input id='editable' type='password' spellcheck='false'>", nullptr);
test->waitUntilLoadFinished();
test->focusEditableAndWaitUntilInputMethodEnabled();
g_assert_cmpuint(test->purpose(), ==, WEBKIT_INPUT_PURPOSE_PASSWORD);
g_assert_cmpuint(test->hints(), ==, WEBKIT_INPUT_HINT_NONE);
test->unfocusEditableAndWaitUntilInputMethodDisabled();
-#endif
test->loadHtml("<div contenteditable id='editable' inputmode='text' spellcheck='false'></div>", nullptr);
test->waitUntilLoadFinished();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
