Modified: trunk/Source/_javascript_Core/ChangeLog (254688 => 254689)
--- trunk/Source/_javascript_Core/ChangeLog 2020-01-16 18:09:09 UTC (rev 254688)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-01-16 18:14:13 UTC (rev 254689)
@@ -1,3 +1,14 @@
+2020-01-16 Jonathan Bedard <[email protected]>
+
+ Pass JSToken by const reference
+ https://bugs.webkit.org/show_bug.cgi?id=206321
+
+ Reviewed by Saam Barati.
+
+ * parser/Parser.cpp:
+ (JSC::Parser<LexerType>::createBindingPattern): Pass JSToken by const reference.
+ * parser/Parser.h: Ditto.
+
2020-01-16 Mark Lam <[email protected]>
operationToObject() should check for a null errorMessage.
Modified: trunk/Source/_javascript_Core/parser/Parser.cpp (254688 => 254689)
--- trunk/Source/_javascript_Core/parser/Parser.cpp 2020-01-16 18:09:09 UTC (rev 254688)
+++ trunk/Source/_javascript_Core/parser/Parser.cpp 2020-01-16 18:14:13 UTC (rev 254689)
@@ -945,7 +945,7 @@
}
template <typename LexerType>
-template <class TreeBuilder> TreeDestructuringPattern Parser<LexerType>::createBindingPattern(TreeBuilder& context, DestructuringKind kind, ExportType exportType, const Identifier& name, JSToken token, AssignmentContext bindingContext, const Identifier** duplicateIdentifier)
+template <class TreeBuilder> TreeDestructuringPattern Parser<LexerType>::createBindingPattern(TreeBuilder& context, DestructuringKind kind, ExportType exportType, const Identifier& name, const JSToken& token, AssignmentContext bindingContext, const Identifier** duplicateIdentifier)
{
ASSERT(!name.isNull());
Modified: trunk/Source/_javascript_Core/parser/Parser.h (254688 => 254689)
--- trunk/Source/_javascript_Core/parser/Parser.h 2020-01-16 18:09:09 UTC (rev 254688)
+++ trunk/Source/_javascript_Core/parser/Parser.h 2020-01-16 18:14:13 UTC (rev 254689)
@@ -1655,7 +1655,7 @@
template <class TreeBuilder> TreeExpression parseVariableDeclarationList(TreeBuilder&, int& declarations, TreeDestructuringPattern& lastPattern, TreeExpression& lastInitializer, JSTextPosition& identStart, JSTextPosition& initStart, JSTextPosition& initEnd, VarDeclarationListContext, DeclarationType, ExportType, bool& forLoopConstDoesNotHaveInitializer);
template <class TreeBuilder> TreeSourceElements parseArrowFunctionSingleExpressionBodySourceElements(TreeBuilder&);
template <class TreeBuilder> TreeExpression parseArrowFunctionExpression(TreeBuilder&, bool isAsync);
- template <class TreeBuilder> NEVER_INLINE TreeDestructuringPattern createBindingPattern(TreeBuilder&, DestructuringKind, ExportType, const Identifier&, JSToken, AssignmentContext, const Identifier** duplicateIdentifier);
+ template <class TreeBuilder> NEVER_INLINE TreeDestructuringPattern createBindingPattern(TreeBuilder&, DestructuringKind, ExportType, const Identifier&, const JSToken&, AssignmentContext, const Identifier** duplicateIdentifier);
template <class TreeBuilder> NEVER_INLINE TreeDestructuringPattern createAssignmentElement(TreeBuilder&, TreeExpression&, const JSTextPosition&, const JSTextPosition&);
template <class TreeBuilder> NEVER_INLINE TreeDestructuringPattern parseObjectRestBindingOrAssignmentElement(TreeBuilder& context, DestructuringKind, ExportType, const Identifier** duplicateIdentifier, AssignmentContext bindingContext);
template <class TreeBuilder> NEVER_INLINE TreeDestructuringPattern parseBindingOrAssignmentElement(TreeBuilder& context, DestructuringKind, ExportType, const Identifier** duplicateIdentifier, bool* hasDestructuringPattern, AssignmentContext bindingContext, int depth);
