Title: [254705] trunk/LayoutTests
Revision
254705
Author
[email protected]
Date
2020-01-16 13:31:59 -0800 (Thu, 16 Jan 2020)

Log Message

REGRESSION: [ Mac WK2 ] fast/text/international/unicode-bidi-other-neutrals.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=205808

Patch by Doug Kelly <[email protected]> on 2020-01-16
Reviewed by Maciej Stachowiak.

Update the testcase for bidi text runs ending with other neutrals to dumpAsText, instead of trying
to compare visual content.

* fast/text/international/unicode-bidi-other-neutrals-expected.html: Removed.
* fast/text/international/unicode-bidi-other-neutrals-expected.txt: Added.
* fast/text/international/unicode-bidi-other-neutrals.html:

Modified Paths

Added Paths

Removed Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (254704 => 254705)


--- trunk/LayoutTests/ChangeLog	2020-01-16 21:30:39 UTC (rev 254704)
+++ trunk/LayoutTests/ChangeLog	2020-01-16 21:31:59 UTC (rev 254705)
@@ -1,3 +1,17 @@
+2020-01-16  Doug Kelly  <[email protected]>
+
+        REGRESSION: [ Mac WK2 ] fast/text/international/unicode-bidi-other-neutrals.html is a flaky failure
+        https://bugs.webkit.org/show_bug.cgi?id=205808
+
+        Reviewed by Maciej Stachowiak.
+
+        Update the testcase for bidi text runs ending with other neutrals to dumpAsText, instead of trying
+        to compare visual content.
+
+        * fast/text/international/unicode-bidi-other-neutrals-expected.html: Removed.
+        * fast/text/international/unicode-bidi-other-neutrals-expected.txt: Added.
+        * fast/text/international/unicode-bidi-other-neutrals.html:
+
 2020-01-16  Diego Pino Garcia  <[email protected]>
 
         [GTK] Rebaseline several tests

Deleted: trunk/LayoutTests/fast/text/international/unicode-bidi-other-neutrals-expected.html (254704 => 254705)


--- trunk/LayoutTests/fast/text/international/unicode-bidi-other-neutrals-expected.html	2020-01-16 21:30:39 UTC (rev 254704)
+++ trunk/LayoutTests/fast/text/international/unicode-bidi-other-neutrals-expected.html	2020-01-16 21:31:59 UTC (rev 254705)
@@ -1,10 +0,0 @@
-<!DOCTYPE html>
-<html>
-  <head>
-    <meta charset="utf-8"/>
-  </head>
-  <body>
-    <font dir="ltr">a</font>
-    <marquee>b</marquee>
-  </body>
-</html>

Added: trunk/LayoutTests/fast/text/international/unicode-bidi-other-neutrals-expected.txt (0 => 254705)


--- trunk/LayoutTests/fast/text/international/unicode-bidi-other-neutrals-expected.txt	                        (rev 0)
+++ trunk/LayoutTests/fast/text/international/unicode-bidi-other-neutrals-expected.txt	2020-01-16 21:31:59 UTC (rev 254705)
@@ -0,0 +1 @@
+This test verifies WebKit does not assert when encountering other neutrals at the end of a bidi text run. Test passes if WebKit does not assert in a development build. PASS

Modified: trunk/LayoutTests/fast/text/international/unicode-bidi-other-neutrals.html (254704 => 254705)


--- trunk/LayoutTests/fast/text/international/unicode-bidi-other-neutrals.html	2020-01-16 21:30:39 UTC (rev 254704)
+++ trunk/LayoutTests/fast/text/international/unicode-bidi-other-neutrals.html	2020-01-16 21:31:59 UTC (rev 254705)
@@ -1,10 +1,16 @@
 <!DOCTYPE html>
 <html>
-  <head>
-    <meta charset="utf-8"/>
-  </head>
-  <body>
-    <font dir="ltr">a</font>
-    <marquee>b</marquee>
-  </body>
+    <head>
+        <meta charset="utf-8"/>
+        <script>
+            function testresult() {
+                if (window.testRunner)
+                    testRunner.dumpAsText();
+            }
+        </script>
+    </head>
+    <body _onload_="testresult();">
+        <font dir="ltr">This test verifies WebKit does not assert when encountering other neutrals at the end of a bidi text run.  Test passes if WebKit does not assert in a development build.</font>
+        <marquee>PASS</marquee>
+    </body>
 </html>
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to