Title: [254729] trunk/Source/WebCore
- Revision
- 254729
- Author
- [email protected]
- Date
- 2020-01-16 17:24:15 -0800 (Thu, 16 Jan 2020)
Log Message
Unreviewed removing a stale FIXME comment
https://bugs.webkit.org/show_bug.cgi?id=204884
Follows-up for r254323.
* platform/graphics/win/ComplexTextControllerUniscribe.cpp:
(WebCore::ComplexTextController::collectComplexTextRunsForCharacters):
Removed a stale FIXME comment. This comment was added by r23154. r23199
fixed the issue.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (254728 => 254729)
--- trunk/Source/WebCore/ChangeLog 2020-01-17 01:16:43 UTC (rev 254728)
+++ trunk/Source/WebCore/ChangeLog 2020-01-17 01:24:15 UTC (rev 254729)
@@ -1,3 +1,15 @@
+2020-01-16 Fujii Hironori <[email protected]>
+
+ Unreviewed removing a stale FIXME comment
+ https://bugs.webkit.org/show_bug.cgi?id=204884
+
+ Follows-up for r254323.
+
+ * platform/graphics/win/ComplexTextControllerUniscribe.cpp:
+ (WebCore::ComplexTextController::collectComplexTextRunsForCharacters):
+ Removed a stale FIXME comment. This comment was added by r23154. r23199
+ fixed the issue.
+
2020-01-16 Ryosuke Niwa <[email protected]>
REGRESSION (r251110): Crash on https://developer.apple.com/tutorials/swiftui/creating-and-combining-views
Modified: trunk/Source/WebCore/platform/graphics/win/ComplexTextControllerUniscribe.cpp (254728 => 254729)
--- trunk/Source/WebCore/platform/graphics/win/ComplexTextControllerUniscribe.cpp 2020-01-17 01:16:43 UTC (rev 254728)
+++ trunk/Source/WebCore/platform/graphics/win/ComplexTextControllerUniscribe.cpp 2020-01-17 01:24:15 UTC (rev 254729)
@@ -171,10 +171,6 @@
offsetY = roundf(offsetY);
}
- // FIXME: We need to take the GOFFSETS for combining glyphs and store them in the glyph buffer
- // as well, so that when the time comes to draw those glyphs, we can apply the appropriate
- // translation.
-
baseAdvances.uncheckedAppend({ advance, 0 });
origins.uncheckedAppend({ offsetX, offsetY });
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
