Title: [254734] trunk/Source/WebKit
Revision
254734
Author
[email protected]
Date
2020-01-16 19:55:04 -0800 (Thu, 16 Jan 2020)

Log Message

[iOS] Add telemetry for IOKIt classes not seen in test runs
https://bugs.webkit.org/show_bug.cgi?id=206386
<rdar://problem/58663519>

Reviewed by Per Arne Vollan.

Capture telemetry to show which IOKit classes are acitvely used in WebKit.

No new tests because this does not change behavior.

* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (254733 => 254734)


--- trunk/Source/WebKit/ChangeLog	2020-01-17 03:47:54 UTC (rev 254733)
+++ trunk/Source/WebKit/ChangeLog	2020-01-17 03:55:04 UTC (rev 254734)
@@ -1,3 +1,17 @@
+2020-01-16  Brent Fulgham  <[email protected]>
+
+        [iOS] Add telemetry for IOKIt classes not seen in test runs
+        https://bugs.webkit.org/show_bug.cgi?id=206386
+        <rdar://problem/58663519>
+
+        Reviewed by Per Arne Vollan.
+
+        Capture telemetry to show which IOKit classes are acitvely used in WebKit.
+
+        No new tests because this does not change behavior.
+
+        * Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
+
 2020-01-16  Chris Dumez  <[email protected]>
 
         IPC hardening for WebPageProxy::SetPromisedDataForImage message

Modified: trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb (254733 => 254734)


--- trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb	2020-01-17 03:47:54 UTC (rev 254733)
+++ trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb	2020-01-17 03:55:04 UTC (rev 254734)
@@ -265,12 +265,12 @@
 ;;; Declare that the application uses the OpenGL, Metal, and CoreML hardware & frameworks.
 ;;;
 (define-once (opengl)
-    (allow iokit-open
+    ;; Items not seen in testing
+    (allow iokit-open (with report) (with telemetry)
            (iokit-connection "IOGPU")
            (iokit-user-client-class
                 "AGXCommandQueue"
                 "AGXDevice"
-                "AGXDeviceUserClient"
                 "AGXSharedUserClient"
                 "IOAccelContext"
                 "IOAccelDevice"
@@ -280,6 +280,13 @@
                 "IOAccelDevice2"
                 "IOAccelSharedUserClient2"))
 
+    ;; Items with known uses
+    (allow iokit-open
+        (iokit-connection "IOGPU")
+        (iokit-user-client-class
+            "AGXDeviceUserClient" ;; Used by WebGL
+    ))
+
     (allow iokit-get-properties
         (iokit-property "IOGLBundleName")
         (iokit-property "IOGLESBundleName")
@@ -448,10 +455,14 @@
     )
 
     ; UIKit-required IOKit nodes.
-    (allow iokit-open
+    (allow iokit-open  (with report) (with telemetry)
         (iokit-user-client-class "AppleJPEGDriverUserClient")
-        (iokit-user-client-class "IOSurfaceAcceleratorClient")
         (iokit-user-client-class "IOSurfaceSendRight")
+    )
+
+    ; WebKit-required IOKit classes
+    (allow iokit-open
+        (iokit-user-client-class "IOSurfaceAcceleratorClient") ;; Media rendering into pixel buffers
         (iokit-user-client-class "IOSurfaceRootUserClient") ;; Needed by Tiled Grid code.
     )
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to