Title: [254742] trunk/Source/WebKit
- Revision
- 254742
- Author
- [email protected]
- Date
- 2020-01-17 06:00:42 -0800 (Fri, 17 Jan 2020)
Log Message
[GTK][WPE] Composition underline color is not applied
https://bugs.webkit.org/show_bug.cgi?id=206353
Reviewed by Sergio Villar Senin.
CompositionUnderline::compositionUnderlineColor is not encoded/decoded in IPC messages, so the web process
always uses CompositionUnderlineColor::TextColor ignoring the given color.
* Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<CompositionUnderline>::encode): Encode compositionUnderlineColor.
(IPC::ArgumentCoder<CompositionUnderline>::decode): Decode compositionUnderlineColor.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (254741 => 254742)
--- trunk/Source/WebKit/ChangeLog 2020-01-17 11:59:59 UTC (rev 254741)
+++ trunk/Source/WebKit/ChangeLog 2020-01-17 14:00:42 UTC (rev 254742)
@@ -1,3 +1,17 @@
+2020-01-17 Carlos Garcia Campos <[email protected]>
+
+ [GTK][WPE] Composition underline color is not applied
+ https://bugs.webkit.org/show_bug.cgi?id=206353
+
+ Reviewed by Sergio Villar Senin.
+
+ CompositionUnderline::compositionUnderlineColor is not encoded/decoded in IPC messages, so the web process
+ always uses CompositionUnderlineColor::TextColor ignoring the given color.
+
+ * Shared/WebCoreArgumentCoders.cpp:
+ (IPC::ArgumentCoder<CompositionUnderline>::encode): Encode compositionUnderlineColor.
+ (IPC::ArgumentCoder<CompositionUnderline>::decode): Decode compositionUnderlineColor.
+
2020-01-16 Zan Dobersek <[email protected]>
Unreviewed. Move the common WebKitOptionMenu GLib API implementation
Modified: trunk/Source/WebKit/Shared/WebCoreArgumentCoders.cpp (254741 => 254742)
--- trunk/Source/WebKit/Shared/WebCoreArgumentCoders.cpp 2020-01-17 11:59:59 UTC (rev 254741)
+++ trunk/Source/WebKit/Shared/WebCoreArgumentCoders.cpp 2020-01-17 14:00:42 UTC (rev 254742)
@@ -1603,6 +1603,7 @@
encoder << underline.startOffset;
encoder << underline.endOffset;
encoder << underline.thick;
+ encoder.encodeEnum(underline.compositionUnderlineColor);
encoder << underline.color;
}
@@ -1616,6 +1617,8 @@
return WTF::nullopt;
if (!decoder.decode(underline.thick))
return WTF::nullopt;
+ if (!decoder.decodeEnum(underline.compositionUnderlineColor))
+ return WTF::nullopt;
if (!decoder.decode(underline.color))
return WTF::nullopt;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
