Title: [254746] trunk/Source/WebKit
Revision
254746
Author
[email protected]
Date
2020-01-17 08:00:22 -0800 (Fri, 17 Jan 2020)

Log Message

[WinCairo][WK2] ASSERT(isUIThread()) is failing since r254723
https://bugs.webkit.org/show_bug.cgi?id=206394

Reviewed by Carlos Alberto Lopez Perez.

AtomString::init() should be called after
WTF::initializeThreading() is called on Windows because it has
ASSERT(isUIThread()) and Windows doesn't have a API to get main
thread handle like pthread_main_np.

* Shared/WebKit2Initialize.cpp:
(WebKit::InitializeWebKit2): Call AtomString::init() after JSC::initializeThreading().

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (254745 => 254746)


--- trunk/Source/WebKit/ChangeLog	2020-01-17 15:56:30 UTC (rev 254745)
+++ trunk/Source/WebKit/ChangeLog	2020-01-17 16:00:22 UTC (rev 254746)
@@ -1,3 +1,18 @@
+2020-01-17  Fujii Hironori  <[email protected]>
+
+        [WinCairo][WK2] ASSERT(isUIThread()) is failing since r254723
+        https://bugs.webkit.org/show_bug.cgi?id=206394
+
+        Reviewed by Carlos Alberto Lopez Perez.
+
+        AtomString::init() should be called after
+        WTF::initializeThreading() is called on Windows because it has
+        ASSERT(isUIThread()) and Windows doesn't have a API to get main
+        thread handle like pthread_main_np.
+
+        * Shared/WebKit2Initialize.cpp:
+        (WebKit::InitializeWebKit2): Call AtomString::init() after JSC::initializeThreading().
+
 2020-01-17  Chris Dumez  <[email protected]>
 
         IPC hardening for WebPasteboardProxy::SetPasteboardBufferForType message

Modified: trunk/Source/WebKit/Shared/WebKit2Initialize.cpp (254745 => 254746)


--- trunk/Source/WebKit/Shared/WebKit2Initialize.cpp	2020-01-17 15:56:30 UTC (rev 254745)
+++ trunk/Source/WebKit/Shared/WebKit2Initialize.cpp	2020-01-17 16:00:22 UTC (rev 254746)
@@ -39,9 +39,9 @@
 
 void InitializeWebKit2()
 {
-    AtomString::init();
     JSC::initializeThreading();
     RunLoop::initializeMainRunLoop();
+    AtomString::init();
 
     WTF::RefCountedBase::enableThreadingChecksGlobally();
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to