Title: [254812] trunk/Source/WebCore
- Revision
- 254812
- Author
- [email protected]
- Date
- 2020-01-20 01:02:39 -0800 (Mon, 20 Jan 2020)
Log Message
ASSERT in case a service worker cannot be terminated in a timely manner
https://bugs.webkit.org/show_bug.cgi?id=206413
Reviewed by Alexey Proskuryakov.
No change of behavior, the process will still exit if it does not succeed in stopping a service worker.
In Debug, a crash log will be collected which will allow to help identifying other crashes.
* workers/service/context/SWContextManager.cpp:
(WebCore::SWContextManager::serviceWorkerFailedToTerminate):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (254811 => 254812)
--- trunk/Source/WebCore/ChangeLog 2020-01-20 08:07:15 UTC (rev 254811)
+++ trunk/Source/WebCore/ChangeLog 2020-01-20 09:02:39 UTC (rev 254812)
@@ -1,3 +1,16 @@
+2020-01-20 youenn fablet <[email protected]>
+
+ ASSERT in case a service worker cannot be terminated in a timely manner
+ https://bugs.webkit.org/show_bug.cgi?id=206413
+
+ Reviewed by Alexey Proskuryakov.
+
+ No change of behavior, the process will still exit if it does not succeed in stopping a service worker.
+ In Debug, a crash log will be collected which will allow to help identifying other crashes.
+
+ * workers/service/context/SWContextManager.cpp:
+ (WebCore::SWContextManager::serviceWorkerFailedToTerminate):
+
2020-01-20 Takashi Komori <[email protected]>
KeyedDecoderGeneric crashes when it accesses data with non-existing key
Modified: trunk/Source/WebCore/workers/service/context/SWContextManager.cpp (254811 => 254812)
--- trunk/Source/WebCore/workers/service/context/SWContextManager.cpp 2020-01-20 08:07:15 UTC (rev 254811)
+++ trunk/Source/WebCore/workers/service/context/SWContextManager.cpp 2020-01-20 09:02:39 UTC (rev 254812)
@@ -164,6 +164,7 @@
{
UNUSED_PARAM(serviceWorkerIdentifier);
RELEASE_LOG_ERROR(ServiceWorker, "Failed to terminate service worker with identifier %s, killing the service worker process", serviceWorkerIdentifier.loggingString().utf8().data());
+ ASSERT_NOT_REACHED();
_exit(EXIT_FAILURE);
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
