Title: [254868] trunk
Revision
254868
Author
[email protected]
Date
2020-01-21 11:40:47 -0800 (Tue, 21 Jan 2020)

Log Message

Fix tvOS values in SUPPORTED_PLATFORMS
https://bugs.webkit.org/show_bug.cgi?id=206435
<rdar://problem/58674587>

Reviewed by Alexey Proskuryakov.

A number of targets in WebKit have 'tvos' and 'tvsimulator' in
SUPPORTED_PLATFORMS. The correct values are 'appletvos' and
'appletvsimulator'. These should be updated to the correct ones as the
wrong values prevent the tvOS run destination from being usable in the
UI to build for tvOS.

Source/ThirdParty:

* gtest/xcode/Config/General.xcconfig:

Source/WebInspectorUI:

* Configurations/Base.xcconfig:

Tools:

* DumpRenderTree/mac/Configurations/Base.xcconfig:
* ImageDiff/cg/Configurations/Base.xcconfig:
* MiniBrowser/Configurations/Base.xcconfig:
* WebKitTestRunner/Configurations/Base.xcconfig:

Modified Paths

Diff

Modified: trunk/Source/ThirdParty/ChangeLog (254867 => 254868)


--- trunk/Source/ThirdParty/ChangeLog	2020-01-21 19:36:52 UTC (rev 254867)
+++ trunk/Source/ThirdParty/ChangeLog	2020-01-21 19:40:47 UTC (rev 254868)
@@ -1,3 +1,19 @@
+2020-01-21  Keith Rollin  <[email protected]>
+
+        Fix tvOS values in SUPPORTED_PLATFORMS
+        https://bugs.webkit.org/show_bug.cgi?id=206435
+        <rdar://problem/58674587>
+
+        Reviewed by Alexey Proskuryakov.
+
+        A number of targets in WebKit have 'tvos' and 'tvsimulator' in
+        SUPPORTED_PLATFORMS. The correct values are 'appletvos' and
+        'appletvsimulator'. These should be updated to the correct ones as the
+        wrong values prevent the tvOS run destination from being usable in the
+        UI to build for tvOS.
+
+        * gtest/xcode/Config/General.xcconfig:
+
 2020-01-08  Mark Lam  <[email protected]>
 
         Rename testing build configuration to release+assert, and add new testing build configuration.

Modified: trunk/Source/ThirdParty/gtest/xcode/Config/General.xcconfig (254867 => 254868)


--- trunk/Source/ThirdParty/gtest/xcode/Config/General.xcconfig	2020-01-21 19:36:52 UTC (rev 254867)
+++ trunk/Source/ThirdParty/gtest/xcode/Config/General.xcconfig	2020-01-21 19:40:47 UTC (rev 254868)
@@ -72,4 +72,4 @@
 OTHER_CPLUSPLUSFLAGS = $(ASAN_OTHER_CPLUSPLUSFLAGS);
 OTHER_LDFLAGS = $(ASAN_OTHER_LDFLAGS);
 
-SUPPORTED_PLATFORMS = iphoneos iphonesimulator macosx tvos tvsimulator watchos watchsimulator;
+SUPPORTED_PLATFORMS = iphoneos iphonesimulator macosx appletvos appletvsimulator watchos watchsimulator;

Modified: trunk/Source/WebInspectorUI/ChangeLog (254867 => 254868)


--- trunk/Source/WebInspectorUI/ChangeLog	2020-01-21 19:36:52 UTC (rev 254867)
+++ trunk/Source/WebInspectorUI/ChangeLog	2020-01-21 19:40:47 UTC (rev 254868)
@@ -1,3 +1,19 @@
+2020-01-21  Keith Rollin  <[email protected]>
+
+        Fix tvOS values in SUPPORTED_PLATFORMS
+        https://bugs.webkit.org/show_bug.cgi?id=206435
+        <rdar://problem/58674587>
+
+        Reviewed by Alexey Proskuryakov.
+
+        A number of targets in WebKit have 'tvos' and 'tvsimulator' in
+        SUPPORTED_PLATFORMS. The correct values are 'appletvos' and
+        'appletvsimulator'. These should be updated to the correct ones as the
+        wrong values prevent the tvOS run destination from being usable in the
+        UI to build for tvOS.
+
+        * Configurations/Base.xcconfig:
+
 2020-01-17  Nikita Vasilyev  <[email protected]>
 
         Web Inspector: Unchecking Enable Preview Features on Engineering and Preview builds does not affect WI.arePreviewFeaturesEnabled()

Modified: trunk/Source/WebInspectorUI/Configurations/Base.xcconfig (254867 => 254868)


--- trunk/Source/WebInspectorUI/Configurations/Base.xcconfig	2020-01-21 19:36:52 UTC (rev 254867)
+++ trunk/Source/WebInspectorUI/Configurations/Base.xcconfig	2020-01-21 19:40:47 UTC (rev 254868)
@@ -69,7 +69,7 @@
 ENGINEERING_BUILD_DEFINES = $(ENGINEERING_BUILD_DEFINES_$(ENGINEERING_BUILD));
 ENGINEERING_BUILD_DEFINES_1 = ENGINEERING_BUILD=1;
 
-SUPPORTED_PLATFORMS = iphoneos iphonesimulator macosx tvos tvsimulator watchos watchsimulator;
+SUPPORTED_PLATFORMS = iphoneos iphonesimulator macosx appletvos appletvsimulator watchos watchsimulator;
 
 TARGET_MAC_OS_X_VERSION_MAJOR = $(TARGET_MAC_OS_X_VERSION_MAJOR$(MACOSX_DEPLOYMENT_TARGET:suffix:identifier));
 TARGET_MAC_OS_X_VERSION_MAJOR_13 = 101300;

Modified: trunk/Tools/ChangeLog (254867 => 254868)


--- trunk/Tools/ChangeLog	2020-01-21 19:36:52 UTC (rev 254867)
+++ trunk/Tools/ChangeLog	2020-01-21 19:40:47 UTC (rev 254868)
@@ -1,3 +1,22 @@
+2020-01-21  Keith Rollin  <[email protected]>
+
+        Fix tvOS values in SUPPORTED_PLATFORMS
+        https://bugs.webkit.org/show_bug.cgi?id=206435
+        <rdar://problem/58674587>
+
+        Reviewed by Alexey Proskuryakov.
+
+        A number of targets in WebKit have 'tvos' and 'tvsimulator' in
+        SUPPORTED_PLATFORMS. The correct values are 'appletvos' and
+        'appletvsimulator'. These should be updated to the correct ones as the
+        wrong values prevent the tvOS run destination from being usable in the
+        UI to build for tvOS.
+
+        * DumpRenderTree/mac/Configurations/Base.xcconfig:
+        * ImageDiff/cg/Configurations/Base.xcconfig:
+        * MiniBrowser/Configurations/Base.xcconfig:
+        * WebKitTestRunner/Configurations/Base.xcconfig:
+
 2020-01-21  Sihui Liu  <[email protected]>
 
         Disable WebSQL everywhere by default except in tests

Modified: trunk/Tools/DumpRenderTree/mac/Configurations/Base.xcconfig (254867 => 254868)


--- trunk/Tools/DumpRenderTree/mac/Configurations/Base.xcconfig	2020-01-21 19:36:52 UTC (rev 254867)
+++ trunk/Tools/DumpRenderTree/mac/Configurations/Base.xcconfig	2020-01-21 19:40:47 UTC (rev 254868)
@@ -105,7 +105,7 @@
 
 AD_HOC_CODE_SIGNING_ALLOWED = YES;
 
-SUPPORTED_PLATFORMS = iphoneos iphonesimulator macosx tvos tvsimulator watchos watchsimulator;
+SUPPORTED_PLATFORMS = iphoneos iphonesimulator macosx appletvos appletvsimulator watchos watchsimulator;
 
 OTHER_CFLAGS = $(ASAN_OTHER_CFLAGS);
 OTHER_CPLUSPLUSFLAGS = $(ASAN_OTHER_CPLUSPLUSFLAGS);

Modified: trunk/Tools/ImageDiff/cg/Configurations/Base.xcconfig (254867 => 254868)


--- trunk/Tools/ImageDiff/cg/Configurations/Base.xcconfig	2020-01-21 19:36:52 UTC (rev 254867)
+++ trunk/Tools/ImageDiff/cg/Configurations/Base.xcconfig	2020-01-21 19:40:47 UTC (rev 254868)
@@ -80,7 +80,7 @@
 
 AD_HOC_CODE_SIGNING_ALLOWED = YES;
 
-SUPPORTED_PLATFORMS = iphoneos iphonesimulator macosx tvos tvsimulator watchos watchsimulator;
+SUPPORTED_PLATFORMS = iphoneos iphonesimulator macosx appletvos appletvsimulator watchos watchsimulator;
 
 OTHER_CFLAGS = $(ASAN_OTHER_CFLAGS);
 OTHER_CPLUSPLUSFLAGS = $(ASAN_OTHER_CPLUSPLUSFLAGS);

Modified: trunk/Tools/MiniBrowser/Configurations/Base.xcconfig (254867 => 254868)


--- trunk/Tools/MiniBrowser/Configurations/Base.xcconfig	2020-01-21 19:36:52 UTC (rev 254867)
+++ trunk/Tools/MiniBrowser/Configurations/Base.xcconfig	2020-01-21 19:40:47 UTC (rev 254868)
@@ -70,7 +70,7 @@
 WARNING_CFLAGS = -Wall -W -Wno-unused-parameter
 GCC_NO_COMMON_BLOCKS = YES;
 
-SUPPORTED_PLATFORMS = iphoneos iphonesimulator macosx tvos tvsimulator watchos watchsimulator;
+SUPPORTED_PLATFORMS = iphoneos iphonesimulator macosx appletvos appletvsimulator watchos watchsimulator;
 
 TARGET_MAC_OS_X_VERSION_MAJOR = $(TARGET_MAC_OS_X_VERSION_MAJOR$(MACOSX_DEPLOYMENT_TARGET:suffix:identifier));
 TARGET_MAC_OS_X_VERSION_MAJOR_13 = 101300;

Modified: trunk/Tools/WebKitTestRunner/Configurations/Base.xcconfig (254867 => 254868)


--- trunk/Tools/WebKitTestRunner/Configurations/Base.xcconfig	2020-01-21 19:36:52 UTC (rev 254867)
+++ trunk/Tools/WebKitTestRunner/Configurations/Base.xcconfig	2020-01-21 19:40:47 UTC (rev 254868)
@@ -87,7 +87,7 @@
 
 AD_HOC_CODE_SIGNING_ALLOWED = YES;
 
-SUPPORTED_PLATFORMS = iphoneos iphonesimulator macosx tvos tvsimulator watchos watchsimulator;
+SUPPORTED_PLATFORMS = iphoneos iphonesimulator macosx appletvos appletvsimulator watchos watchsimulator;
 
 SDKROOT = macosx.internal;
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to