Title: [254876] trunk/Source/WebKit
Revision
254876
Author
[email protected]
Date
2020-01-21 13:12:12 -0800 (Tue, 21 Jan 2020)

Log Message

Fix SDK availability macros
https://bugs.webkit.org/show_bug.cgi?id=206463
<rdar://problem/58581906>

Reviewed by Timothy Hatcher.

Bug 197841 updated WebKit.xcconfig with regards to when it runs a
header post-processing script. This post-processing script grovels
over our exported headers, changing macros like WK_API_AVAILABLE to
the standard API_AVAILABLE. Because of the change in Bug 197841, the
script was no longer being run when preparing macOS 10.15 SDKs, which
was breaking those SDKs. Fix this by reverting the change, allowing
the macros to be replaced for macOS 10.15.

No new tests - no added or changed functionality.

* Configurations/WebKit.xcconfig:

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (254875 => 254876)


--- trunk/Source/WebKit/ChangeLog	2020-01-21 21:08:55 UTC (rev 254875)
+++ trunk/Source/WebKit/ChangeLog	2020-01-21 21:12:12 UTC (rev 254876)
@@ -1,3 +1,23 @@
+2020-01-21  Keith Rollin  <[email protected]>
+
+        Fix SDK availability macros
+        https://bugs.webkit.org/show_bug.cgi?id=206463
+        <rdar://problem/58581906>
+
+        Reviewed by Timothy Hatcher.
+
+        Bug 197841 updated WebKit.xcconfig with regards to when it runs a
+        header post-processing script. This post-processing script grovels
+        over our exported headers, changing macros like WK_API_AVAILABLE to
+        the standard API_AVAILABLE. Because of the change in Bug 197841, the
+        script was no longer being run when preparing macOS 10.15 SDKs, which
+        was breaking those SDKs. Fix this by reverting the change, allowing
+        the macros to be replaced for macOS 10.15.
+
+        No new tests - no added or changed functionality.
+
+        * Configurations/WebKit.xcconfig:
+
 2020-01-21  Tim Horton  <[email protected]>
 
         macCatalyst: Two-finger click is dispatched to DOM as left click

Modified: trunk/Source/WebKit/Configurations/WebKit.xcconfig (254875 => 254876)


--- trunk/Source/WebKit/Configurations/WebKit.xcconfig	2020-01-21 21:08:55 UTC (rev 254875)
+++ trunk/Source/WebKit/Configurations/WebKit.xcconfig	2020-01-21 21:12:12 UTC (rev 254876)
@@ -156,8 +156,8 @@
 INSTALLHDRS_SCRIPT_PHASE = YES;
 APPLY_RULES_IN_COPY_HEADERS = $(USE_NEW_BUILD_SYSTEM);
 
-WK_FRAMEWORK_HEADER_POSTPROCESSING_DISABLED[sdk=macosx*] = $(WK_FRAMEWORK_HEADER_POSTPROCESSING_DISABLED$(WK_MACOS_1016));
-WK_FRAMEWORK_HEADER_POSTPROCESSING_DISABLED_MACOS_BEFORE_1016 = YES;
+WK_FRAMEWORK_HEADER_POSTPROCESSING_DISABLED[sdk=macosx*] = $(WK_FRAMEWORK_HEADER_POSTPROCESSING_DISABLED$(WK_MACOS_1015));
+WK_FRAMEWORK_HEADER_POSTPROCESSING_DISABLED_MACOS_BEFORE_1015 = YES;
 WK_FRAMEWORK_HEADER_POSTPROCESSING_DISABLED[sdk=iphone*] = $(WK_FRAMEWORK_HEADER_POSTPROCESSING_DISABLED$(WK_IOS_1013));
 WK_FRAMEWORK_HEADER_POSTPROCESSING_DISABLED_IOS_BEFORE_1300 = YES;
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to