Title: [254897] trunk/Source/WebKit
- Revision
- 254897
- Author
- [email protected]
- Date
- 2020-01-21 17:54:38 -0800 (Tue, 21 Jan 2020)
Log Message
[Win][WK2] Pressing space key on text input form scrolls the page
https://bugs.webkit.org/show_bug.cgi?id=201632
Reviewed by Ross Kirsling.
r223262 was add WebPage::performDefaultBehaviorForKeyEvent for
Windows port by copying GTK port's implementation. But, Windows
port is using unique key event processing. It dispatches
WebEvent::RawKeyDown and WebEvent::Char separately even though
other ports dispatch only WebEvent::KeyDown by unifying them.
Because WebPage::performDefaultBehaviorForKeyEvent handled
WebEvent::RawKeyDown of space key to scroll page, and consumed the
event, the keypress event of space key wasn't dispatched.
The keypress event of a space key is handled in
EventHandler::defaultSpaceEventHandler.
performDefaultBehaviorForKeyEvent don't need to do it.
Tests: Coverted by fast/events/space-scroll-event.html
* WebProcess/WebPage/win/WebPageWin.cpp:
(WebKit::WebPage::performDefaultBehaviorForKeyEvent): Don't handle VK_SPACE.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (254896 => 254897)
--- trunk/Source/WebKit/ChangeLog 2020-01-22 01:45:27 UTC (rev 254896)
+++ trunk/Source/WebKit/ChangeLog 2020-01-22 01:54:38 UTC (rev 254897)
@@ -1,3 +1,29 @@
+2020-01-21 Fujii Hironori <[email protected]>
+
+ [Win][WK2] Pressing space key on text input form scrolls the page
+ https://bugs.webkit.org/show_bug.cgi?id=201632
+
+ Reviewed by Ross Kirsling.
+
+ r223262 was add WebPage::performDefaultBehaviorForKeyEvent for
+ Windows port by copying GTK port's implementation. But, Windows
+ port is using unique key event processing. It dispatches
+ WebEvent::RawKeyDown and WebEvent::Char separately even though
+ other ports dispatch only WebEvent::KeyDown by unifying them.
+
+ Because WebPage::performDefaultBehaviorForKeyEvent handled
+ WebEvent::RawKeyDown of space key to scroll page, and consumed the
+ event, the keypress event of space key wasn't dispatched.
+
+ The keypress event of a space key is handled in
+ EventHandler::defaultSpaceEventHandler.
+ performDefaultBehaviorForKeyEvent don't need to do it.
+
+ Tests: Coverted by fast/events/space-scroll-event.html
+
+ * WebProcess/WebPage/win/WebPageWin.cpp:
+ (WebKit::WebPage::performDefaultBehaviorForKeyEvent): Don't handle VK_SPACE.
+
2020-01-21 Jiewen Tan <[email protected]>
[WebAuthn] Incorporate more detailed UnknownError messages for LocalAuthenticator
Modified: trunk/Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp (254896 => 254897)
--- trunk/Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp 2020-01-22 01:45:27 UTC (rev 254896)
+++ trunk/Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp 2020-01-22 01:54:38 UTC (rev 254897)
@@ -73,9 +73,6 @@
return false;
switch (keyboardEvent.windowsVirtualKeyCode()) {
- case VK_SPACE:
- scroll(m_page.get(), keyboardEvent.shiftKey() ? ScrollUp : ScrollDown, ScrollByPage);
- break;
case VK_LEFT:
scroll(m_page.get(), ScrollLeft, ScrollByLine);
break;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
