Title: [254925] trunk/Tools
- Revision
- 254925
- Author
- [email protected]
- Date
- 2020-01-22 08:59:30 -0800 (Wed, 22 Jan 2020)
Log Message
Test history links on the dashboard should go to the new results database
https://bugs.webkit.org/show_bug.cgi?id=205821
Reviewed by Jonathan Bedard.
Made changes to the various locations that we use the old database in the main dashboard
and test results pages.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
(ui.urlForFlakinessDashboard):
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
(ui.results.FlakinessData.base._handleMessage):
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitTestHistory.js:
(TestHistory):
(TestHistory.prototype.historyPageURLForTest):
* BuildSlaveSupport/build.webkit.org-config/templates/root.html:
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js (254924 => 254925)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js 2020-01-22 16:51:12 UTC (rev 254924)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js 2020-01-22 16:59:30 UTC (rev 254925)
@@ -207,7 +207,7 @@
// Check for null event.origin so that the unittests can get past this point.
// FIXME: Is this safe? In practice, there's no meaningful harm that can come from
// a malicious page sending us heightChanged commands, so it doesn't really matter.
- if (event.origin !== 'null' && event.origin != 'https://webkit-test-results.webkit.org') {
+ if (event.origin !== 'null' && event.origin != 'https://results.webkit.org') {
console.log('Invalid origin: ' + event.origin);
return;
}
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js (254924 => 254925)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js 2020-01-22 16:51:12 UTC (rev 254924)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js 2020-01-22 16:59:30 UTC (rev 254925)
@@ -47,7 +47,7 @@
ui.urlForFlakinessDashboard = function(opt_testNameList)
{
var testsParameter = opt_testNameList ? opt_testNameList.join(',') : '';
- return 'https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#tests=' + encodeURIComponent(testsParameter);
+ return 'https://results.webkit.org/?suite=layout-tests&test=' + encodeURIComponent(testsParameter);
}
ui.urlForEmbeddedFlakinessDashboard = function(opt_testNameList)
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitTestHistory.js (254924 => 254925)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitTestHistory.js 2020-01-22 16:51:12 UTC (rev 254924)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitTestHistory.js 2020-01-22 16:59:30 UTC (rev 254925)
@@ -25,7 +25,7 @@
TestHistory = function()
{
- this._baseURL = "https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html";
+ this._baseURL = "https://results.webkit.org";
};
BaseObject.addConstructorFunctions(TestHistory);
@@ -36,6 +36,6 @@
historyPageURLForTest: function(path)
{
- return this._baseURL + "#showAllRuns=true&tests=" + encodeURIComponent(path);
+ return this._baseURL + "?suite=layout-tests&test=" + encodeURIComponent(path);
}
};
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/templates/root.html (254924 => 254925)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/templates/root.html 2020-01-22 16:51:12 UTC (rev 254924)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/templates/root.html 2020-01-22 16:59:30 UTC (rev 254925)
@@ -37,7 +37,7 @@
<h2>Tests and Performance</h2>
<ul>
- <li><a href="" dashboard</a> (External site)</li>
+ <li><a href="" dashboard</a> (External site)</li>
<li><a href="" Viewer</a></li>
<li><a href="" Failures</a></li>
<li><a href="" Perf Monitor</a> results submitted by <a href="" bots</a></li>
Modified: trunk/Tools/ChangeLog (254924 => 254925)
--- trunk/Tools/ChangeLog 2020-01-22 16:51:12 UTC (rev 254924)
+++ trunk/Tools/ChangeLog 2020-01-22 16:59:30 UTC (rev 254925)
@@ -1,3 +1,22 @@
+2020-01-21 Matt Lewis <[email protected]>
+
+ Test history links on the dashboard should go to the new results database
+ https://bugs.webkit.org/show_bug.cgi?id=205821
+
+ Reviewed by Jonathan Bedard.
+
+ Made changes to the various locations that we use the old database in the main dashboard
+ and test results pages.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
+ (ui.urlForFlakinessDashboard):
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
+ (ui.results.FlakinessData.base._handleMessage):
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitTestHistory.js:
+ (TestHistory):
+ (TestHistory.prototype.historyPageURLForTest):
+ * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
+
2020-01-22 Antti Koivisto <[email protected]>
[LFC][Integration] Disable integration to see performance impact
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
