Title: [254953] trunk/Source/ThirdParty/ANGLE
- Revision
- 254953
- Author
- [email protected]
- Date
- 2020-01-22 16:27:43 -0800 (Wed, 22 Jan 2020)
Log Message
REGRESSION (r253926): webgl/1.0.3/conformance/rendering/many-draw-calls.html is much slower, times out in debug
https://bugs.webkit.org/show_bug.cgi?id=205668
Disable asserts when compiling ANGLE in release mode by defining
NDEBUG.
Patch by James Darpinian <[email protected]> on 2020-01-22
Reviewed by Dean Jackson.
* Configurations/ANGLE.xcconfig:
Modified Paths
Diff
Modified: trunk/Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj (254952 => 254953)
--- trunk/Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj 2020-01-23 00:24:24 UTC (rev 254952)
+++ trunk/Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj 2020-01-23 00:27:43 UTC (rev 254953)
@@ -3373,12 +3373,6 @@
isa = XCBuildConfiguration;
baseConfigurationReference = 5D7C59C51208C68B001C873E /* ANGLE.xcconfig */;
buildSettings = {
- GCC_PREPROCESSOR_DEFINITIONS = (
- ANGLE_ENABLE_OPENGL,
- ANGLE_ENABLE_GLSL,
- ANGLE_ENABLE_ESSL,
- GL_SILENCE_DEPRECATION,
- );
HEADER_SEARCH_PATHS = (
include,
src,
@@ -3408,12 +3402,6 @@
isa = XCBuildConfiguration;
baseConfigurationReference = 5D7C59C51208C68B001C873E /* ANGLE.xcconfig */;
buildSettings = {
- GCC_PREPROCESSOR_DEFINITIONS = (
- ANGLE_ENABLE_OPENGL,
- ANGLE_ENABLE_GLSL,
- ANGLE_ENABLE_ESSL,
- GL_SILENCE_DEPRECATION,
- );
HEADER_SEARCH_PATHS = (
include,
src,
@@ -3428,12 +3416,6 @@
isa = XCBuildConfiguration;
baseConfigurationReference = 5D7C59C51208C68B001C873E /* ANGLE.xcconfig */;
buildSettings = {
- GCC_PREPROCESSOR_DEFINITIONS = (
- ANGLE_ENABLE_OPENGL,
- ANGLE_ENABLE_GLSL,
- ANGLE_ENABLE_ESSL,
- GL_SILENCE_DEPRECATION,
- );
HEADER_SEARCH_PATHS = (
include,
src,
Modified: trunk/Source/ThirdParty/ANGLE/ChangeLog (254952 => 254953)
--- trunk/Source/ThirdParty/ANGLE/ChangeLog 2020-01-23 00:24:24 UTC (rev 254952)
+++ trunk/Source/ThirdParty/ANGLE/ChangeLog 2020-01-23 00:27:43 UTC (rev 254953)
@@ -1,3 +1,15 @@
+2020-01-22 James Darpinian <[email protected]>
+
+ REGRESSION (r253926): webgl/1.0.3/conformance/rendering/many-draw-calls.html is much slower, times out in debug
+ https://bugs.webkit.org/show_bug.cgi?id=205668
+
+ Disable asserts when compiling ANGLE in release mode by defining
+ NDEBUG.
+
+ Reviewed by Dean Jackson.
+
+ * Configurations/ANGLE.xcconfig:
+
2020-01-14 Dean Jackson <[email protected]>
Build ANGLE as a dynamic library
Modified: trunk/Source/ThirdParty/ANGLE/Configurations/ANGLE.xcconfig (254952 => 254953)
--- trunk/Source/ThirdParty/ANGLE/Configurations/ANGLE.xcconfig 2020-01-23 00:24:24 UTC (rev 254952)
+++ trunk/Source/ThirdParty/ANGLE/Configurations/ANGLE.xcconfig 2020-01-23 00:27:43 UTC (rev 254953)
@@ -12,3 +12,7 @@
HEADER_SEARCH_PATHS = include src src/common/third_party/numerics;
INSTALL_PATH = $(ANGLE_INSTALL_PATH_PREFIX)/usr/local/lib;
PUBLIC_HEADERS_FOLDER_PATH = $(ANGLE_INSTALL_PATH_PREFIX)/usr/local/include/ANGLE;
+
+DEBUG_DEFINES_debug = ;
+DEBUG_DEFINES_normal = NDEBUG;
+GCC_PREPROCESSOR_DEFINITIONS = $(DEBUG_DEFINES_$(CURRENT_VARIANT)) LIBGLESV2_IMPLEMENTATION LIBANGLE_IMPLEMENTATION ANGLE_ENABLE_OPENGL ANGLE_ENABLE_GLSL ANGLE_ENABLE_ESSL GL_SILENCE_DEPRECATION;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
