Title: [255019] branches/safari-609-branch/LayoutTests
Revision
255019
Author
[email protected]
Date
2020-01-23 13:44:04 -0800 (Thu, 23 Jan 2020)

Log Message

Cherry-pick r254705. rdar://problem/58811395

    REGRESSION: [ Mac WK2 ] fast/text/international/unicode-bidi-other-neutrals.html is a flaky failure
    https://bugs.webkit.org/show_bug.cgi?id=205808

    Patch by Doug Kelly <[email protected]> on 2020-01-16
    Reviewed by Maciej Stachowiak.

    Update the testcase for bidi text runs ending with other neutrals to dumpAsText, instead of trying
    to compare visual content.

    * fast/text/international/unicode-bidi-other-neutrals-expected.html: Removed.
    * fast/text/international/unicode-bidi-other-neutrals-expected.txt: Added.
    * fast/text/international/unicode-bidi-other-neutrals.html:

    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

Added Paths

Removed Paths

Diff

Modified: branches/safari-609-branch/LayoutTests/ChangeLog (255018 => 255019)


--- branches/safari-609-branch/LayoutTests/ChangeLog	2020-01-23 21:44:01 UTC (rev 255018)
+++ branches/safari-609-branch/LayoutTests/ChangeLog	2020-01-23 21:44:04 UTC (rev 255019)
@@ -1,5 +1,38 @@
 2020-01-23  Russell Epstein  <[email protected]>
 
+        Cherry-pick r254705. rdar://problem/58811395
+
+    REGRESSION: [ Mac WK2 ] fast/text/international/unicode-bidi-other-neutrals.html is a flaky failure
+    https://bugs.webkit.org/show_bug.cgi?id=205808
+    
+    Patch by Doug Kelly <[email protected]> on 2020-01-16
+    Reviewed by Maciej Stachowiak.
+    
+    Update the testcase for bidi text runs ending with other neutrals to dumpAsText, instead of trying
+    to compare visual content.
+    
+    * fast/text/international/unicode-bidi-other-neutrals-expected.html: Removed.
+    * fast/text/international/unicode-bidi-other-neutrals-expected.txt: Added.
+    * fast/text/international/unicode-bidi-other-neutrals.html:
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254705 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2020-01-16  Doug Kelly  <[email protected]>
+
+            REGRESSION: [ Mac WK2 ] fast/text/international/unicode-bidi-other-neutrals.html is a flaky failure
+            https://bugs.webkit.org/show_bug.cgi?id=205808
+
+            Reviewed by Maciej Stachowiak.
+
+            Update the testcase for bidi text runs ending with other neutrals to dumpAsText, instead of trying
+            to compare visual content.
+
+            * fast/text/international/unicode-bidi-other-neutrals-expected.html: Removed.
+            * fast/text/international/unicode-bidi-other-neutrals-expected.txt: Added.
+            * fast/text/international/unicode-bidi-other-neutrals.html:
+
+2020-01-23  Russell Epstein  <[email protected]>
+
         Cherry-pick r254652. rdar://problem/58811422
 
     Regression(r253213) Load hang and high CPU usage when trying to load myuhc.com

Deleted: branches/safari-609-branch/LayoutTests/fast/text/international/unicode-bidi-other-neutrals-expected.html (255018 => 255019)


--- branches/safari-609-branch/LayoutTests/fast/text/international/unicode-bidi-other-neutrals-expected.html	2020-01-23 21:44:01 UTC (rev 255018)
+++ branches/safari-609-branch/LayoutTests/fast/text/international/unicode-bidi-other-neutrals-expected.html	2020-01-23 21:44:04 UTC (rev 255019)
@@ -1,10 +0,0 @@
-<!DOCTYPE html>
-<html>
-  <head>
-    <meta charset="utf-8"/>
-  </head>
-  <body>
-    <font dir="ltr">a</font>
-    <marquee>b</marquee>
-  </body>
-</html>

Added: branches/safari-609-branch/LayoutTests/fast/text/international/unicode-bidi-other-neutrals-expected.txt (0 => 255019)


--- branches/safari-609-branch/LayoutTests/fast/text/international/unicode-bidi-other-neutrals-expected.txt	                        (rev 0)
+++ branches/safari-609-branch/LayoutTests/fast/text/international/unicode-bidi-other-neutrals-expected.txt	2020-01-23 21:44:04 UTC (rev 255019)
@@ -0,0 +1 @@
+This test verifies WebKit does not assert when encountering other neutrals at the end of a bidi text run. Test passes if WebKit does not assert in a development build. PASS

Modified: branches/safari-609-branch/LayoutTests/fast/text/international/unicode-bidi-other-neutrals.html (255018 => 255019)


--- branches/safari-609-branch/LayoutTests/fast/text/international/unicode-bidi-other-neutrals.html	2020-01-23 21:44:01 UTC (rev 255018)
+++ branches/safari-609-branch/LayoutTests/fast/text/international/unicode-bidi-other-neutrals.html	2020-01-23 21:44:04 UTC (rev 255019)
@@ -1,10 +1,16 @@
 <!DOCTYPE html>
 <html>
-  <head>
-    <meta charset="utf-8"/>
-  </head>
-  <body>
-    <font dir="ltr">a</font>
-    <marquee>b</marquee>
-  </body>
+    <head>
+        <meta charset="utf-8"/>
+        <script>
+            function testresult() {
+                if (window.testRunner)
+                    testRunner.dumpAsText();
+            }
+        </script>
+    </head>
+    <body _onload_="testresult();">
+        <font dir="ltr">This test verifies WebKit does not assert when encountering other neutrals at the end of a bidi text run.  Test passes if WebKit does not assert in a development build.</font>
+        <marquee>PASS</marquee>
+    </body>
 </html>
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to