Title: [255123] trunk/Tools
- Revision
- 255123
- Author
- aakash_j...@apple.com
- Date
- 2020-01-25 12:02:02 -0800 (Sat, 25 Jan 2020)
Log Message
webkit-patch upload should not submit automatically to old EWS
https://bugs.webkit.org/show_bug.cgi?id=206801
Reviewed by Alexey Proskuryakov.
* Scripts/webkitpy/tool/commands/upload_unittest.py:
* Scripts/webkitpy/tool/steps/submittoews.py:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (255122 => 255123)
--- trunk/Tools/ChangeLog 2020-01-25 19:14:22 UTC (rev 255122)
+++ trunk/Tools/ChangeLog 2020-01-25 20:02:02 UTC (rev 255123)
@@ -1,3 +1,13 @@
+2020-01-25 Aakash Jain <aakash_j...@apple.com>
+
+ webkit-patch upload should not submit automatically to old EWS
+ https://bugs.webkit.org/show_bug.cgi?id=206801
+
+ Reviewed by Alexey Proskuryakov.
+
+ * Scripts/webkitpy/tool/commands/upload_unittest.py:
+ * Scripts/webkitpy/tool/steps/submittoews.py:
+
2020-01-25 Per Arne Vollan <pvol...@apple.com>
[Cocoa] Media mime types map should be created in the UI process
Modified: trunk/Tools/Scripts/webkitpy/tool/commands/upload_unittest.py (255122 => 255123)
--- trunk/Tools/Scripts/webkitpy/tool/commands/upload_unittest.py 2020-01-25 19:14:22 UTC (rev 255122)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/upload_unittest.py 2020-01-25 20:02:02 UTC (rev 255123)
@@ -181,7 +181,6 @@
MOCK reassign_bug: bug_id=50000, assignee=None
MOCK add_patch_to_bug: bug_id=50000, description=MOCK description, mark_for_review=False, mark_for_commit_queue=False, mark_for_landing=False
MOCK: user.open_url: http://example.com/50000
-MOCK: submit_to_old_ews: 10001
MOCK: submit_to_ews: 10001
"""
self.assert_execute_outputs(Upload(), [50000], options=options, expected_logs=expected_logs)
@@ -204,8 +203,6 @@
Obsoleting 1 old patch on bug 50007
MOCK add_patch_to_bug: bug_id=50007, description=MOCK description, mark_for_review=False, mark_for_commit_queue=False, mark_for_landing=False
MOCK: user.open_url: http://example.com/50007
-MOCK: upload_attachment: 10008
-MOCK: submit_to_old_ews: 10008
MOCK: submit_to_ews: 10008
"""
self.assert_execute_outputs(Upload(), [50007], options=options, expected_logs=expected_logs)
Modified: trunk/Tools/Scripts/webkitpy/tool/steps/submittoews.py (255122 => 255123)
--- trunk/Tools/Scripts/webkitpy/tool/steps/submittoews.py 2020-01-25 19:14:22 UTC (rev 255122)
+++ trunk/Tools/Scripts/webkitpy/tool/steps/submittoews.py 2020-01-25 20:02:02 UTC (rev 255123)
@@ -35,10 +35,4 @@
def run(self, state):
for attachment_id in state.get('attachment_ids', []):
- attachment = self._tool.bugs.fetch_attachment(attachment_id)
- if not attachment:
- continue # Either Bugzilla is down or we do not have permission to view the attachment.
- if attachment.bug().is_security_sensitive():
- self._tool.status_server.upload_attachment(attachment)
- self._tool.status_server.submit_to_ews(attachment_id)
self._tool.ews_server.submit_to_ews(attachment_id)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
