Title: [255137] trunk/Source/WebKit
- Revision
- 255137
- Author
- [email protected]
- Date
- 2020-01-26 22:30:44 -0800 (Sun, 26 Jan 2020)
Log Message
[WinCairo][curl] ASSERTION FAILED: sessionID != PAL::SessionID::defaultSessionID() in NetworkProcess since r255067
https://bugs.webkit.org/show_bug.cgi?id=206817
Reviewed by Darin Adler.
Since r255067 (Bug 206700), the assertion is failing in
NetworkProcess::destroySession while shutdown, which is ensuring
the destructing session isn't the default session.
Covered by existing tests.
* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::destroySession): Conditioned out the
assertion for curl port as well as Soup port does.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (255136 => 255137)
--- trunk/Source/WebKit/ChangeLog 2020-01-27 06:27:38 UTC (rev 255136)
+++ trunk/Source/WebKit/ChangeLog 2020-01-27 06:30:44 UTC (rev 255137)
@@ -1,3 +1,20 @@
+2020-01-26 Fujii Hironori <[email protected]>
+
+ [WinCairo][curl] ASSERTION FAILED: sessionID != PAL::SessionID::defaultSessionID() in NetworkProcess since r255067
+ https://bugs.webkit.org/show_bug.cgi?id=206817
+
+ Reviewed by Darin Adler.
+
+ Since r255067 (Bug 206700), the assertion is failing in
+ NetworkProcess::destroySession while shutdown, which is ensuring
+ the destructing session isn't the default session.
+
+ Covered by existing tests.
+
+ * NetworkProcess/NetworkProcess.cpp:
+ (WebKit::NetworkProcess::destroySession): Conditioned out the
+ assertion for curl port as well as Soup port does.
+
2020-01-26 Chris Dumez <[email protected]>
Frequent sync BackForwardBackListCount/BackForwardForwardListCount IPC on reddit.com
Modified: trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp (255136 => 255137)
--- trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp 2020-01-27 06:27:38 UTC (rev 255136)
+++ trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp 2020-01-27 06:30:44 UTC (rev 255137)
@@ -565,8 +565,8 @@
void NetworkProcess::destroySession(PAL::SessionID sessionID)
{
ASSERT(RunLoop::isMain());
-#if !USE(SOUP)
- // Soup based ports destroy the default session right before the process exits to avoid leaking
+#if !USE(SOUP) && !USE(CURL)
+ // cURL and Soup based ports destroy the default session right before the process exits to avoid leaking
// network resources like the cookies database.
ASSERT(sessionID != PAL::SessionID::defaultSessionID());
#endif
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
