Title: [255145] trunk/Source/_javascript_Core
- Revision
- 255145
- Author
- [email protected]
- Date
- 2020-01-27 08:00:21 -0800 (Mon, 27 Jan 2020)
Log Message
Remove internal fields in promise assertion for 32bits
https://bugs.webkit.org/show_bug.cgi?id=206823
Patch by Paulo Matos <[email protected]> on 2020-01-27
Reviewed by Mark Lam.
This assertion was removed for 64bits under bug 201159 but left around
in 32bits.
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_get_internal_field):
(JSC::JIT::emit_op_put_internal_field):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (255144 => 255145)
--- trunk/Source/_javascript_Core/ChangeLog 2020-01-27 15:44:25 UTC (rev 255144)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-01-27 16:00:21 UTC (rev 255145)
@@ -1,3 +1,17 @@
+2020-01-27 Paulo Matos <[email protected]>
+
+ Remove internal fields in promise assertion for 32bits
+ https://bugs.webkit.org/show_bug.cgi?id=206823
+
+ Reviewed by Mark Lam.
+
+ This assertion was removed for 64bits under bug 201159 but left around
+ in 32bits.
+
+ * jit/JITPropertyAccess32_64.cpp:
+ (JSC::JIT::emit_op_get_internal_field):
+ (JSC::JIT::emit_op_put_internal_field):
+
2020-01-26 Alexey Shvayka <[email protected]>
Invalid ranges in character classes should be banned in unicode patterns
Modified: trunk/Source/_javascript_Core/jit/JITPropertyAccess32_64.cpp (255144 => 255145)
--- trunk/Source/_javascript_Core/jit/JITPropertyAccess32_64.cpp 2020-01-27 15:44:25 UTC (rev 255144)
+++ trunk/Source/_javascript_Core/jit/JITPropertyAccess32_64.cpp 2020-01-27 16:00:21 UTC (rev 255145)
@@ -1137,7 +1137,6 @@
VirtualRegister dst = bytecode.m_dst;
VirtualRegister base = bytecode.m_base;
unsigned index = bytecode.m_index;
- ASSERT(index < JSPromise::numberOfInternalFields);
emitLoadPayload(base, regT2);
load32(Address(regT2, JSInternalFieldObjectImpl<>::offsetOfInternalField(index) + TagOffset), regT1);
@@ -1152,7 +1151,6 @@
VirtualRegister base = bytecode.m_base;
VirtualRegister value = bytecode.m_value;
unsigned index = bytecode.m_index;
- ASSERT(index < JSPromise::numberOfInternalFields);
emitLoadPayload(base, regT0);
emitLoad(value, regT1, regT2);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
