Title: [255147] trunk/Source/WebKit
Revision
255147
Author
[email protected]
Date
2020-01-27 08:28:30 -0800 (Mon, 27 Jan 2020)

Log Message

NetworkProcessProxy: MESSAGE_CHECK identifiers sent over IPC
https://bugs.webkit.org/show_bug.cgi?id=206814
<rdar://problem/58783422>

Reviewed by David Kilzer.

MESSAGE_CHECK identifiers sent over IPC in NetworkProcessProxy class.

* UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::didFetchWebsiteData):
(WebKit::NetworkProcessProxy::didDeleteWebsiteData):
(WebKit::NetworkProcessProxy::didDeleteWebsiteDataForOrigins):

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (255146 => 255147)


--- trunk/Source/WebKit/ChangeLog	2020-01-27 16:16:22 UTC (rev 255146)
+++ trunk/Source/WebKit/ChangeLog	2020-01-27 16:28:30 UTC (rev 255147)
@@ -1,3 +1,18 @@
+2020-01-27  Chris Dumez  <[email protected]>
+
+        NetworkProcessProxy: MESSAGE_CHECK identifiers sent over IPC
+        https://bugs.webkit.org/show_bug.cgi?id=206814
+        <rdar://problem/58783422>
+
+        Reviewed by David Kilzer.
+
+        MESSAGE_CHECK identifiers sent over IPC in NetworkProcessProxy class.
+
+        * UIProcess/Network/NetworkProcessProxy.cpp:
+        (WebKit::NetworkProcessProxy::didFetchWebsiteData):
+        (WebKit::NetworkProcessProxy::didDeleteWebsiteData):
+        (WebKit::NetworkProcessProxy::didDeleteWebsiteDataForOrigins):
+
 2020-01-26  Fujii Hironori  <[email protected]>
 
         [WinCairo][curl] ASSERTION FAILED: sessionID != PAL::SessionID::defaultSessionID() in NetworkProcess since r255067

Modified: trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp (255146 => 255147)


--- trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp	2020-01-27 16:16:22 UTC (rev 255146)
+++ trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp	2020-01-27 16:28:30 UTC (rev 255147)
@@ -370,6 +370,7 @@
 
 void NetworkProcessProxy::didFetchWebsiteData(uint64_t callbackID, const WebsiteData& websiteData)
 {
+    MESSAGE_CHECK(m_pendingFetchWebsiteDataCallbacks.isValidKey(callbackID));
     auto callback = m_pendingFetchWebsiteDataCallbacks.take(callbackID);
     callback(websiteData);
 }
@@ -376,6 +377,7 @@
 
 void NetworkProcessProxy::didDeleteWebsiteData(uint64_t callbackID)
 {
+    MESSAGE_CHECK(m_pendingDeleteWebsiteDataCallbacks.isValidKey(callbackID));
     auto callback = m_pendingDeleteWebsiteDataCallbacks.take(callbackID);
     callback();
 }
@@ -382,6 +384,7 @@
 
 void NetworkProcessProxy::didDeleteWebsiteDataForOrigins(uint64_t callbackID)
 {
+    MESSAGE_CHECK(m_pendingDeleteWebsiteDataForOriginsCallbacks.isValidKey(callbackID));
     auto callback = m_pendingDeleteWebsiteDataForOriginsCallbacks.take(callbackID);
     callback();
 }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to