Title: [255154] trunk/LayoutTests
- Revision
- 255154
- Author
- [email protected]
- Date
- 2020-01-27 10:54:13 -0800 (Mon, 27 Jan 2020)
Log Message
REGRESSION: [ Mac Debug WK1 ] inspector/page/overrideSetting-ICECandidateFilteringEnabled.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=206362
<rdar://problem/58649476>
Reviewed by Brian Burg.
Tentative fix. Modifying the `iceCandidateFilteringEnabled` WebCore setting causes any
existing/pending ICE candidates to immediately fire `icecandidate` events. Wait to change
the setting using `Page.overrideSetting` until after the _javascript_ has set up the various
connections so that it's guaranteed to not miss any `icecandidate` events. Additionally
remove the default 10s timeout in case the debug build is too slow.
* inspector/page/overrideSetting-ICECandidateFilteringEnabled.html:
* inspector/page/overrideSetting-ICECandidateFilteringEnabled-expected.txt:
* platform/mac-wk1/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (255153 => 255154)
--- trunk/LayoutTests/ChangeLog 2020-01-27 18:39:00 UTC (rev 255153)
+++ trunk/LayoutTests/ChangeLog 2020-01-27 18:54:13 UTC (rev 255154)
@@ -1,3 +1,21 @@
+2020-01-27 Devin Rousso <[email protected]>
+
+ REGRESSION: [ Mac Debug WK1 ] inspector/page/overrideSetting-ICECandidateFilteringEnabled.html is a flaky failure
+ https://bugs.webkit.org/show_bug.cgi?id=206362
+ <rdar://problem/58649476>
+
+ Reviewed by Brian Burg.
+
+ Tentative fix. Modifying the `iceCandidateFilteringEnabled` WebCore setting causes any
+ existing/pending ICE candidates to immediately fire `icecandidate` events. Wait to change
+ the setting using `Page.overrideSetting` until after the _javascript_ has set up the various
+ connections so that it's guaranteed to not miss any `icecandidate` events. Additionally
+ remove the default 10s timeout in case the debug build is too slow.
+
+ * inspector/page/overrideSetting-ICECandidateFilteringEnabled.html:
+ * inspector/page/overrideSetting-ICECandidateFilteringEnabled-expected.txt:
+ * platform/mac-wk1/TestExpectations:
+
2020-01-27 Chris Dumez <[email protected]>
REGRESSION: [Mac wk2] fast/animation/request-animation-frame.html is flaky failing
Modified: trunk/LayoutTests/inspector/page/overrideSetting-ICECandidateFilteringEnabled-expected.txt (255153 => 255154)
--- trunk/LayoutTests/inspector/page/overrideSetting-ICECandidateFilteringEnabled-expected.txt 2020-01-27 18:39:00 UTC (rev 255153)
+++ trunk/LayoutTests/inspector/page/overrideSetting-ICECandidateFilteringEnabled-expected.txt 2020-01-27 18:54:13 UTC (rev 255154)
@@ -3,7 +3,6 @@
== Running test suite: Page.overrideSetting
-- Running test case: Page.overrideSetting.ICECandidateFilteringEnabled
-Overriding ICECandidateFilteringEnabled to false...
Creating data channel...
PASS: created offer
PASS: received ICE candidate.
Modified: trunk/LayoutTests/inspector/page/overrideSetting-ICECandidateFilteringEnabled.html (255153 => 255154)
--- trunk/LayoutTests/inspector/page/overrideSetting-ICECandidateFilteringEnabled.html 2020-01-27 18:39:00 UTC (rev 255153)
+++ trunk/LayoutTests/inspector/page/overrideSetting-ICECandidateFilteringEnabled.html 2020-01-27 18:54:13 UTC (rev 255154)
@@ -49,15 +49,14 @@
name: "Page.overrideSetting.ICECandidateFilteringEnabled",
description: "Test that changing whether ice candidate filtering is enabled has an effect.",
async test() {
- InspectorTest.log("Overriding ICECandidateFilteringEnabled to false...");
- await PageAgent.overrideSetting(InspectorBackend.Enum.Page.Setting.ICECandidateFilteringEnabled, false);
-
let [overriddenResult] = await Promise.all([
InspectorTest.awaitEvent("DataChannel"),
InspectorTest.evaluateInPage(`createDataChannel()`),
- ])
+ PageAgent.overrideSetting(InspectorBackend.Enum.Page.Setting.ICECandidateFilteringEnabled, false),
+ ]);
InspectorTest.expectThat(overriddenResult.data.success, "Should be able to establish a connection when filtering ice candidates.");
},
+ timeout: -1,
});
suite.runTestCasesAndFinish();
Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (255153 => 255154)
--- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2020-01-27 18:39:00 UTC (rev 255153)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2020-01-27 18:54:13 UTC (rev 255154)
@@ -849,6 +849,4 @@
webkit.org/b/199117 [ Debug ] storage/indexeddb/modern/objectstore-autoincrement-types.html [ Timeout ]
-webkit.org/b/206362 [ Debug ] inspector/page/overrideSetting-ICECandidateFilteringEnabled.html [ Failure Pass ]
-
webkit.org/b/206503 [ Mojave ] imported/w3c/web-platform-tests/html/dom/idlharness.worker.html [ Failure ]
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
