Title: [255157] trunk/Tools
- Revision
- 255157
- Author
- [email protected]
- Date
- 2020-01-27 11:33:06 -0800 (Mon, 27 Jan 2020)
Log Message
[ews] Status bubble hover over message in case of success should indicate whether it built the patch or run tests
https://bugs.webkit.org/show_bug.cgi?id=206807
Reviewed by Jonathan Bedard.
* BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py (255156 => 255157)
--- trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py 2020-01-27 19:16:23 UTC (rev 255156)
+++ trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py 2020-01-27 19:33:06 UTC (rev 255157)
@@ -65,10 +65,12 @@
bubble = {
'name': queue,
}
+ is_tester_queue = self._is_tester_queue(queue)
+ is_builder_queue = self._is_builder_queue(queue)
if hide_icons == False:
- if self._is_tester_queue(queue):
+ if is_tester_queue:
bubble['name'] = StatusBubble.TESTER_ICON + ' ' + bubble['name']
- if self._is_builder_queue(queue):
+ if is_builder_queue:
bubble['name'] = StatusBubble.BUILDER_ICON + ' ' + bubble['name']
builds, is_parent_build = self.get_all_builds_for_queue(patch, queue, self._get_parent_queue(queue))
@@ -110,7 +112,17 @@
bubble['details_message'] = 'Build is in-progress. Recent messages:' + self._steps_messages_from_multiple_builds(builds) + '\n\nWaiting to run tests.'
else:
bubble['state'] = 'pass'
- bubble['details_message'] = 'Pass'
+ if is_builder_queue and is_tester_queue:
+ bubble['details_message'] = 'Built successfully and passed tests'
+ elif is_builder_queue:
+ bubble['details_message'] = 'Built successfully'
+ elif is_tester_queue:
+ if queue == 'style':
+ bubble['details_message'] = 'Passed style check'
+ else:
+ bubble['details_message'] = 'Passed tests'
+ else:
+ bubble['details_message'] = 'Pass'
elif build.result == Buildbot.WARNINGS:
bubble['state'] = 'pass'
bubble['details_message'] = 'Warning' + self._steps_messages_from_multiple_builds(builds)
Modified: trunk/Tools/ChangeLog (255156 => 255157)
--- trunk/Tools/ChangeLog 2020-01-27 19:16:23 UTC (rev 255156)
+++ trunk/Tools/ChangeLog 2020-01-27 19:33:06 UTC (rev 255157)
@@ -1,3 +1,12 @@
+2020-01-26 Aakash Jain <[email protected]>
+
+ [ews] Status bubble hover over message in case of success should indicate whether it built the patch or run tests
+ https://bugs.webkit.org/show_bug.cgi?id=206807
+
+ Reviewed by Jonathan Bedard.
+
+ * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
+
2020-01-27 Kate Cheney <[email protected]>
Delete the ITP storage file that is not being used (plist or database file) when switching to a new storage type
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
