Title: [255166] trunk/LayoutTests/imported/w3c
- Revision
- 255166
- Author
- [email protected]
- Date
- 2020-01-27 13:29:19 -0800 (Mon, 27 Jan 2020)
Log Message
[iOS Release and Mac Release] imported/w3c/web-platform-tests/webrtc/RTCDTMFSender-ontonechange.https.html is flaky failing
https://bugs.webkit.org/show_bug.cgi?id=206683
<rdar://problem/58841339>
Reviewed by Eric Carlson.
* web-platform-tests/webrtc/RTCDTMFSender-helper.js:
Move from async_test to promise_test to improve repeatability of the tests.
Modified Paths
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (255165 => 255166)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2020-01-27 21:29:11 UTC (rev 255165)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2020-01-27 21:29:19 UTC (rev 255166)
@@ -1,3 +1,14 @@
+2020-01-27 youenn fablet <[email protected]>
+
+ [iOS Release and Mac Release] imported/w3c/web-platform-tests/webrtc/RTCDTMFSender-ontonechange.https.html is flaky failing
+ https://bugs.webkit.org/show_bug.cgi?id=206683
+ <rdar://problem/58841339>
+
+ Reviewed by Eric Carlson.
+
+ * web-platform-tests/webrtc/RTCDTMFSender-helper.js:
+ Move from async_test to promise_test to improve repeatability of the tests.
+
2020-01-27 Antoine Quint <[email protected]>
[Web Animations] Add support for the options parameter to getAnimations()
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCDTMFSender-helper.js (255165 => 255166)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCDTMFSender-helper.js 2020-01-27 21:29:11 UTC (rev 255165)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCDTMFSender-helper.js 2020-01-27 21:29:19 UTC (rev 255166)
@@ -78,7 +78,12 @@
Test description.
*/
function test_tone_change_events(testFunc, toneChanges, desc) {
- async_test(t => {
+ promise_test(t => {
+ let done, fail;
+ const promise = new Promise((resolve, reject) => {
+ done = resolve;
+ fail = reject;
+ });
const pc = new RTCPeerConnection();
createDtmfSender(pc)
@@ -124,7 +129,7 @@
// in which case the test should fail.
t.step_timeout(
t.step_func(() => {
- t.done();
+ done();
pc.close();
pc.otherPc.close();
}), expectedDuration + 100);
@@ -137,6 +142,7 @@
.catch(t.step_func(err => {
assert_unreached(`Unexpected promise rejection: ${err}`);
}));
+ return promise;
}, desc);
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
