Title: [255275] branches/safari-610.1.1-branch/LayoutTests
- Revision
- 255275
- Author
- [email protected]
- Date
- 2020-01-28 13:48:32 -0800 (Tue, 28 Jan 2020)
Log Message
Cherry-pick r254437. rdar://problem/58060387
[iOS] editing/selection/ios/clear-selection-after-tap-in-large-selected-non-editable-text.html times out
https://bugs.webkit.org/show_bug.cgi?id=206126
<rdar://problem/58060387>
Reviewed by Tim Horton.
This test is intended to verify that when ranged selection UI covers up most of the view, tapping the selection
will clear the selection instead of toggling the callout bar. However, there are a couple of issues that make
this test fail:
- The long press that is intended to select text ends up under the "Sel" in select and above the "ect" that
wraps to the next line, which causes the word to not be selected. To fix this, I changed the tap location from
the center of the view to somewhere in the top half of the view, near the middle of "Sel".
- The callout bar appears in the center of the screen with the "Look up" action in the middle, so tapping the
center of the view again causes a view controller to be presented when looking up the selected word ("Select").
We can avoid this by also moving the tap location away from the center of the view.
- On iPad, the word "Select" isn't big enough to encompass most of the screen even at 250px, so the test fails.
We fix this by making the "Select" text much bigger (500px), and then make the body `overflow: hidden` so that
selecting the word on iPhone's smaller screen doesn't cause scrolling.
* editing/selection/ios/clear-selection-after-tap-in-large-selected-non-editable-text.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254437 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
Diff
Modified: branches/safari-610.1.1-branch/LayoutTests/ChangeLog (255274 => 255275)
--- branches/safari-610.1.1-branch/LayoutTests/ChangeLog 2020-01-28 21:46:43 UTC (rev 255274)
+++ branches/safari-610.1.1-branch/LayoutTests/ChangeLog 2020-01-28 21:48:32 UTC (rev 255275)
@@ -1,3 +1,60 @@
+2020-01-28 Russell Epstein <[email protected]>
+
+ Cherry-pick r254437. rdar://problem/58060387
+
+ [iOS] editing/selection/ios/clear-selection-after-tap-in-large-selected-non-editable-text.html times out
+ https://bugs.webkit.org/show_bug.cgi?id=206126
+ <rdar://problem/58060387>
+
+ Reviewed by Tim Horton.
+
+ This test is intended to verify that when ranged selection UI covers up most of the view, tapping the selection
+ will clear the selection instead of toggling the callout bar. However, there are a couple of issues that make
+ this test fail:
+
+ - The long press that is intended to select text ends up under the "Sel" in select and above the "ect" that
+ wraps to the next line, which causes the word to not be selected. To fix this, I changed the tap location from
+ the center of the view to somewhere in the top half of the view, near the middle of "Sel".
+
+ - The callout bar appears in the center of the screen with the "Look up" action in the middle, so tapping the
+ center of the view again causes a view controller to be presented when looking up the selected word ("Select").
+ We can avoid this by also moving the tap location away from the center of the view.
+
+ - On iPad, the word "Select" isn't big enough to encompass most of the screen even at 250px, so the test fails.
+ We fix this by making the "Select" text much bigger (500px), and then make the body `overflow: hidden` so that
+ selecting the word on iPhone's smaller screen doesn't cause scrolling.
+
+ * editing/selection/ios/clear-selection-after-tap-in-large-selected-non-editable-text.html:
+
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254437 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2020-01-13 Wenson Hsieh <[email protected]>
+
+ [iOS] editing/selection/ios/clear-selection-after-tap-in-large-selected-non-editable-text.html times out
+ https://bugs.webkit.org/show_bug.cgi?id=206126
+ <rdar://problem/58060387>
+
+ Reviewed by Tim Horton.
+
+ This test is intended to verify that when ranged selection UI covers up most of the view, tapping the selection
+ will clear the selection instead of toggling the callout bar. However, there are a couple of issues that make
+ this test fail:
+
+ - The long press that is intended to select text ends up under the "Sel" in select and above the "ect" that
+ wraps to the next line, which causes the word to not be selected. To fix this, I changed the tap location from
+ the center of the view to somewhere in the top half of the view, near the middle of "Sel".
+
+ - The callout bar appears in the center of the screen with the "Look up" action in the middle, so tapping the
+ center of the view again causes a view controller to be presented when looking up the selected word ("Select").
+ We can avoid this by also moving the tap location away from the center of the view.
+
+ - On iPad, the word "Select" isn't big enough to encompass most of the screen even at 250px, so the test fails.
+ We fix this by making the "Select" text much bigger (500px), and then make the body `overflow: hidden` so that
+ selecting the word on iPhone's smaller screen doesn't cause scrolling.
+
+ * editing/selection/ios/clear-selection-after-tap-in-large-selected-non-editable-text.html:
+
2020-01-15 Kocsen Chung <[email protected]>
Revert r254379. rdar://problem/58542040
Modified: branches/safari-610.1.1-branch/LayoutTests/editing/selection/ios/clear-selection-after-tap-in-large-selected-non-editable-text.html (255274 => 255275)
--- branches/safari-610.1.1-branch/LayoutTests/editing/selection/ios/clear-selection-after-tap-in-large-selected-non-editable-text.html 2020-01-28 21:46:43 UTC (rev 255274)
+++ branches/safari-610.1.1-branch/LayoutTests/editing/selection/ios/clear-selection-after-tap-in-large-selected-non-editable-text.html 2020-01-28 21:48:32 UTC (rev 255275)
@@ -10,10 +10,11 @@
width: 100%;
height: 100%;
margin: 0;
+ overflow: hidden;
}
#text {
- font-size: 250px;
+ font-size: 500px;
margin-top: 0;
word-wrap: break-word;
}
@@ -26,12 +27,12 @@
const text = document.getElementById("text");
- await UIHelper.longPressElement(text);
+ await UIHelper.longPressAtPoint(160, 150);
await UIHelper.waitForSelectionToAppear();
testPassed("Observed selection.");
await UIHelper.waitForDoubleTapDelay();
- await UIHelper.activateElement(text);
+ await UIHelper.activateAt(160, 150);
await UIHelper.waitForSelectionToDisappear();
testPassed("Dismissed selection.");
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
