[webkit-changes] [255277] branches/safari-610.1.1-branch

Tue, 28 Jan 2020 13:49:22 -0800

Title: [255277] branches/safari-610.1.1-branch
Revision
255277
Author
[email protected]
Date
2020-01-28 13:48:38 -0800 (Tue, 28 Jan 2020)

Log Message

Cherry-pick r254492. rdar://problem/58037745

    Scrollbar hiding on iOS via ::-webkit-scrollbar { display: none } doesn't work
    https://bugs.webkit.org/show_bug.cgi?id=206197

    Reviewed by Tim Horton.
    Source/WebCore:

    The logic added in r251369 was reversed, causing scrollbar hiding to not work correctly.

    Tested by fast/scrolling/ios/scrollbar-hiding.html

    * rendering/RenderScrollbar.cpp:
    (WebCore::RenderScrollbar::isHiddenByStyle const):

    LayoutTests:

    The logic added in r251369 was reversed, causing scrollbar hiding to not work correctly.

    * fast/scrolling/ios/scrollbar-hiding-expected.txt:

    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

Diff

Modified: branches/safari-610.1.1-branch/LayoutTests/ChangeLog (255276 => 255277)


--- branches/safari-610.1.1-branch/LayoutTests/ChangeLog	2020-01-28 21:48:35 UTC (rev 255276)
+++ branches/safari-610.1.1-branch/LayoutTests/ChangeLog	2020-01-28 21:48:38 UTC (rev 255277)
@@ -1,5 +1,42 @@
 2020-01-28  Russell Epstein  <[email protected]>
 
+        Cherry-pick r254492. rdar://problem/58037745
+
+    Scrollbar hiding on iOS via ::-webkit-scrollbar { display: none } doesn't work
+    https://bugs.webkit.org/show_bug.cgi?id=206197
+    
+    Reviewed by Tim Horton.
+    Source/WebCore:
+    
+    The logic added in r251369 was reversed, causing scrollbar hiding to not work correctly.
+    
+    Tested by fast/scrolling/ios/scrollbar-hiding.html
+    
+    * rendering/RenderScrollbar.cpp:
+    (WebCore::RenderScrollbar::isHiddenByStyle const):
+    
+    LayoutTests:
+    
+    The logic added in r251369 was reversed, causing scrollbar hiding to not work correctly.
+    
+    * fast/scrolling/ios/scrollbar-hiding-expected.txt:
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254492 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2020-01-13  Simon Fraser  <[email protected]>
+
+            Scrollbar hiding on iOS via ::-webkit-scrollbar { display: none } doesn't work
+            https://bugs.webkit.org/show_bug.cgi?id=206197
+
+            Reviewed by Tim Horton.
+
+            The logic added in r251369 was reversed, causing scrollbar hiding to not work correctly.
+
+            * fast/scrolling/ios/scrollbar-hiding-expected.txt:
+
+2020-01-28  Russell Epstein  <[email protected]>
+
         Cherry-pick r254437. rdar://problem/58060387
 
     [iOS] editing/selection/ios/clear-selection-after-tap-in-large-selected-non-editable-text.html times out

Modified: branches/safari-610.1.1-branch/LayoutTests/fast/scrolling/ios/scrollbar-hiding-expected.txt (255276 => 255277)


--- branches/safari-610.1.1-branch/LayoutTests/fast/scrolling/ios/scrollbar-hiding-expected.txt	2020-01-28 21:48:35 UTC (rev 255276)
+++ branches/safari-610.1.1-branch/LayoutTests/fast/scrolling/ios/scrollbar-hiding-expected.txt	2020-01-28 21:48:38 UTC (rev 255277)
@@ -35,9 +35,7 @@
         (horizontal scrollbar mode 0)
         (vertical scrollbar mode 0)
         (has enabled horizontal scrollbar 1)
-        (has enabled vertical scrollbar 1)
-        (horizontal scrollbar hidden by style 1)
-        (vertical scrollbar hidden by style 1)))
+        (has enabled vertical scrollbar 1)))
     (overflow scrolling node
       (scrollable area size width=200 height=100)
       (total content size width=400 height=200)
@@ -49,7 +47,7 @@
         (vertical scrollbar mode 0)
         (has enabled horizontal scrollbar 1)
         (has enabled vertical scrollbar 1)
-        (horizontal scrollbar hidden by style 1)))
+        (vertical scrollbar hidden by style 1)))
     (overflow scrolling node
       (scrollable area size width=200 height=100)
       (total content size width=400 height=200)
@@ -61,7 +59,7 @@
         (vertical scrollbar mode 0)
         (has enabled horizontal scrollbar 1)
         (has enabled vertical scrollbar 1)
-        (vertical scrollbar hidden by style 1)))
+        (horizontal scrollbar hidden by style 1)))
     (overflow scrolling node
       (scrollable area size width=200 height=100)
       (total content size width=400 height=200)
@@ -72,4 +70,6 @@
         (horizontal scrollbar mode 0)
         (vertical scrollbar mode 0)
         (has enabled horizontal scrollbar 1)
-        (has enabled vertical scrollbar 1)))))
+        (has enabled vertical scrollbar 1)
+        (horizontal scrollbar hidden by style 1)
+        (vertical scrollbar hidden by style 1)))))

Modified: branches/safari-610.1.1-branch/Source/WebCore/ChangeLog (255276 => 255277)


--- branches/safari-610.1.1-branch/Source/WebCore/ChangeLog	2020-01-28 21:48:35 UTC (rev 255276)
+++ branches/safari-610.1.1-branch/Source/WebCore/ChangeLog	2020-01-28 21:48:38 UTC (rev 255277)
@@ -1,3 +1,43 @@
+2020-01-28  Russell Epstein  <[email protected]>
+
+        Cherry-pick r254492. rdar://problem/58037745
+
+    Scrollbar hiding on iOS via ::-webkit-scrollbar { display: none } doesn't work
+    https://bugs.webkit.org/show_bug.cgi?id=206197
+    
+    Reviewed by Tim Horton.
+    Source/WebCore:
+    
+    The logic added in r251369 was reversed, causing scrollbar hiding to not work correctly.
+    
+    Tested by fast/scrolling/ios/scrollbar-hiding.html
+    
+    * rendering/RenderScrollbar.cpp:
+    (WebCore::RenderScrollbar::isHiddenByStyle const):
+    
+    LayoutTests:
+    
+    The logic added in r251369 was reversed, causing scrollbar hiding to not work correctly.
+    
+    * fast/scrolling/ios/scrollbar-hiding-expected.txt:
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254492 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2020-01-13  Simon Fraser  <[email protected]>
+
+            Scrollbar hiding on iOS via ::-webkit-scrollbar { display: none } doesn't work
+            https://bugs.webkit.org/show_bug.cgi?id=206197
+
+            Reviewed by Tim Horton.
+
+            The logic added in r251369 was reversed, causing scrollbar hiding to not work correctly.
+
+            Tested by fast/scrolling/ios/scrollbar-hiding.html
+
+            * rendering/RenderScrollbar.cpp:
+            (WebCore::RenderScrollbar::isHiddenByStyle const):
+
 2020-01-16  Alan Coon  <[email protected]>
 
         Cherry-pick r254692. rdar://problem/58480028

Modified: branches/safari-610.1.1-branch/Source/WebCore/rendering/RenderScrollbar.cpp (255276 => 255277)


--- branches/safari-610.1.1-branch/Source/WebCore/rendering/RenderScrollbar.cpp	2020-01-28 21:48:35 UTC (rev 255276)
+++ branches/safari-610.1.1-branch/Source/WebCore/rendering/RenderScrollbar.cpp	2020-01-28 21:48:38 UTC (rev 255277)
@@ -363,7 +363,7 @@
 bool RenderScrollbar::isHiddenByStyle() const
 {
     std::unique_ptr<RenderStyle> partStyle = getScrollbarPseudoStyle(ScrollbarBGPart, pseudoForScrollbarPart(ScrollbarBGPart));
-    return partStyle && partStyle->display() != DisplayType::None;
+    return partStyle && partStyle->display() == DisplayType::None;
 }
 
 }

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to