Title: [255331] trunk/LayoutTests
Revision
255331
Author
[email protected]
Date
2020-01-28 17:57:25 -0800 (Tue, 28 Jan 2020)

Log Message

REGRESSION: [ Mac ] fast/hidpi/image-srcset-relative-svg-canvas-2x.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=206254
<rdar://problem/58580461>

Reviewed by Simon Fraser.

The drawImage() and the HTML document layout are racy here and when we
don't manage to squeeze in a layout before the JS drawImage(), the
SVG image gets laid out and rendered using the inline replaced box default size
value of 300x150. This patch only fixes the flakiness issue and
does not address the underlying bug (see webkit.org/b/206914).

* fast/hidpi/image-srcset-relative-svg-canvas-2x-expected.html:
* fast/hidpi/image-srcset-relative-svg-canvas-2x.html:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (255330 => 255331)


--- trunk/LayoutTests/ChangeLog	2020-01-29 01:54:03 UTC (rev 255330)
+++ trunk/LayoutTests/ChangeLog	2020-01-29 01:57:25 UTC (rev 255331)
@@ -1,3 +1,20 @@
+2020-01-28  Zalan Bujtas  <[email protected]>
+
+        REGRESSION: [ Mac ] fast/hidpi/image-srcset-relative-svg-canvas-2x.html is a flaky failure
+        https://bugs.webkit.org/show_bug.cgi?id=206254
+        <rdar://problem/58580461>
+
+        Reviewed by Simon Fraser.
+
+        The drawImage() and the HTML document layout are racy here and when we
+        don't manage to squeeze in a layout before the JS drawImage(), the
+        SVG image gets laid out and rendered using the inline replaced box default size
+        value of 300x150. This patch only fixes the flakiness issue and
+        does not address the underlying bug (see webkit.org/b/206914).
+
+        * fast/hidpi/image-srcset-relative-svg-canvas-2x-expected.html:
+        * fast/hidpi/image-srcset-relative-svg-canvas-2x.html:
+
 2020-01-28  Chris Dumez  <[email protected]>
 
         REGRESSION (r252064): [ Mac iOS ] storage/websql/statement-error-callback.html is timing out flakily

Modified: trunk/LayoutTests/fast/hidpi/image-srcset-relative-svg-canvas-2x-expected.html (255330 => 255331)


--- trunk/LayoutTests/fast/hidpi/image-srcset-relative-svg-canvas-2x-expected.html	2020-01-29 01:54:03 UTC (rev 255330)
+++ trunk/LayoutTests/fast/hidpi/image-srcset-relative-svg-canvas-2x-expected.html	2020-01-29 01:57:25 UTC (rev 255331)
@@ -23,6 +23,7 @@
   </div>
   <script>
     window.addEventListener('load', function(){
+        document.body.offsetHeight;
         drawCanvas('svg10', 'canvas6', 100, 50);
         if (window.testRunner)
             testRunner.notifyDone();

Modified: trunk/LayoutTests/fast/hidpi/image-srcset-relative-svg-canvas-2x.html (255330 => 255331)


--- trunk/LayoutTests/fast/hidpi/image-srcset-relative-svg-canvas-2x.html	2020-01-29 01:54:03 UTC (rev 255330)
+++ trunk/LayoutTests/fast/hidpi/image-srcset-relative-svg-canvas-2x.html	2020-01-29 01:57:25 UTC (rev 255331)
@@ -24,6 +24,7 @@
   </div>
   <script>
     window.addEventListener('load', function(){
+        document.body.offsetHeight;
         drawCanvas('svg10', 'canvas6', 100, 50);
         if (window.testRunner)
             testRunner.notifyDone();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to