Title: [255417] trunk/Source/WebCore
Revision
255417
Author
eric.carl...@apple.com
Date
2020-01-29 22:41:59 -0800 (Wed, 29 Jan 2020)

Log Message

Do not notify other applications when deactivating the audio session
https://bugs.webkit.org/show_bug.cgi?id=206963

Reviewed by Jer Noble.

Tested manually because this change is iOS-only and only reproduces on hardware.

* platform/audio/ios/AudioSessionIOS.mm:
(WebCore::AudioSession::tryToSetActiveInternal): Don't pass the AVAudioSessionSetActiveOptionNotifyOthersOnDeactivation
flag to -[AVAudioSession setActive:error].

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (255416 => 255417)


--- trunk/Source/WebCore/ChangeLog	2020-01-30 05:51:43 UTC (rev 255416)
+++ trunk/Source/WebCore/ChangeLog	2020-01-30 06:41:59 UTC (rev 255417)
@@ -1,3 +1,16 @@
+2020-01-29  Eric Carlson  <eric.carl...@apple.com>
+
+        Do not notify other applications when deactivating the audio session
+        https://bugs.webkit.org/show_bug.cgi?id=206963
+
+        Reviewed by Jer Noble.
+
+        Tested manually because this change is iOS-only and only reproduces on hardware.
+
+        * platform/audio/ios/AudioSessionIOS.mm:
+        (WebCore::AudioSession::tryToSetActiveInternal): Don't pass the AVAudioSessionSetActiveOptionNotifyOthersOnDeactivation
+        flag to -[AVAudioSession setActive:error].
+
 2020-01-29  Tim Horton  <timothy_hor...@apple.com>
 
         REGRESSION (r255322): macCatalyst: Tapping in an input field doesn't change the selection location

Modified: trunk/Source/WebCore/platform/audio/ios/AudioSessionIOS.mm (255416 => 255417)


--- trunk/Source/WebCore/platform/audio/ios/AudioSessionIOS.mm	2020-01-30 05:51:43 UTC (rev 255416)
+++ trunk/Source/WebCore/platform/audio/ios/AudioSessionIOS.mm	2020-01-30 06:41:59 UTC (rev 255417)
@@ -224,7 +224,7 @@
     }
 
     dispatch_async(m_private->m_dispatchQueue.get(), ^{
-        [[PAL::getAVAudioSessionClass() sharedInstance] setActive:NO withOptions:AVAudioSessionSetActiveOptionNotifyOthersOnDeactivation error:&error];
+        [[PAL::getAVAudioSessionClass() sharedInstance] setActive:NO withOptions:0 error:&error];
     });
 
     return true;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to