Title: [255421] trunk
- Revision
- 255421
- Author
- [email protected]
- Date
- 2020-01-30 05:27:46 -0800 (Thu, 30 Jan 2020)
Log Message
REGRESSION(r253636): [GTK] Mouse cursor changes using onMouseXYZ are erratic
https://bugs.webkit.org/show_bug.cgi?id=206454
Reviewed by Tim Horton.
Source/WebKit:
Since r253636 only platforms defining HAVE_NSCURSOR claim to support setting the cursor.
* WebProcess/WebCoreSupport/WebChromeClient.h: Do not implement supportsSettingCursor() for GTK port either.
LayoutTests:
* platform/gtk/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (255420 => 255421)
--- trunk/LayoutTests/ChangeLog 2020-01-30 13:10:07 UTC (rev 255420)
+++ trunk/LayoutTests/ChangeLog 2020-01-30 13:27:46 UTC (rev 255421)
@@ -1,3 +1,12 @@
+2020-01-30 Carlos Garcia Campos <[email protected]>
+
+ REGRESSION(r253636): [GTK] Mouse cursor changes using onMouseXYZ are erratic
+ https://bugs.webkit.org/show_bug.cgi?id=206454
+
+ Reviewed by Tim Horton.
+
+ * platform/gtk/TestExpectations:
+
2020-01-30 Noam Rosenthal <[email protected]>
REGRESSION (r254406): Gmail.com star/favorite icons are not rendering
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (255420 => 255421)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2020-01-30 13:10:07 UTC (rev 255420)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2020-01-30 13:27:46 UTC (rev 255421)
@@ -124,9 +124,6 @@
# WebKitGTK+ uses different keyboard accelerators than Safari (via Chromium).
fast/events/option-tab.html [ WontFix Failure ]
-webkit.org/b/206454 fast/events/mouse-cursor-change.html [ Failure ]
-webkit.org/b/206454 fast/events/mouse-cursor-no-mousemove.html [ Failure ]
-
# These tests expect a TIFF decoder (via Chromium).
# These pass while they're marked as WontFix - check it.
fast/images/embed-image.html [ WontFix Pass ]
Modified: trunk/Source/WebKit/ChangeLog (255420 => 255421)
--- trunk/Source/WebKit/ChangeLog 2020-01-30 13:10:07 UTC (rev 255420)
+++ trunk/Source/WebKit/ChangeLog 2020-01-30 13:27:46 UTC (rev 255421)
@@ -1,3 +1,14 @@
+2020-01-30 Carlos Garcia Campos <[email protected]>
+
+ REGRESSION(r253636): [GTK] Mouse cursor changes using onMouseXYZ are erratic
+ https://bugs.webkit.org/show_bug.cgi?id=206454
+
+ Reviewed by Tim Horton.
+
+ Since r253636 only platforms defining HAVE_NSCURSOR claim to support setting the cursor.
+
+ * WebProcess/WebCoreSupport/WebChromeClient.h: Do not implement supportsSettingCursor() for GTK port either.
+
2020-01-29 Tim Horton <[email protected]>
REGRESSION (r255322): macCatalyst: Tapping in an input field doesn't change the selection location
Modified: trunk/Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h (255420 => 255421)
--- trunk/Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h 2020-01-30 13:10:07 UTC (rev 255420)
+++ trunk/Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h 2020-01-30 13:27:46 UTC (rev 255421)
@@ -195,7 +195,7 @@
void setCursor(const WebCore::Cursor&) final;
void setCursorHiddenUntilMouseMoves(bool) final;
-#if !HAVE(NSCURSOR)
+#if !HAVE(NSCURSOR) && !PLATFORM(GTK)
bool supportsSettingCursor() final { return false; }
#endif
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
