Title: [255456] trunk/Source/WebKit
- Revision
- 255456
- Author
- [email protected]
- Date
- 2020-01-30 13:52:52 -0800 (Thu, 30 Jan 2020)
Log Message
REGRESSION (r253267): Swipe from edge on Twitter images no longer goes back
https://bugs.webkit.org/show_bug.cgi?id=207011
<rdar://problem/58966044>
Reviewed by Wenson Hsieh.
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView deferringGestureRecognizer:shouldDeferOtherGestureRecognizer:]):
The new touch-event async deferring gesture recognizer was erroneously deferring
edge swipes, which are not allowed to be blocked by touch events.
Opt them out of the new gesture gate mechanism.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (255455 => 255456)
--- trunk/Source/WebKit/ChangeLog 2020-01-30 21:36:37 UTC (rev 255455)
+++ trunk/Source/WebKit/ChangeLog 2020-01-30 21:52:52 UTC (rev 255456)
@@ -1,3 +1,17 @@
+2020-01-30 Tim Horton <[email protected]>
+
+ REGRESSION (r253267): Swipe from edge on Twitter images no longer goes back
+ https://bugs.webkit.org/show_bug.cgi?id=207011
+ <rdar://problem/58966044>
+
+ Reviewed by Wenson Hsieh.
+
+ * UIProcess/ios/WKContentViewInteraction.mm:
+ (-[WKContentView deferringGestureRecognizer:shouldDeferOtherGestureRecognizer:]):
+ The new touch-event async deferring gesture recognizer was erroneously deferring
+ edge swipes, which are not allowed to be blocked by touch events.
+ Opt them out of the new gesture gate mechanism.
+
2020-01-30 Jonathan Bedard <[email protected]>
PAL: Remove old iOS version macros
Modified: trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (255455 => 255456)
--- trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2020-01-30 21:36:37 UTC (rev 255455)
+++ trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2020-01-30 21:52:52 UTC (rev 255456)
@@ -6769,6 +6769,9 @@
- (BOOL)deferringGestureRecognizer:(WKDeferringGestureRecognizer *)deferringGestureRecognizer shouldDeferOtherGestureRecognizer:(UIGestureRecognizer *)gestureRecognizer
{
+ if ([_webView _isNavigationSwipeGestureRecognizer:gestureRecognizer])
+ return NO;
+
#if ENABLE(IOS_TOUCH_EVENTS)
auto isOneFingerMultipleTapGesture = [](UIGestureRecognizer *gesture) -> BOOL {
if (![gesture isKindOfClass:UITapGestureRecognizer.class])
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
