Title: [255496] trunk/Source/WebKit
- Revision
- 255496
- Author
- [email protected]
- Date
- 2020-01-31 08:07:18 -0800 (Fri, 31 Jan 2020)
Log Message
Remove unused WKProcessPool downloads SPI
https://bugs.webkit.org/show_bug.cgi?id=207029
rdar://problem/59052066
Reviewed by Anders Carlsson.
Remove two unused SPI for starting/resuming downloads from a process pool. These methods were
deprecated in favor of variants that also require a WKWebsiteDataStore, and all clients of these
methods have switched to the new versions.
* UIProcess/API/Cocoa/WKProcessPool.mm:
(-[WKProcessPool _downloadURLRequest:originatingWebView:]): Deleted.
(-[WKProcessPool _resumeDownloadFromData:path:originatingWebView:]): Deleted.
* UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (255495 => 255496)
--- trunk/Source/WebKit/ChangeLog 2020-01-31 15:44:40 UTC (rev 255495)
+++ trunk/Source/WebKit/ChangeLog 2020-01-31 16:07:18 UTC (rev 255496)
@@ -1,3 +1,20 @@
+2020-01-31 David Quesada <[email protected]>
+
+ Remove unused WKProcessPool downloads SPI
+ https://bugs.webkit.org/show_bug.cgi?id=207029
+ rdar://problem/59052066
+
+ Reviewed by Anders Carlsson.
+
+ Remove two unused SPI for starting/resuming downloads from a process pool. These methods were
+ deprecated in favor of variants that also require a WKWebsiteDataStore, and all clients of these
+ methods have switched to the new versions.
+
+ * UIProcess/API/Cocoa/WKProcessPool.mm:
+ (-[WKProcessPool _downloadURLRequest:originatingWebView:]): Deleted.
+ (-[WKProcessPool _resumeDownloadFromData:path:originatingWebView:]): Deleted.
+ * UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
+
2020-01-31 Don Olmstead <[email protected]>
[CMake] Add _PRIVATE_LIBRARIES to framework
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKProcessPool.mm (255495 => 255496)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKProcessPool.mm 2020-01-31 15:44:40 UTC (rev 255495)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKProcessPool.mm 2020-01-31 16:07:18 UTC (rev 255496)
@@ -598,16 +598,6 @@
}
#endif // PLATFORM(IOS_FAMILY)
-- (_WKDownload *)_downloadURLRequest:(NSURLRequest *)request originatingWebView:(WKWebView *)webView
-{
- return nil;
-}
-
-- (_WKDownload *)_resumeDownloadFromData:(NSData *)resumeData path:(NSString *)path originatingWebView:(WKWebView *)webView
-{
- return nil;
-}
-
- (_WKDownload *)_downloadURLRequest:(NSURLRequest *)request websiteDataStore:(WKWebsiteDataStore *)dataStore originatingWebView:(WKWebView *)webView
{
return wrapper(_processPool->download(*dataStore->_websiteDataStore, [webView _page], request));
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKProcessPoolPrivate.h (255495 => 255496)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKProcessPoolPrivate.h 2020-01-31 15:44:40 UTC (rev 255495)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKProcessPoolPrivate.h 2020-01-31 16:07:18 UTC (rev 255496)
@@ -82,9 +82,6 @@
- (void)_registerURLSchemeAsCanDisplayOnlyIfCanRequest:(NSString *)scheme WK_API_AVAILABLE(macos(10.14), ios(12.0));
-- (_WKDownload *)_downloadURLRequest:(NSURLRequest *)request originatingWebView:(WKWebView *)webView WK_API_DEPRECATED_WITH_REPLACEMENT("_downloadURLRequest:websiteDataStore:originatingWebView:", macos(10.14.4, WK_MAC_TBA), ios(12.2, WK_IOS_TBA));
-- (_WKDownload *)_resumeDownloadFromData:(NSData *)resumeData path:(NSString *)path originatingWebView:(WKWebView *)webView WK_API_DEPRECATED_WITH_REPLACEMENT("_resumeDownloadFromData:websiteDataStore:path:originatingWebView:", macos(10.14.4, WK_MAC_TBA), ios(12.2, WK_IOS_TBA));
-
- (_WKDownload *)_downloadURLRequest:(NSURLRequest *)request websiteDataStore:(WKWebsiteDataStore *)dataStore originatingWebView:(WKWebView *)webView WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));
- (_WKDownload *)_resumeDownloadFromData:(NSData *)resumeData websiteDataStore:(WKWebsiteDataStore *)dataStore path:(NSString *)path originatingWebView:(WKWebView *)webView WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
