Title: [255503] trunk/Source/WebKit
- Revision
- 255503
- Author
- [email protected]
- Date
- 2020-01-31 09:54:21 -0800 (Fri, 31 Jan 2020)
Log Message
REGRESSION (r251511): [iOS] HDR Playback broken
https://bugs.webkit.org/show_bug.cgi?id=207052
<rdar://problem/58975614>
Reviewed by Maciej Stachowiak.
I missed an XPC service in Bug 203318 when I stopped importing the 'common.sb' sandbox. This broke some
aspects of HDR playback for certain clients.
This patch returns the XPC service, and unblocks access to a network preference file that AVFoundation
needs to read to support some media playback features.
* Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:
* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (255502 => 255503)
--- trunk/Source/WebKit/ChangeLog 2020-01-31 17:31:21 UTC (rev 255502)
+++ trunk/Source/WebKit/ChangeLog 2020-01-31 17:54:21 UTC (rev 255503)
@@ -1,3 +1,20 @@
+2020-01-31 Brent Fulgham <[email protected]>
+
+ REGRESSION (r251511): [iOS] HDR Playback broken
+ https://bugs.webkit.org/show_bug.cgi?id=207052
+ <rdar://problem/58975614>
+
+ Reviewed by Maciej Stachowiak.
+
+ I missed an XPC service in Bug 203318 when I stopped importing the 'common.sb' sandbox. This broke some
+ aspects of HDR playback for certain clients.
+
+ This patch returns the XPC service, and unblocks access to a network preference file that AVFoundation
+ needs to read to support some media playback features.
+
+ * Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:
+ * Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
+
2020-01-31 Alejandro G. Castro <[email protected]>
Compilation broken without service workers
Modified: trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb (255502 => 255503)
--- trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb 2020-01-31 17:31:21 UTC (rev 255502)
+++ trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb 2020-01-31 17:54:21 UTC (rev 255503)
@@ -143,6 +143,7 @@
(global-name "com.apple.coremedia.audioprocessingtap.xpc")
(global-name "com.apple.coremedia.capturesession") ; Actually for video capture
(global-name "com.apple.coremedia.capturesource") ; Also for video capture (<rdar://problem/15794291>).
+ (global-name "com.apple.coremedia.cpe.xpc") ; Needed for HDR playback.
(global-name "com.apple.coremedia.customurlloader.xpc") ; Needed for custom media loading
(global-name "com.apple.coremedia.formatreader.xpc")
(global-name "com.apple.coremedia.player.xpc")
@@ -174,6 +175,10 @@
"com.apple.audio.virtualaudio" ; <rdar://problem/57170333>
)
+ ;; AVF needs to see these network preferences:
+ (allow file-read*
+ (literal "/private/var/preferences/com.apple.networkd.plist"))
+
;; Required by the MediaPlayer framework.
(allow mach-lookup
(global-name "com.apple.audio.AudioSession"))
Modified: trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb (255502 => 255503)
--- trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb 2020-01-31 17:31:21 UTC (rev 255502)
+++ trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb 2020-01-31 17:54:21 UTC (rev 255503)
@@ -157,6 +157,7 @@
(global-name "com.apple.coremedia.audioprocessingtap.xpc")
(global-name "com.apple.coremedia.capturesession") ; Actually for video capture
(global-name "com.apple.coremedia.capturesource") ; Also for video capture (<rdar://problem/15794291>).
+ (global-name "com.apple.coremedia.cpe.xpc") ; Needed for HDR playback.
(global-name "com.apple.coremedia.customurlloader.xpc") ; Needed for custom media loading
(global-name "com.apple.coremedia.formatreader.xpc")
(global-name "com.apple.coremedia.player.xpc")
@@ -188,6 +189,10 @@
"com.apple.audio.virtualaudio" ; <rdar://problem/57170333>
)
+ ;; AVF needs to see these network preferences:
+ (allow file-read*
+ (literal "/private/var/preferences/com.apple.networkd.plist"))
+
;; Required by the MediaPlayer framework.
(allow mach-lookup
(global-name "com.apple.audio.AudioSession"))
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
