Title: [255513] trunk/Tools
- Revision
- 255513
- Author
- [email protected]
- Date
- 2020-01-31 11:38:19 -0800 (Fri, 31 Jan 2020)
Log Message
[ews] Display flaky test names in build summary when ReRunWebKitTests passes
https://bugs.webkit.org/show_bug.cgi?id=207050
Reviewed by Jonathan Bedard.
* BuildSlaveSupport/ews-build/steps.py:
(ReRunWebKitTests.evaluateCommand):
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/ews-build/steps.py (255512 => 255513)
--- trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2020-01-31 19:26:12 UTC (rev 255512)
+++ trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2020-01-31 19:38:19 UTC (rev 255513)
@@ -1351,10 +1351,20 @@
def evaluateCommand(self, cmd):
rc = self.evaluateResult(cmd)
+ first_results_did_exceed_test_failure_limit = self.getProperty('first_results_exceed_failure_limit')
+ first_results_failing_tests = set(self.getProperty('first_run_failures', []))
+ second_results_did_exceed_test_failure_limit = self.getProperty('second_results_exceed_failure_limit')
+ second_results_failing_tests = set(self.getProperty('second_run_failures', []))
+ tests_that_consistently_failed = first_results_failing_tests.intersection(second_results_failing_tests)
+ flaky_failures = first_results_failing_tests.union(second_results_failing_tests) - first_results_failing_tests.intersection(second_results_failing_tests)
+ flaky_failures_string = ', '.join(flaky_failures)
+
if rc == SUCCESS or rc == WARNINGS:
message = 'Passed layout tests'
self.descriptionDone = message
self.build.results = SUCCESS
+ if not first_results_did_exceed_test_failure_limit:
+ message = 'Found flaky tests: {}'.format(flaky_failures_string)
self.build.buildFinished([message], SUCCESS)
else:
self.setProperty('patchFailedTests', True)
Modified: trunk/Tools/ChangeLog (255512 => 255513)
--- trunk/Tools/ChangeLog 2020-01-31 19:26:12 UTC (rev 255512)
+++ trunk/Tools/ChangeLog 2020-01-31 19:38:19 UTC (rev 255513)
@@ -1,3 +1,13 @@
+2020-01-31 Aakash Jain <[email protected]>
+
+ [ews] Display flaky test names in build summary when ReRunWebKitTests passes
+ https://bugs.webkit.org/show_bug.cgi?id=207050
+
+ Reviewed by Jonathan Bedard.
+
+ * BuildSlaveSupport/ews-build/steps.py:
+ (ReRunWebKitTests.evaluateCommand):
+
2020-01-31 David Kilzer <[email protected]>
REGRESSION: [ iPadOS ] imported/w3c/web-platform-tests/dom/events/Event-dispatch-on-disabled-elements.html always fails
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
